You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@mynewt.apache.org by "MariuszSkamra (via GitHub)" <gi...@apache.org> on 2026/10/05 13:00:44 UTC
[PR] nimble/ll: Ignore retransmitted PDUs in encryption PDU filter [mynewt-nimble]
MariuszSkamra opened a new pull request, #2306:
URL: https://github.com/apache/mynewt-nimble/pull/2306
This fixes an issue seen while encryption is being started. Every PDU that was not allowed in the current encryption state terminates the connection with MIC failure reason. The check was made before SN check so there was a possibility that remote did not ACKed our PDU (probably PDU loss), and resent (like LL_START_ENC_REQ resent after we moved to START_ENC_RSP_WAIT).
In all cases a single lost ACK caused the link to be dropped instead of the encryption procedure completing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] nimble/ll: Discard retransmitted PDUs before the encryption checks [mynewt-nimble]
Posted by "MariuszSkamra (via GitHub) via notifications" <no...@mynewt.apache.org>.
MariuszSkamra commented on code in PR #2306:
URL: https://github.com/apache/mynewt-nimble/pull/2306#discussion_r4453246004
##########
nimble/controller/src/ble_ll_conn.c:
##########
Review Comment:
@rymanluk I have made the change as you suggested, but now I see that it will break the authenticated payload timer logic. Core Vol 5 Part B 5.4 LE Authenticated Payload Timeout says the timer "defines the maximum amount of time, in milliseconds, allowed between receiving ACL packets containing a valid MIC". So even if it's retransmitted packet, the timeout shall be restarted. I will revert the change back to the initial version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] nimble/ll: Ignore retransmitted PDUs in encryption PDU filter [mynewt-nimble]
Posted by "andrzej-kaczmarek (via GitHub) via notifications" <no...@mynewt.apache.org>.
andrzej-kaczmarek merged PR #2306:
URL: https://github.com/apache/mynewt-nimble/pull/2306
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] nimble/ll: Ignore retransmitted PDUs in encryption PDU filter [mynewt-nimble]
Posted by "rymanluk (via GitHub)" <gi...@apache.org>.
rymanluk commented on code in PR #2306:
URL: https://github.com/apache/mynewt-nimble/pull/2306#discussion_r4184309349
##########
nimble/controller/src/ble_ll_conn.c:
##########
Review Comment:
maybe we could move this check up -> around line 3529 and then we could remove additional check you did in in 3563 and 3536 ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] nimble/ll: Discard retransmitted PDUs before the encryption checks [mynewt-nimble]
Posted by "MariuszSkamra (via GitHub) via notifications" <no...@mynewt.apache.org>.
MariuszSkamra commented on code in PR #2306:
URL: https://github.com/apache/mynewt-nimble/pull/2306#discussion_r4453145999
##########
nimble/controller/src/ble_ll_conn.c:
##########
Review Comment:
I'm not sure whether this will not break the auth_pyld_rx_time logic
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] nimble/ll: Ignore retransmitted PDUs in encryption PDU filter [mynewt-nimble]
Posted by "MariuszSkamra (via GitHub) via notifications" <no...@mynewt.apache.org>.
MariuszSkamra commented on code in PR #2306:
URL: https://github.com/apache/mynewt-nimble/pull/2306#discussion_r4452406549
##########
nimble/controller/src/ble_ll_conn.c:
##########
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] nimble/ll: Ignore retransmitted PDUs in encryption PDU filter [mynewt-nimble]
Posted by "MariuszSkamra (via GitHub)" <gi...@apache.org>.
MariuszSkamra commented on PR #2306:
URL: https://github.com/apache/mynewt-nimble/pull/2306#issuecomment-5994969151
@andrzej-kaczmarek @rymanluk ^^
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] nimble/ll: Discard retransmitted PDUs before the encryption checks [mynewt-nimble]
Posted by "MariuszSkamra (via GitHub) via notifications" <no...@mynewt.apache.org>.
MariuszSkamra commented on PR #2306:
URL: https://github.com/apache/mynewt-nimble/pull/2306#issuecomment-6605351568
reverted back to original version of this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org