You are viewing a plain text version of this content. The canonical link for it is here.
Posted to oak-dev@jackrabbit.apache.org by "ionutzpi (via GitHub)" <gi...@apache.org> on 2024/06/17 10:52:37 UTC
[PR] OAK-10890 - Added log warning [jackrabbit-oak]
ionutzpi opened a new pull request, #1535:
URL: https://github.com/apache/jackrabbit-oak/pull/1535
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: oak-dev-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] OAK-10890 - Added log warning [jackrabbit-oak]
Posted by "stefan-egli (via GitHub)" <gi...@apache.org>.
stefan-egli merged PR #1535:
URL: https://github.com/apache/jackrabbit-oak/pull/1535
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: oak-dev-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] OAK-10890 - Added log warning [jackrabbit-oak]
Posted by "ionutzpi (via GitHub)" <gi...@apache.org>.
ionutzpi commented on PR #1535:
URL: https://github.com/apache/jackrabbit-oak/pull/1535#issuecomment-2173297991
> @ionutzpi should I go ahead and merge, i.e. is the PR ready?
yes, the PR is ready
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: oak-dev-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] OAK-10890 - Added log warning [jackrabbit-oak]
Posted by "stefan-egli (via GitHub)" <gi...@apache.org>.
stefan-egli commented on PR #1535:
URL: https://github.com/apache/jackrabbit-oak/pull/1535#issuecomment-2173190927
+1 other than the minor comment.
PS: there's another case of 0030 in [UniquenessConstraintValidator](https://github.com/apache/jackrabbit-oak/blob/0e327a27eb988a0f7656535275f3735ef8474e5d/oak-lucene/src/main/java/org/apache/jackrabbit/oak/plugins/index/lucene/property/UniquenessConstraintValidator.java#L81) but I'd go with this PropertyIndexEditor as a start. Was also wondering if the fact that it contains the effected paths is a leak of sorts - but given the CommitFailedException is frequently logged anyway, that doesn't seem to be a problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: oak-dev-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] OAK-10890 - Added log warning [jackrabbit-oak]
Posted by "ionutzpi (via GitHub)" <gi...@apache.org>.
ionutzpi commented on code in PR #1535:
URL: https://github.com/apache/jackrabbit-oak/pull/1535#discussion_r1642721575
##########
oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/index/property/PropertyIndexEditor.java:
##########
@@ -328,6 +332,7 @@ private void checkUniquenessConstraints() throws CommitFailedException {
String msg = String.format(
"Uniqueness constraint violated property %s having value %s",
propertyNames, failed);
+ log.warn(msg);
Review Comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: oak-dev-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] OAK-10890 - Added log warning [jackrabbit-oak]
Posted by "stefan-egli (via GitHub)" <gi...@apache.org>.
stefan-egli commented on PR #1535:
URL: https://github.com/apache/jackrabbit-oak/pull/1535#issuecomment-2173265117
@ionutzpi should I go ahead and merge, i.e. is the PR ready?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: oak-dev-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] OAK-10890 - Added log warning [jackrabbit-oak]
Posted by "stefan-egli (via GitHub)" <gi...@apache.org>.
stefan-egli commented on code in PR #1535:
URL: https://github.com/apache/jackrabbit-oak/pull/1535#discussion_r1642692392
##########
oak-core/src/main/java/org/apache/jackrabbit/oak/plugins/index/property/PropertyIndexEditor.java:
##########
@@ -328,6 +332,7 @@ private void checkUniquenessConstraints() throws CommitFailedException {
String msg = String.format(
"Uniqueness constraint violated property %s having value %s",
propertyNames, failed);
+ log.warn(msg);
Review Comment:
I'm wondering if we should add a prefix to the log. Without the prefix it might be hard for down-stream logging to distinguish between the two sources of this message (the log.warn and the exception), as they contain a large common part. What about something like below (or maybe a better variant of it) ?
```suggestion
log.warn("checkUniquenessConstraints: " + msg);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: oak-dev-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] OAK-10890 - Added log warning [jackrabbit-oak]
Posted by "stefan-egli (via GitHub)" <gi...@apache.org>.
stefan-egli commented on PR #1535:
URL: https://github.com/apache/jackrabbit-oak/pull/1535#issuecomment-2173430866
ok - just checking why the build fails - restarted it now at https://ci-builds.apache.org/job/Jackrabbit/job/oak-trunk-pr/job/PR-1535/3/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: oak-dev-unsubscribe@jackrabbit.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org