You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@activemq.apache.org by "Pablo Guerrero (Created) (JIRA)" <ji...@apache.org> on 2012/04/20 15:56:40 UTC
[jira] [Created] (APLO-196) Allow to drop a message in a protocol
filter
Allow to drop a message in a protocol filter
--------------------------------------------
Key: APLO-196
URL: https://issues.apache.org/jira/browse/APLO-196
Project: ActiveMQ Apollo
Issue Type: New Feature
Reporter: Pablo Guerrero
This could be implemented by itself, or, when the issue APLO-195 is solved, just by removing the return value of the filtering function.
Then, you could just resend the current message, if needed, or do nothing in case you want to drop it. Depending of the implementation of APLO-195, a helper function for the resend situation could be handy.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (APLO-196) Allow protocol filters to drop a
messages
Posted by "Hiram Chirino (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/APLO-196?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hiram Chirino updated APLO-196:
-------------------------------
Summary: Allow protocol filters to drop a messages (was: Allow to drop a message in a protocol filter)
> Allow protocol filters to drop a messages
> -----------------------------------------
>
> Key: APLO-196
> URL: https://issues.apache.org/jira/browse/APLO-196
> Project: ActiveMQ Apollo
> Issue Type: New Feature
> Reporter: Pablo Guerrero
>
> This could be implemented by itself, or, when the issue APLO-195 is solved, just by removing the return value of the filtering function.
> Then, you could just resend the current message, if needed, or do nothing in case you want to drop it. Depending of the implementation of APLO-195, a helper function for the resend situation could be handy.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (APLO-196) Allow protocol filters to drop a
messages
Posted by "Hiram Chirino (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/APLO-196?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hiram Chirino resolved APLO-196.
--------------------------------
Resolution: Fixed
new interface commited.. should be available in next nightly.
> Allow protocol filters to drop a messages
> -----------------------------------------
>
> Key: APLO-196
> URL: https://issues.apache.org/jira/browse/APLO-196
> Project: ActiveMQ Apollo
> Issue Type: New Feature
> Components: apollo-broker, apollo-stomp
> Affects Versions: 1.2
> Reporter: Pablo Guerrero
> Assignee: Hiram Chirino
> Fix For: 1.3
>
>
> This could be implemented by itself, or, when the issue APLO-195 is solved, just by removing the return value of the filtering function.
> Then, you could just resend the current message, if needed, or do nothing in case you want to drop it. Depending of the implementation of APLO-195, a helper function for the resend situation could be handy.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Issue Comment Edited] (APLO-196) Allow to drop a message in
a protocol filter
Posted by "Hiram Chirino (Issue Comment Edited) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/APLO-196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13258370#comment-13258370 ]
Hiram Chirino edited comment on APLO-196 at 4/20/12 4:55 PM:
-------------------------------------------------------------
Hi Pablo,
How about we define a new more powerful Filtering interface. How does this look to you?
/**
* A Protocol filter can filter frames being sent/received to and from a client. It can modify
* the frame or even drop it.
*/
abstract class ProtocolFilter2 {
/**
* Filters a command frame received from a client.
* returns None if the filter wants to drop the frame.
*/
def filter_inbound[T](frame: T):Option[T]
/**
* Filters a command frame being sent client.
* returns None if the filter wants to drop the frame.
*/
def filter_outbound[T](frame: T):Option[T]
}
was (Author: chirino):
Hi Pablo,
How about we define a new more powerful Filtering interface. How does this look to you?
/**
* A Protocol filter can command frame being sent/receive to and from client. It can modify
* the frame or even drop it.
*/
abstract class ProtocolFilter2 {
/**
* Filters a command frame received from a client.
* returns None if the filter wants to drop the frame.
*/
def filter_inbound[T](frame: T):Option[T]
/**
* Filters a command frame being sent client.
* returns None if the filter wants to drop the frame.
*/
def filter_outbound[T](frame: T):Option[T]
}
> Allow to drop a message in a protocol filter
> --------------------------------------------
>
> Key: APLO-196
> URL: https://issues.apache.org/jira/browse/APLO-196
> Project: ActiveMQ Apollo
> Issue Type: New Feature
> Reporter: Pablo Guerrero
>
> This could be implemented by itself, or, when the issue APLO-195 is solved, just by removing the return value of the filtering function.
> Then, you could just resend the current message, if needed, or do nothing in case you want to drop it. Depending of the implementation of APLO-195, a helper function for the resend situation could be handy.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (APLO-196) Allow to drop a message in a protocol
filter
Posted by "Hiram Chirino (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/APLO-196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13258370#comment-13258370 ]
Hiram Chirino commented on APLO-196:
------------------------------------
Hi Pablo,
How about we define a new more powerful Filtering interface. How does this look to you?
/**
* A Protocol filter can command frame being sent/receive to and from client. It can modify
* the frame or even drop it.
*/
abstract class ProtocolFilter2 {
/**
* Filters a command frame received from a client.
* returns None if the filter wants to drop the frame.
*/
def filter_inbound[T](frame: T):Option[T]
/**
* Filters a command frame being sent client.
* returns None if the filter wants to drop the frame.
*/
def filter_outbound[T](frame: T):Option[T]
}
> Allow to drop a message in a protocol filter
> --------------------------------------------
>
> Key: APLO-196
> URL: https://issues.apache.org/jira/browse/APLO-196
> Project: ActiveMQ Apollo
> Issue Type: New Feature
> Reporter: Pablo Guerrero
>
> This could be implemented by itself, or, when the issue APLO-195 is solved, just by removing the return value of the filtering function.
> Then, you could just resend the current message, if needed, or do nothing in case you want to drop it. Depending of the implementation of APLO-195, a helper function for the resend situation could be handy.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (APLO-196) Allow protocol filters to drop a
messages
Posted by "Hiram Chirino (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/APLO-196?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hiram Chirino updated APLO-196:
-------------------------------
Component/s: apollo-stomp
apollo-broker
Affects Version/s: 1.2
Fix Version/s: 1.3
Assignee: Hiram Chirino
> Allow protocol filters to drop a messages
> -----------------------------------------
>
> Key: APLO-196
> URL: https://issues.apache.org/jira/browse/APLO-196
> Project: ActiveMQ Apollo
> Issue Type: New Feature
> Components: apollo-broker, apollo-stomp
> Affects Versions: 1.2
> Reporter: Pablo Guerrero
> Assignee: Hiram Chirino
> Fix For: 1.3
>
>
> This could be implemented by itself, or, when the issue APLO-195 is solved, just by removing the return value of the filtering function.
> Then, you could just resend the current message, if needed, or do nothing in case you want to drop it. Depending of the implementation of APLO-195, a helper function for the resend situation could be handy.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (APLO-196) Allow to drop a message in a protocol
filter
Posted by "Pablo Guerrero (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/APLO-196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13259446#comment-13259446 ]
Pablo Guerrero commented on APLO-196:
-------------------------------------
Hi Hiram,
That looks good for us. We get the option of dropping messages and we can work properly with inbound and outbound messages.
Cheers,
Pablo
> Allow to drop a message in a protocol filter
> --------------------------------------------
>
> Key: APLO-196
> URL: https://issues.apache.org/jira/browse/APLO-196
> Project: ActiveMQ Apollo
> Issue Type: New Feature
> Reporter: Pablo Guerrero
>
> This could be implemented by itself, or, when the issue APLO-195 is solved, just by removing the return value of the filtering function.
> Then, you could just resend the current message, if needed, or do nothing in case you want to drop it. Depending of the implementation of APLO-195, a helper function for the resend situation could be handy.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira