You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@apr.apache.org by Daniel Sahlberg <da...@gmail.com> on 2024/07/08 19:02:07 UTC
Website updates [PATCH]
Hi,
In a thread a while back, I asked about building on win32 and suggested to
improve the documentation[1].
At first I wanted to take a look at the website and try to figure out how
it all connects.
This is the first in what I hope will be a series of patches to improve the
website.
I have a few things in mind:
- Building the website on Windows.
- Fix ASF website check nag about missing link to the privacy policy [2]
- Making the website more mobile friendly (basically a responsive CSS that
will fold the menu into a hamburger when browsing on limited width, adding
website manifest etc, compare with https://subversion.apache.org where I
did the same thing in r1891758 [3]).
- Getting APR to build under Visual Studio 2022 and documenting my progress
in compiling_win32.html
If someone feels strongly about anything of the above ("don't waste your
time!"), please chime in.
With the introduction done, I'm attaching two patches to create a
"build.bat" file (replicating the job done by build.sh). I initially copied
build.sh to create the first patch:
[[[
C:\devel\apr_site>svn copy build.sh build.bat
...edit...
c:\devel\apr_site>svn diff >build_bat_coppiedfromsh.txt
]]]
However the copy-from didn't turn up in the patch (and I should probably
have known that) and since I wasn't sure if this was even wanted, I've also
created a plain patch with the file added from scratch.
Kind regards,
Daniel Sahlberg
[1] https://lists.apache.org/thread/b40v59rr36odjn6ykphl561vk89y623l
[2] https://whimsy.apache.org/site/project/apr
[3] https://svn.apache.org/viewvc?view=revision&revision=1891758
Re: Website updates [PATCH]
Posted by Ivan Zhakov <iv...@apache.org>.
On Wed, 17 Jul 2024 at 10:44, Daniel Sahlberg <da...@gmail.com>
wrote:
> Den lör 13 juli 2024 kl 18:21 skrev Ivan Zhakov <iv...@apache.org>:
>
>> The problem was that build.bat in the patch contained "%*" (with
>> quotes). In case of no parameters it was evaluated as "", so ant was
>> executed with no targets.
>> I removed quotes and worked for me.
>>
>
> Good catch, thanks! I couldn't figure out why I always had to add the docs
> target manually...
>
>
>> I have committed a tweaked patch in r1919188.
>>
>>
> Great! May I ask why you removed @echo off in r1919200? Rebuilding the
> site now is quite noisy.
>
> It was not intentional. Added it back in r1919309. Thanks!
>
>
>> I also configured support for the "Build" command for Visual Studio in
>> Open Folder mode. So now the website can be regenerated via the context
>> menu for folder root in Visual Studio.
>>
>
> That's really cool =)
>
> Also note that build.bat sometimes doesn't rebuild the website properly
because it checks timestamps. I added Rebuild command to force rebuild all
website ignoring timestamps to solve this problem.
--
Ivan Zhakov
Re: Website updates [PATCH]
Posted by Daniel Sahlberg <da...@gmail.com>.
Den lör 13 juli 2024 kl 18:21 skrev Ivan Zhakov <iv...@apache.org>:
> The problem was that build.bat in the patch contained "%*" (with quotes).
> In case of no parameters it was evaluated as "", so ant was executed with
> no targets.
> I removed quotes and worked for me.
>
Good catch, thanks! I couldn't figure out why I always had to add the docs
target manually...
> I have committed a tweaked patch in r1919188.
>
>
Great! May I ask why you removed @echo off in r1919200? Rebuilding the site
now is quite noisy.
> I also configured support for the "Build" command for Visual Studio in
> Open Folder mode. So now the website can be regenerated via the context
> menu for folder root in Visual Studio.
>
That's really cool =)
Kind regards,
Daniel
Re: Website updates [PATCH]
Posted by Ivan Zhakov <iv...@apache.org>.
On Sat, 13 Jul 2024 at 17:40, Ivan Zhakov <iv...@apache.org> wrote:
> On Mon, 8 Jul 2024 at 21:03, Daniel Sahlberg <da...@gmail.com>
> wrote:
>
>> Hi,
>>
>> In a thread a while back, I asked about building on win32 and suggested
>> to improve the documentation[1].
>>
>> At first I wanted to take a look at the website and try to figure out how
>> it all connects.
>>
>> This is the first in what I hope will be a series of patches to improve
>> the website.
>>
>> I have a few things in mind:
>> - Building the website on Windows.
>> - Fix ASF website check nag about missing link to the privacy policy [2]
>> - Making the website more mobile friendly (basically a responsive CSS
>> that will fold the menu into a hamburger when browsing on limited width,
>> adding website manifest etc, compare with https://subversion.apache.org
>> where I did the same thing in r1891758 [3]).
>> - Getting APR to build under Visual Studio 2022 and documenting my
>> progress in compiling_win32.html
>>
>> If someone feels strongly about anything of the above ("don't waste your
>> time!"), please chime in.
>>
>> With the introduction done, I'm attaching two patches to create a
>> "build.bat" file (replicating the job done by build.sh). I initially copied
>> build.sh to create the first patch:
>> [[[
>> C:\devel\apr_site>svn copy build.sh build.bat
>> ...edit...
>> c:\devel\apr_site>svn diff >build_bat_coppiedfromsh.txt
>> ]]]
>>
>> However the copy-from didn't turn up in the patch (and I should probably
>> have known that) and since I wasn't sure if this was even wanted, I've also
>> created a plain patch with the file added from scratch.
>>
>>
>> Hi Daniel,
>
> It would be nice to have an option to build a website on Windows. Your
> patch looks good, but for some reason it doesn't update the website in my
> environment. It seems to be running successfully, but doesn't change files
> in docs/ directory:
> [[[
> Buildfile: build.xml
> Overriding previous definition of reference to classpath
>
> BUILD SUCCESSFUL
> Total time: 0 seconds
> ]]]
>
> I am using JDK 22.0.1.
>
> Do you have any ideas?
>
>
The problem was that build.bat in the patch contained "%*" (with quotes).
In case of no parameters it was evaluated as "", so ant was executed with
no targets.
I removed quotes and worked for me.
I have committed a tweaked patch in r1919188.
I also configured support for the "Build" command for Visual Studio in Open
Folder mode. So now the website can be regenerated via the context menu for
folder root in Visual Studio.
Thanks!
--
Ivan Zhakov
Re: Website updates [PATCH]
Posted by Ivan Zhakov <iv...@apache.org>.
On Mon, 8 Jul 2024 at 21:03, Daniel Sahlberg <da...@gmail.com>
wrote:
> Hi,
>
> In a thread a while back, I asked about building on win32 and suggested to
> improve the documentation[1].
>
> At first I wanted to take a look at the website and try to figure out how
> it all connects.
>
> This is the first in what I hope will be a series of patches to improve
> the website.
>
> I have a few things in mind:
> - Building the website on Windows.
> - Fix ASF website check nag about missing link to the privacy policy [2]
> - Making the website more mobile friendly (basically a responsive CSS that
> will fold the menu into a hamburger when browsing on limited width, adding
> website manifest etc, compare with https://subversion.apache.org where I
> did the same thing in r1891758 [3]).
> - Getting APR to build under Visual Studio 2022 and documenting my
> progress in compiling_win32.html
>
> If someone feels strongly about anything of the above ("don't waste your
> time!"), please chime in.
>
> With the introduction done, I'm attaching two patches to create a
> "build.bat" file (replicating the job done by build.sh). I initially copied
> build.sh to create the first patch:
> [[[
> C:\devel\apr_site>svn copy build.sh build.bat
> ...edit...
> c:\devel\apr_site>svn diff >build_bat_coppiedfromsh.txt
> ]]]
>
> However the copy-from didn't turn up in the patch (and I should probably
> have known that) and since I wasn't sure if this was even wanted, I've also
> created a plain patch with the file added from scratch.
>
>
> Hi Daniel,
It would be nice to have an option to build a website on Windows. Your
patch looks good, but for some reason it doesn't update the website in my
environment. It seems to be running successfully, but doesn't change files
in docs/ directory:
[[[
Buildfile: build.xml
Overriding previous definition of reference to classpath
BUILD SUCCESSFUL
Total time: 0 seconds
]]]
I am using JDK 22.0.1.
Do you have any ideas?
--
Ivan Zhakov
Re: Website updates [PATCH]
Posted by Ivan Zhakov <iv...@apache.org>.
On Mon, 8 Jul 2024 at 21:50, Daniel Sahlberg <da...@gmail.com>
wrote:
> Den mån 8 juli 2024 kl 21:26 skrev Daniel Sahlberg <
> daniel.l.sahlberg@gmail.com>:
>
>> Den mån 8 juli 2024 kl 21:02 skrev Daniel Sahlberg <
>> daniel.l.sahlberg@gmail.com>:
>>
>>> - Fix ASF website check nag about missing link to the privacy policy [2]
>>>
>>
>> Attaching a proposed patch in two parts, just adding the link under
>> Miscellaneous next to the other ASF-mandated links. The _xdocs.txt patch is
>> the changes to the website source. The _docs.txt patch is the change in
>> generated output - attached if you don't want to rebuild the site from
>> sources.
>>
>
> I have committed the fix with a privacy policy link in r1919198.
Just realised that docs folder was never updated after r1915055 (removing
> links to mail-archives.apache.org), so the previous _docs.txt patch also
> contained those changes. Maybe this patch should be applied first, or a
> total rebuild of docs should be done after everything else.
>
> I have regenerated the site in r1919196.
Thanks!!
--
Ivan Zhakov
Re: Website updates [PATCH]
Posted by Daniel Sahlberg <da...@gmail.com>.
Den mån 8 juli 2024 kl 21:26 skrev Daniel Sahlberg <
daniel.l.sahlberg@gmail.com>:
> Den mån 8 juli 2024 kl 21:02 skrev Daniel Sahlberg <
> daniel.l.sahlberg@gmail.com>:
>
>> - Fix ASF website check nag about missing link to the privacy policy [2]
>>
>
> Attaching a proposed patch in two parts, just adding the link under
> Miscellaneous next to the other ASF-mandated links. The _xdocs.txt patch is
> the changes to the website source. The _docs.txt patch is the change in
> generated output - attached if you don't want to rebuild the site from
> sources.
>
Just realised that docs folder was never updated after r1915055 (removing
links to mail-archives.apache.org), so the previous _docs.txt patch also
contained those changes. Maybe this patch should be applied first, or a
total rebuild of docs should be done after everything else.
Kind regards,
Daniel Sahlberg
>
>> [2] https://whimsy.apache.org/site/project/apr
>>
>
Re: Website updates [PATCH]
Posted by Daniel Sahlberg <da...@gmail.com>.
Den mån 8 juli 2024 kl 21:02 skrev Daniel Sahlberg <
daniel.l.sahlberg@gmail.com>:
> - Fix ASF website check nag about missing link to the privacy policy [2]
>
Attaching a proposed patch in two parts, just adding the link under
Miscellaneous next to the other ASF-mandated links. The _xdocs.txt patch is
the changes to the website source. The _docs.txt patch is the change in
generated output - attached if you don't want to rebuild the site from
sources.
Kind regards,
Daniel Sahlberg
> [2] https://whimsy.apache.org/site/project/apr
>