You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@avro.apache.org by mg...@apache.org on 2022/02/02 07:26:42 UTC

[avro] branch master updated: AVRO-3348 Updated ProcessSchemas to meet styling guidelines (#1498)

This is an automated email from the ASF dual-hosted git repository.

mgrigorov pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/avro.git


The following commit(s) were added to refs/heads/master by this push:
     new bfe65c6  AVRO-3348 Updated ProcessSchemas to meet styling guidelines (#1498)
bfe65c6 is described below

commit bfe65c688c9f67c7491e394439ce4deb24b14db2
Author: Kyle Schoonover <ky...@minmaxcorp.com>
AuthorDate: Tue Feb 1 23:26:33 2022 -0800

    AVRO-3348 Updated ProcessSchemas to meet styling guidelines (#1498)
    
    * AVRO-3348 Updated ProcessSchemas to meet styling guidelines
    
    * Updated messaging
    
    Co-authored-by: Kyle T. Schoonover <Ky...@nordstrom.com>
---
 lang/csharp/src/apache/main/CodeGen/CodeGen.cs | 24 +++++++++++++++++-------
 1 file changed, 17 insertions(+), 7 deletions(-)

diff --git a/lang/csharp/src/apache/main/CodeGen/CodeGen.cs b/lang/csharp/src/apache/main/CodeGen/CodeGen.cs
index 7a0b358..669094b 100644
--- a/lang/csharp/src/apache/main/CodeGen/CodeGen.cs
+++ b/lang/csharp/src/apache/main/CodeGen/CodeGen.cs
@@ -78,10 +78,10 @@ namespace Avro
         /// </summary>
         public CodeGen()
         {
-            this.Schemas = new List<Schema>();
-            this.Protocols = new List<Protocol>();
-            this.NamespaceMapping = new Dictionary<string, string>();
-            this.NamespaceLookup = new Dictionary<string, CodeNamespace>(StringComparer.Ordinal);
+            Schemas = new List<Schema>();
+            Protocols = new List<Protocol>();
+            NamespaceMapping = new Dictionary<string, string>();
+            NamespaceLookup = new Dictionary<string, CodeNamespace>(StringComparer.Ordinal);
         }
 
         /// <summary>
@@ -169,7 +169,7 @@ namespace Avro
         {
             CompileUnit = new CodeCompileUnit();
 
-            processSchemas();
+            ProcessSchemas();
             processProtocols();
 
             return CompileUnit;
@@ -178,8 +178,8 @@ namespace Avro
         /// <summary>
         /// Generates code for the schema objects.
         /// </summary>
-        /// <exception cref="Avro.CodeGenException">Names in schema should only be of type NamedSchema, type found " + sn.Value.Tag.</exception>
-        protected virtual void processSchemas()
+        /// <exception cref="CodeGenException">Names in schema should only be of type NamedSchema, type found " + sn.Value.Tag.</exception>
+        protected virtual void ProcessSchemas()
         {
             foreach (Schema schema in this.Schemas)
             {
@@ -200,6 +200,16 @@ namespace Avro
         }
 
         /// <summary>
+        /// Generates code for the schema objects.
+        /// </summary>
+        /// <exception cref="CodeGenException">Names in schema should only be of type NamedSchema, type found " + sn.Value.Tag.</exception>
+        [Obsolete("This method will be deprecated in a future release. Please change call to ProcessSchemas().")]
+        protected virtual void processSchemas()
+        {
+            ProcessSchemas();
+        }
+
+        /// <summary>
         /// Generates code for the protocol objects.
         /// </summary>
         protected virtual void processProtocols()