You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Bill Farner <wf...@apache.org> on 2015/07/09 21:00:16 UTC
Review Request 36364: Upgrade to checkstyle 6.7.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36364/
-----------------------------------------------------------
Review request for Aurora and Zameer Manji.
Repository: aurora
Description
-------
Upgrade to checkstyle 6.7.
Release notes along the way: http://checkstyle.sourceforge.net/releasenotes.html#Release_6.7
Note that this is not the latest checkstyle version. We cannot upgrade past 6.8 yet due to a compatibility issue with the gradle checkstyle plugin: https://issues.gradle.org/browse/GRADLE-3314
Diffs
-----
build.gradle 78159932388046883494dda97b4a86c06772d26d
Diff: https://reviews.apache.org/r/36364/diff/
Testing
-------
Thanks,
Bill Farner
Re: Review Request 36364: Upgrade to checkstyle 6.7.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36364/#review91167
-----------------------------------------------------------
Ship it!
Master (28f976c) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On July 9, 2015, 7 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36364/
> -----------------------------------------------------------
>
> (Updated July 9, 2015, 7 p.m.)
>
>
> Review request for Aurora and Zameer Manji.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Upgrade to checkstyle 6.7.
> Release notes along the way: http://checkstyle.sourceforge.net/releasenotes.html#Release_6.7
>
> Note that this is not the latest checkstyle version. We cannot upgrade past 6.8 yet due to a compatibility issue with the gradle checkstyle plugin: https://issues.gradle.org/browse/GRADLE-3314
>
>
> Diffs
> -----
>
> build.gradle 78159932388046883494dda97b4a86c06772d26d
>
> Diff: https://reviews.apache.org/r/36364/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 36364: Upgrade to checkstyle 6.7.
Posted by Zameer Manji <zm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36364/#review91157
-----------------------------------------------------------
Ship it!
Ship It!
- Zameer Manji
On July 9, 2015, noon, Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36364/
> -----------------------------------------------------------
>
> (Updated July 9, 2015, noon)
>
>
> Review request for Aurora and Zameer Manji.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> Upgrade to checkstyle 6.7.
> Release notes along the way: http://checkstyle.sourceforge.net/releasenotes.html#Release_6.7
>
> Note that this is not the latest checkstyle version. We cannot upgrade past 6.8 yet due to a compatibility issue with the gradle checkstyle plugin: https://issues.gradle.org/browse/GRADLE-3314
>
>
> Diffs
> -----
>
> build.gradle 78159932388046883494dda97b4a86c06772d26d
>
> Diff: https://reviews.apache.org/r/36364/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Bill Farner
>
>