[jira] [Commented] (CASSANDRA-17199) Provide summary of failed SessionInfo's in StreamResultFuture

["David Capwell (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CASSANDRA-17199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17701411#comment-17701411 ] 

David Capwell commented on CASSANDRA-17199:
-------------------------------------------

The new tests conflict with existing code, so fails to compile

{code}
_build-test:
    [javac] Compiling 1520 source files to /Users/dcapwell/src/github/apache/cassandra-oss-commit/build/test/classes
    [javac] Note: Processing compiler hints annotations
    [javac] Note: Processing compiler hints annotations
    [javac] /Users/dcapwell/src/github/apache/cassandra-oss-commit/test/distributed/org/apache/cassandra/distributed/test/streaming/StreamFailureTest.java:44: error: cannot find symbol
    [javac] import org.apache.cassandra.io.sstable.format.RangeAwareSSTableWriter;
    [javac]                                              ^
    [javac]   symbol:   class RangeAwareSSTableWriter
    [javac]   location: package org.apache.cassandra.io.sstable.format
    [javac] /Users/dcapwell/src/github/apache/cassandra-oss-commit/test/distributed/org/apache/cassandra/distributed/test/streaming/StreamFailureTest.java:45: error: cannot find symbol
    [javac] import org.apache.cassandra.io.sstable.format.big.BigTableZeroCopyWriter;
    [javac]                                                  ^
    [javac]   symbol:   class BigTableZeroCopyWriter
    [javac]   location: package org.apache.cassandra.io.sstable.format.big
    [javac] Note: Processing compiler hints annotations
    [javac] Note: Writing compiler command file at META-INF/hotspot_compiler
    [javac] Note: Done processing compiler hints annotations
    [javac] 2 errors

BUILD FAILED
/Users/dcapwell/src/github/apache/cassandra-oss-commit/build.xml:999: The following error occurred while executing this line:
/Users/dcapwell/src/github/apache/cassandra-oss-commit/build.xml:1012: Compile failed; see the compiler error output for details.
{code}

> Provide summary of failed SessionInfo's in StreamResultFuture
> -------------------------------------------------------------
>
>                 Key: CASSANDRA-17199
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-17199
>             Project: Cassandra
>          Issue Type: Improvement
>          Components: Observability/Logging
>            Reporter: Brendan Cicchi
>            Assignee: Natnael Adere
>            Priority: Normal
>              Labels: AdventCalendar2021, lhf
>             Fix For: 5.x
>
>
> Currently, we warn about the presence of one or more failed sessions existing in the final state and then an operator/user traces back through the logs to find any failed streams for troubleshooting.
> {code:java}
> private synchronized void maybeComplete()
> {
>     if (finishedAllSessions())
>     {
>         StreamState finalState = getCurrentState();
>         if (finalState.hasFailedSession())
>         {
>             logger.warn("[Stream #{}] Stream failed", planId);
>             tryFailure(new StreamException(finalState, "Stream failed"));
>         }
>         else
>         {
>             logger.info("[Stream #{}] All sessions completed", planId);
>             trySuccess(finalState);
>         }
>     }
> } {code}
> It would be helpful to log out a summary of the SessionInfo for each failed session since that should be accessible via the StreamState.
>  
> This can be especially helpful for longer streaming operations like bootstrap where the failure could have been a long time back and all recent streams leading up to the warning actually are successful.
>  



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org