You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Peter Karich (JIRA)" <ji...@apache.org> on 2010/09/16 22:18:33 UTC
[jira] Created: (WICKET-3053) Guice does not work with modules
Guice does not work with modules
--------------------------------
Key: WICKET-3053
URL: https://issues.apache.org/jira/browse/WICKET-3053
Project: Wicket
Issue Type: Bug
Affects Versions: 1.5-M2.1
Reporter: Peter Karich
See this thread:
http://apache-wicket.1842946.n4.nabble.com/Url-parameters-removed-onClick-wrong-url-encoding-td2541831.html
Again you can take a legup project (with Guice 2.0) and substitute the wicket versions -> the test
tester.assertModelValue("text", "sayHello");
will fail: expected:<sayHello> but was:<Hello null>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-3053) Guice does not work with modules
Posted by "Peter Karich (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3053?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Peter Karich updated WICKET-3053:
---------------------------------
Attachment: wicket-bug2-setter-injection.zip
'correct' bug where setter injection fails
> Guice does not work with modules
> --------------------------------
>
> Key: WICKET-3053
> URL: https://issues.apache.org/jira/browse/WICKET-3053
> Project: Wicket
> Issue Type: Bug
> Affects Versions: 1.5-M2.1
> Reporter: Peter Karich
> Assignee: Martin Grigorov
> Attachments: wicket-bug2-setter-injection.zip, wicket-bug2.zip
>
>
> See this thread:
> http://apache-wicket.1842946.n4.nabble.com/Url-parameters-removed-onClick-wrong-url-encoding-td2541831.html
> Again you can take a legup project (with Guice 2.0) and substitute the wicket versions -> the test
> tester.assertModelValue("text", "sayHello");
> will fail: expected:<sayHello> but was:<Hello null>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-3053) Guice does not work with modules
Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3053?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martin Grigorov updated WICKET-3053:
------------------------------------
Attachment: WICKET-3053.patch
A patch for BaseWicketTester that preserves the form components' values when AjaxSubmitLink is clicked.
@Wicket devs: please review.
> Guice does not work with modules
> --------------------------------
>
> Key: WICKET-3053
> URL: https://issues.apache.org/jira/browse/WICKET-3053
> Project: Wicket
> Issue Type: Bug
> Affects Versions: 1.5-M2.1
> Reporter: Peter Karich
> Assignee: Martin Grigorov
> Attachments: WICKET-3053.patch, wicket-bug2-setter-injection.zip, wicket-bug2.zip
>
>
> See this thread:
> http://apache-wicket.1842946.n4.nabble.com/Url-parameters-removed-onClick-wrong-url-encoding-td2541831.html
> Again you can take a legup project (with Guice 2.0) and substitute the wicket versions -> the test
> tester.assertModelValue("text", "sayHello");
> will fail: expected:<sayHello> but was:<Hello null>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (WICKET-3053) WicketTester does not preserve the
form component values when submitting with AjaxSubmitLink
Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3053?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martin Grigorov resolved WICKET-3053.
-------------------------------------
Fix Version/s: 1.5-M3
Resolution: Fixed
Fixed with r999827.
> WicketTester does not preserve the form component values when submitting with AjaxSubmitLink
> --------------------------------------------------------------------------------------------
>
> Key: WICKET-3053
> URL: https://issues.apache.org/jira/browse/WICKET-3053
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.5-M2.1
> Reporter: Peter Karich
> Assignee: Martin Grigorov
> Fix For: 1.5-M3
>
> Attachments: WICKET-3053.patch, wicket-bug2-setter-injection.zip, wicket-bug2.zip
>
>
> See this thread:
> http://apache-wicket.1842946.n4.nabble.com/Url-parameters-removed-onClick-wrong-url-encoding-td2541831.html
> Again you can take a legup project (with Guice 2.0) and substitute the wicket versions -> the test
> tester.assertModelValue("text", "sayHello");
> will fail: expected:<sayHello> but was:<Hello null>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-3053) WicketTester does not preserve the
form component values when submitting with AjaxSubmitLink
Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3053?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martin Grigorov updated WICKET-3053:
------------------------------------
Summary: WicketTester does not preserve the form component values when submitting with AjaxSubmitLink (was: Guice does not work with modules)
Component/s: wicket
> WicketTester does not preserve the form component values when submitting with AjaxSubmitLink
> --------------------------------------------------------------------------------------------
>
> Key: WICKET-3053
> URL: https://issues.apache.org/jira/browse/WICKET-3053
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.5-M2.1
> Reporter: Peter Karich
> Assignee: Martin Grigorov
> Attachments: WICKET-3053.patch, wicket-bug2-setter-injection.zip, wicket-bug2.zip
>
>
> See this thread:
> http://apache-wicket.1842946.n4.nabble.com/Url-parameters-removed-onClick-wrong-url-encoding-td2541831.html
> Again you can take a legup project (with Guice 2.0) and substitute the wicket versions -> the test
> tester.assertModelValue("text", "sayHello");
> will fail: expected:<sayHello> but was:<Hello null>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-3053) Guice does not work with modules
Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12910544#action_12910544 ]
Martin Grigorov commented on WICKET-3053:
-----------------------------------------
Setter injection is not supported in 1.5.
We decided to remove that functionality in 1.5.
Use field injection instead.
> Guice does not work with modules
> --------------------------------
>
> Key: WICKET-3053
> URL: https://issues.apache.org/jira/browse/WICKET-3053
> Project: Wicket
> Issue Type: Bug
> Affects Versions: 1.5-M2.1
> Reporter: Peter Karich
> Assignee: Martin Grigorov
> Attachments: wicket-bug2-setter-injection.zip, wicket-bug2.zip
>
>
> See this thread:
> http://apache-wicket.1842946.n4.nabble.com/Url-parameters-removed-onClick-wrong-url-encoding-td2541831.html
> Again you can take a legup project (with Guice 2.0) and substitute the wicket versions -> the test
> tester.assertModelValue("text", "sayHello");
> will fail: expected:<sayHello> but was:<Hello null>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-3053) WicketTester does not preserve the
form component values when submitting with AjaxSubmitLink
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12913502#action_12913502 ]
Hudson commented on WICKET-3053:
--------------------------------
Integrated in Apache Wicket 1.5.x #350 (See [https://hudson.apache.org/hudson/job/Apache%20Wicket%201.5.x/350/])
WICKET-3053 WicketTester does not preserve the form component values when submitting with AjaxSubmitLink
Serialize the form components' values in the request post parameters when clicking AjaxSubmitLink
> WicketTester does not preserve the form component values when submitting with AjaxSubmitLink
> --------------------------------------------------------------------------------------------
>
> Key: WICKET-3053
> URL: https://issues.apache.org/jira/browse/WICKET-3053
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.5-M2.1
> Reporter: Peter Karich
> Assignee: Martin Grigorov
> Fix For: 1.5-M3
>
> Attachments: WICKET-3053.patch, wicket-bug2-setter-injection.zip, wicket-bug2.zip
>
>
> See this thread:
> http://apache-wicket.1842946.n4.nabble.com/Url-parameters-removed-onClick-wrong-url-encoding-td2541831.html
> Again you can take a legup project (with Guice 2.0) and substitute the wicket versions -> the test
> tester.assertModelValue("text", "sayHello");
> will fail: expected:<sayHello> but was:<Hello null>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-3053) WicketTester does not preserve the
form component values when submitting with AjaxSubmitLink
Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12912387#action_12912387 ]
Martin Grigorov commented on WICKET-3053:
-----------------------------------------
There is no need to support it. Wicket-Spring have never supported this feature and no one ever needed it. The same can be done with field injection, so there is no need to support more code in our codebase.
In 1.5 the code related to that logic is in wicket-ioc and it is shared between wicket-spring and wicket-guice.
> WicketTester does not preserve the form component values when submitting with AjaxSubmitLink
> --------------------------------------------------------------------------------------------
>
> Key: WICKET-3053
> URL: https://issues.apache.org/jira/browse/WICKET-3053
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.5-M2.1
> Reporter: Peter Karich
> Assignee: Martin Grigorov
> Attachments: WICKET-3053.patch, wicket-bug2-setter-injection.zip, wicket-bug2.zip
>
>
> See this thread:
> http://apache-wicket.1842946.n4.nabble.com/Url-parameters-removed-onClick-wrong-url-encoding-td2541831.html
> Again you can take a legup project (with Guice 2.0) and substitute the wicket versions -> the test
> tester.assertModelValue("text", "sayHello");
> will fail: expected:<sayHello> but was:<Hello null>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (WICKET-3053) Guice does not work with modules
Posted by "Peter Karich (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3053?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Peter Karich updated WICKET-3053:
---------------------------------
Attachment: wicket-bug2.zip
attached quickstart. Just replace wicket version with 1.4.9 and you can see that it is passing.
1.5-M2.1 is now failing with:
expected:<Goodbye Bob> but was:<Goodbye null>
strange
> Guice does not work with modules
> --------------------------------
>
> Key: WICKET-3053
> URL: https://issues.apache.org/jira/browse/WICKET-3053
> Project: Wicket
> Issue Type: Bug
> Affects Versions: 1.5-M2.1
> Reporter: Peter Karich
> Attachments: wicket-bug2.zip
>
>
> See this thread:
> http://apache-wicket.1842946.n4.nabble.com/Url-parameters-removed-onClick-wrong-url-encoding-td2541831.html
> Again you can take a legup project (with Guice 2.0) and substitute the wicket versions -> the test
> tester.assertModelValue("text", "sayHello");
> will fail: expected:<sayHello> but was:<Hello null>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (WICKET-3053) Guice does not work with modules
Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3053?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Martin Grigorov reassigned WICKET-3053:
---------------------------------------
Assignee: Martin Grigorov
> Guice does not work with modules
> --------------------------------
>
> Key: WICKET-3053
> URL: https://issues.apache.org/jira/browse/WICKET-3053
> Project: Wicket
> Issue Type: Bug
> Affects Versions: 1.5-M2.1
> Reporter: Peter Karich
> Assignee: Martin Grigorov
> Attachments: wicket-bug2.zip
>
>
> See this thread:
> http://apache-wicket.1842946.n4.nabble.com/Url-parameters-removed-onClick-wrong-url-encoding-td2541831.html
> Again you can take a legup project (with Guice 2.0) and substitute the wicket versions -> the test
> tester.assertModelValue("text", "sayHello");
> will fail: expected:<sayHello> but was:<Hello null>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-3053) Guice does not work with modules
Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12910501#action_12910501 ]
Martin Grigorov commented on WICKET-3053:
-----------------------------------------
It seems it is a problem in WicketTester, not in Guice.
The application itself works OK.
> Guice does not work with modules
> --------------------------------
>
> Key: WICKET-3053
> URL: https://issues.apache.org/jira/browse/WICKET-3053
> Project: Wicket
> Issue Type: Bug
> Affects Versions: 1.5-M2.1
> Reporter: Peter Karich
> Assignee: Martin Grigorov
> Attachments: wicket-bug2.zip
>
>
> See this thread:
> http://apache-wicket.1842946.n4.nabble.com/Url-parameters-removed-onClick-wrong-url-encoding-td2541831.html
> Again you can take a legup project (with Guice 2.0) and substitute the wicket versions -> the test
> tester.assertModelValue("text", "sayHello");
> will fail: expected:<sayHello> but was:<Hello null>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-3053) WicketTester does not preserve the
form component values when submitting with AjaxSubmitLink
Posted by "Peter Karich (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12912371#action_12912371 ]
Peter Karich commented on WICKET-3053:
--------------------------------------
> Setter injection is not supported in 1.5. We decided to remove that functionality in 1.5.
uha, why that? is it really a good idea to support only parts of guice? is it difficult to implement or too much work?
> WicketTester does not preserve the form component values when submitting with AjaxSubmitLink
> --------------------------------------------------------------------------------------------
>
> Key: WICKET-3053
> URL: https://issues.apache.org/jira/browse/WICKET-3053
> Project: Wicket
> Issue Type: Bug
> Components: wicket
> Affects Versions: 1.5-M2.1
> Reporter: Peter Karich
> Assignee: Martin Grigorov
> Attachments: WICKET-3053.patch, wicket-bug2-setter-injection.zip, wicket-bug2.zip
>
>
> See this thread:
> http://apache-wicket.1842946.n4.nabble.com/Url-parameters-removed-onClick-wrong-url-encoding-td2541831.html
> Again you can take a legup project (with Guice 2.0) and substitute the wicket versions -> the test
> tester.assertModelValue("text", "sayHello");
> will fail: expected:<sayHello> but was:<Hello null>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (WICKET-3053) Guice does not work with modules
Posted by "Peter Karich (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/WICKET-3053?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12910517#action_12910517 ]
Peter Karich commented on WICKET-3053:
--------------------------------------
The issue in the provided quick start must be a different issue :-) (ajax form stuff or sth.)
I'll attach the 'correct' bug, which appeared in the real application. There setter for the injection is never called and results in a NullPointerException. (the field injection seem to work)
> Guice does not work with modules
> --------------------------------
>
> Key: WICKET-3053
> URL: https://issues.apache.org/jira/browse/WICKET-3053
> Project: Wicket
> Issue Type: Bug
> Affects Versions: 1.5-M2.1
> Reporter: Peter Karich
> Assignee: Martin Grigorov
> Attachments: wicket-bug2.zip
>
>
> See this thread:
> http://apache-wicket.1842946.n4.nabble.com/Url-parameters-removed-onClick-wrong-url-encoding-td2541831.html
> Again you can take a legup project (with Guice 2.0) and substitute the wicket versions -> the test
> tester.assertModelValue("text", "sayHello");
> will fail: expected:<sayHello> but was:<Hello null>
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.