[GitHub] [incubator-pinot] snleee commented on a change in pull request #4358: Raise the threshold of using MMAP for inverted index creation from 100M to 2G

[GitBox <gi...@apache.org>]

snleee commented on a change in pull request #4358: Raise the threshold of using MMAP for inverted index creation from 100M to 2G
URL: https://github.com/apache/incubator-pinot/pull/4358#discussion_r296967871
 
 

 ##########
 File path: pinot-core/src/main/java/org/apache/pinot/core/segment/creator/impl/inv/OffHeapBitmapInvertedIndexCreator.java
 ##########
 @@ -52,8 +52,8 @@
  * <p>Based on the number of values we need to store, we use direct memory or MMap file to allocate the buffer.
  */
 public final class OffHeapBitmapInvertedIndexCreator implements InvertedIndexCreator {
-  // Use MMapBuffer if the buffer size is larger than 100MB
-  private static final int NUM_VALUES_THRESHOLD_FOR_MMAP_BUFFER = 25_000_000;
+  // Use MMapBuffer if the value buffer size is larger than 2G
 
 Review comment:
   remove `value`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org