[jira] [Comment Edited] (CALCITE-2416) Assertion error when determining monotonicity

["Vladimir Sitnikov (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CALCITE-2416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16565143#comment-16565143 ] 

Vladimir Sitnikov edited comment on CALCITE-2416 at 8/1/18 11:22 AM:
---------------------------------------------------------------------

[~ipatina], the PR looks good to me, however I would rather replace existing {{throw new AssertionError}} with {{throw new IllegalArgumentException}} in {{org.apache.calcite.sql.SqlLiteral#unchain}}.

I don't think {{node instanceof SqlCall}} is required there. A generic {{IllegalArgumentException("not a literal: " + node);}} is enough.


was (Author: vladimirsitnikov):
[~ipatina], the PR looks good to me, however could you please just replace existing {{throw new AssertionError}} with {{throw new IllegalArgumentException}} in {{org.apache.calcite.sql.SqlLiteral#unchain}} ?

I don't think {{node instanceof SqlCall}} is required there. A generic {{IllegalArgumentException("not a literal: " + node);}} is enough.

> Assertion error when determining monotonicity
> ---------------------------------------------
>
>                 Key: CALCITE-2416
>                 URL: https://issues.apache.org/jira/browse/CALCITE-2416
>             Project: Calcite
>          Issue Type: Bug
>          Components: core
>    Affects Versions: 1.15.0, 1.16.0, 1.17.0
>            Reporter: Pressenna
>            Assignee: Julian Hyde
>            Priority: Major
>             Fix For: 1.18.0
>
>
> {code:java}
> CREATE TABLE test ( x integer, y integer);
> SELECT 2 * 2 * x FROM test;{code}
>  
> Causes:
> Exception in thread "main" java.lang.AssertionError: Internal error: invalid literal: 2 * 2
>  
> Re-raising CALCITE-1504 which was fixed via CALCITE-1486



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)