You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2021/09/07 13:48:11 UTC

[GitHub] [iotdb] DittoTool opened a new issue #3927: Several Inefficient Usages of JCF

DittoTool opened a new issue #3927:
URL: https://github.com/apache/iotdb/issues/3927


   Hi,
   
   We find that there are several inefficient usages of Java Collections:
   
   The contains method is invoked upon a list object in a loop. We recommend replacing it with a HashSet.
   Random access can occur at several linkedlist objects, which run in linear time complexity. We recommend replacing them with Arraylist objects.
   There is no iteration occurring upon a LinkedHashMap, thus the insertion order does not matter. We recommend replacing it with a HashMap.
   ArrayList is inserted before an iteration, while multiple memory reallocation might occur when the size of the list exceeds its capacity. We recommend replacing it with a LinkedList.
   We discovered the above inefficient usage of containers by our tool Ditto. The patch is submitted in #3926. Could you please check and accept it? We have tested the patch on our PC. The patched program works well.
   
   Bests
   
   Ditto


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] SteveYurongSu closed issue #3927: Several Inefficient Usages of JCF

Posted by GitBox <gi...@apache.org>.
SteveYurongSu closed issue #3927:
URL: https://github.com/apache/iotdb/issues/3927


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [iotdb] github-actions[bot] commented on issue #3927: Several Inefficient Usages of JCF

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on issue #3927:
URL: https://github.com/apache/iotdb/issues/3927#issuecomment-914322059


   Hi, this is your first issue in IoTDB project. Thanks for your report. Welcome to join the community!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org