You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/03/03 17:54:38 UTC

[GitHub] [spark] huaxingao commented on a change in pull request #27762: [SPARK-31012][ML][PySpark][DOCS] Updating ML docs for 3.0 changes

huaxingao commented on a change in pull request #27762: [SPARK-31012][ML][PySpark][DOCS] Updating ML docs for 3.0 changes
URL: https://github.com/apache/spark/pull/27762#discussion_r387192429
 
 

 ##########
 File path: mllib/src/main/scala/org/apache/spark/ml/evaluation/BinaryClassificationEvaluator.scala
 ##########
 @@ -28,7 +28,8 @@ import org.apache.spark.sql.functions._
 import org.apache.spark.sql.types.DoubleType
 
 /**
- * Evaluator for binary classification, which expects two input columns: rawPrediction and label.
+ * Evaluator for binary classification, which expects input columns rawPrediction, label and
 
 Review comment:
   I guess I will leave this as is if that's OK by you two. The other two classes ```MulticlassClassificationEvaluator``` and ```RegressionEvaluator``` don't quote the column names either. If I change, I will have to change all of them. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org