You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/01/17 10:18:12 UTC
[GitHub] [arrow] Dandandan opened a new pull request #9230: ArrowARROW-11022: [Rust] Upgrade to Tokio 1
Dandandan opened a new pull request #9230:
URL: https://github.com/apache/arrow/pull/9230
Upgrades crates to use latest versions of
* tokio
* tonic
* prost
I ran the tests/benhmark to make sure nothing is broken.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] mqy edited a comment on pull request #9230: ARROW-11022: [Rust] Upgrade to Tokio 1.0
Posted by GitBox <gi...@apache.org>.
mqy edited a comment on pull request #9230:
URL: https://github.com/apache/arrow/pull/9230#issuecomment-762214327
> I believe there are special rules in "semver" for version of the form `0.0.x` and `0.x.x` which are (slightly) different than the versions that start with something other than 0. I find this both somewhat confusing and clever
r
@alamb thanks for the reply.
Firstly, I don't think it is pin version when we just add `^` to an existing version as of the spec: it says plain version without leading `^` is same as that with `^`. But maybe I'm wrong because I did not verify this.
Secondly, perhaps this can answer why rust crate version may be different to "semver standard":
Quoting from https://doc.rust-lang.org/cargo/reference/specifying-dependencies.html#caret-requirements again:
```
This compatibility convention is different from SemVer in the way it treats versions before 1.0.0. While SemVer says there
is no compatibility before 1.0.0, Cargo considers 0.x.y to be compatible with 0.x.z, where y ≥ z and x > 0.
```
Best regards @alamb @Dandandan
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nevi-me commented on pull request #9230: ARROW-11022: [Rust] Upgrade to Tokio 1.0
Posted by GitBox <gi...@apache.org>.
nevi-me commented on pull request #9230:
URL: https://github.com/apache/arrow/pull/9230#issuecomment-766627433
> @houqp -- I think the instructions to run the tests locally are here: https://github.com/apache/arrow/blob/master/docs/source/format/Integration.rst
>
> @carols10cents or @nevi-me may have some pointers as I think they have worked in this area too
I'm also seeing the timeout locally:
@qphou I've not been able to run integration tests successfully with docker, so I use the local script below:
```bash
# prep work
export ARROW_HOME=~/arrow
export ARROW_VERSION=3.0.0-SNAPSHOT
export ARROW_JAVA_INTEGRATION_JAR=$ARROW_HOME/java/tools/target/arrow-tools-$ARROW_VERSION-jar-with-dependencies.jar
export RUST_BACKTRACE=1
# build CPP testing binary
cd ./cpp
# remove the build directory if needed
# rm build -r
mkdir -p build
cd build
# change or remove the -j24, it speeds up the builds for me locally. 24 is the number of CPU cores I have
cmake -DCMAKE_BUILD_TYPE=Debug -DARROW_BUILD_INTEGRATION=ON -DARROW_FLIGHT=ON -DARROW_BUILD_TESTS=ON -j24 ..
make -j24
cd ../../
# build Java testing binary
cd ./java
# clean if necessary
# mvn clean
# I disabled the java build, but added this for completeness. Java Flight tests fail locally for me
# mvn install -DskipTests
cd ../
# build Rust testing binary
cd ./rust && cargo build
cd ../
# run tests
archery integration --with-cpp=1 --with-rust=1 --with-java=0 --run-flight --debug > integration-testing.log
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] alamb commented on pull request #9230: ARROW-11022: [Rust] Upgrade to Tokio 1.0
Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #9230:
URL: https://github.com/apache/arrow/pull/9230#issuecomment-763051049
@maxburke I predict sometime in the next 24 hours. We are working through the Rust PR backlog (though it is fairly large). I also believe this one is important as tokio flows upwards through the Rust ecosystem
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] houqp commented on pull request #9230: ARROW-11022: [Rust] Upgrade to Tokio 1.0
Posted by GitBox <gi...@apache.org>.
houqp commented on pull request #9230:
URL: https://github.com/apache/arrow/pull/9230#issuecomment-767301487
I see what's going on, the rust tester implementation expects test server to output binding port: https://github.com/apache/arrow/blob/master/dev/archery/archery/integration/tester_rust.py#L88-L96.
But this particular logging line was removed in this PR, so the the test runner passed the wrong port to the consumer client.
We need to add back that logging and also make a comment there to let future developer know this is just an informational print ;)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] Dandandan commented on pull request #9230: ARROW-11022: [Rust] Upgrade to Tokio 1.0
Posted by GitBox <gi...@apache.org>.
Dandandan commented on pull request #9230:
URL: https://github.com/apache/arrow/pull/9230#issuecomment-762481688
Maybe whatever we decide, I think based on the amount of discussion we should maybe move it to a separate PR?
To me it makes sense to have either everything without `^` or with `^` if they give the same behavior, which seems to be according to the docs. If so, `^` to me is a bit less "surprising" about the behavior, but consistentency with other crates is also something to consider of course.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] houqp edited a comment on pull request #9230: ARROW-11022: [Rust] Upgrade to Tokio 1.0
Posted by GitBox <gi...@apache.org>.
houqp edited a comment on pull request #9230:
URL: https://github.com/apache/arrow/pull/9230#issuecomment-767301487
I see what's going on, the rust tester implementation expects test server to output binding port: https://github.com/apache/arrow/blob/master/dev/archery/archery/integration/tester_rust.py#L88-L96.
But this particular logging line was removed in this PR, so the the test runner passed the wrong port to the consumer client.
We need to add back that logging and also make a comment there to let future developer know this is just an informational print ;)
In https://github.com/apache/arrow/pull/9241, I used tokio-stream wrapper to workaround this issue. But perhaps there is a better to do get the binding port from sonic without creating our own TCP listener manually.
The archery rust tester should probably be updated to wait for subprocess output with a reasonable timeout as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] mqy commented on pull request #9230: ARROW-11022: [Rust] Upgrade to Tokio 1.0
Posted by GitBox <gi...@apache.org>.
mqy commented on pull request #9230:
URL: https://github.com/apache/arrow/pull/9230#issuecomment-761773476
Since rust crate version numbers without leading '^' sometimes leads to confusions, how about prepend the versions changed in this PR with '^' to make it more clear?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #9230: ArrowARROW-11022: [Rust] Upgrade to Tokio 1
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #9230:
URL: https://github.com/apache/arrow/pull/9230#issuecomment-761766348
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
Thanks for opening a pull request!
Could you open an issue for this pull request on JIRA?
https://issues.apache.org/jira/browse/ARROW
Then could you also rename pull request title in the following format?
ARROW-${JIRA_ID}: [${COMPONENT}] ${SUMMARY}
See also:
* [Other pull requests](https://github.com/apache/arrow/pulls/)
* [Contribution Guidelines - How to contribute patches](https://arrow.apache.org/docs/developers/contributing.html#how-to-contribute-patches)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] mqy edited a comment on pull request #9230: ARROW-11022: [Rust] Upgrade to Tokio 1.0
Posted by GitBox <gi...@apache.org>.
mqy edited a comment on pull request #9230:
URL: https://github.com/apache/arrow/pull/9230#issuecomment-762214327
> I believe there are special rules in "semver" for version of the form `0.0.x` and `0.x.x` which are (slightly) different than the versions that start with something other than 0. I find this both somewhat confusing and clever
r
@alamb thanks for the reply.
Firstly, I don't think it is pin version when we just add `^` to an existing version as of the spec: it says plain version without leading `^` is same as that with `^`. But maybe I'm wrong because I did not verify this.
Secondly, perhaps this can answer why rust crate version may be different to "semver standard":
Quoting from https://doc.rust-lang.org/cargo/reference/specifying-dependencies.html#caret-requirements again:
```
This compatibility convention is different from SemVer in the way it treats versions before 1.0.0. While SemVer says there
is no compatibility before 1.0.0, Cargo considers 0.x.y to be compatible with 0.x.z, where y ≥ z and x > 0.
```
Best regards @alamb @Dandandan
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nevi-me closed pull request #9230: ARROW-11022: [Rust] Upgrade to Tokio 1.0
Posted by GitBox <gi...@apache.org>.
nevi-me closed pull request #9230:
URL: https://github.com/apache/arrow/pull/9230
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] Dandandan commented on pull request #9230: ARROW-11022: [Rust] Upgrade to Tokio 1.0
Posted by GitBox <gi...@apache.org>.
Dandandan commented on pull request #9230:
URL: https://github.com/apache/arrow/pull/9230#issuecomment-761792921
I agree for clarity it makes sense to start using `^` everywhere instead of omitting it, as it does the same according to the docs/
Do you agree @alamb ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] houqp removed a comment on pull request #9230: ARROW-11022: [Rust] Upgrade to Tokio 1.0
Posted by GitBox <gi...@apache.org>.
houqp removed a comment on pull request #9230:
URL: https://github.com/apache/arrow/pull/9230#issuecomment-767294362
Following the steps shared by nevi, i was able to narrow down the reproducible case to simply running `cargo run --bin flight-test-integration-server -- --port=0` from within `integration-testing` crate folder.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nevi-me edited a comment on pull request #9230: ARROW-11022: [Rust] Upgrade to Tokio 1.0
Posted by GitBox <gi...@apache.org>.
nevi-me edited a comment on pull request #9230:
URL: https://github.com/apache/arrow/pull/9230#issuecomment-766627433
> @houqp -- I think the instructions to run the tests locally are here: https://github.com/apache/arrow/blob/master/docs/source/format/Integration.rst
>
> @carols10cents or @nevi-me may have some pointers as I think they have worked in this area too
I'm also seeing the timeout locally:
@houqp I've not been able to run integration tests successfully with docker, so I use the local script below:
```bash
# prep work
export ARROW_HOME=~/arrow
export ARROW_VERSION=3.0.0-SNAPSHOT
export ARROW_JAVA_INTEGRATION_JAR=$ARROW_HOME/java/tools/target/arrow-tools-$ARROW_VERSION-jar-with-dependencies.jar
export RUST_BACKTRACE=1
# build CPP testing binary
cd ./cpp
# remove the build directory if needed
# rm build -r
mkdir -p build
cd build
# change or remove the -j24, it speeds up the builds for me locally. 24 is the number of CPU cores I have
cmake -DCMAKE_BUILD_TYPE=Debug -DARROW_BUILD_INTEGRATION=ON -DARROW_FLIGHT=ON -DARROW_BUILD_TESTS=ON -j24 ..
make -j24
cd ../../
# build Java testing binary
cd ./java
# clean if necessary
# mvn clean
# I disabled the java build, but added this for completeness. Java Flight tests fail locally for me
# mvn install -DskipTests
cd ../
# build Rust testing binary
cd ./rust && cargo build
cd ../
# run tests
archery integration --with-cpp=1 --with-rust=1 --with-java=0 --run-flight --debug > integration-testing.log
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] mqy commented on pull request #9230: ARROW-11022: [Rust] Upgrade to Tokio 1.0
Posted by GitBox <gi...@apache.org>.
mqy commented on pull request #9230:
URL: https://github.com/apache/arrow/pull/9230#issuecomment-761787061
@alam I got a bit confused about this, let me paste from https://doc.rust-lang.org/cargo/reference/specifying-dependencies.html#caret-requirements
`The string "0.1.12" is a semver version requirement. Since this string does not have any operators in it, it is interpreted the same way as if we had specified "^0.1.12", which is called a caret requirement.`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] Dandandan commented on pull request #9230: ARROW-11022: [Rust] Upgrade to Tokio 1.0
Posted by GitBox <gi...@apache.org>.
Dandandan commented on pull request #9230:
URL: https://github.com/apache/arrow/pull/9230#issuecomment-767346005
Thanks @houqp that's very subtle...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] Dandandan commented on pull request #9230: ARROW-11022: [Rust] Upgrade to Tokio 1.0
Posted by GitBox <gi...@apache.org>.
Dandandan commented on pull request #9230:
URL: https://github.com/apache/arrow/pull/9230#issuecomment-768577032
Thanks @houqp ! That did the trick. I removed the earlier code because of the slightly changed API, but I removed too much.
Looks like integration test is now succeeding @alamb
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] alamb commented on pull request #9230: ARROW-11022: [Rust] Upgrade to Tokio 1.0
Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #9230:
URL: https://github.com/apache/arrow/pull/9230#issuecomment-765906871
@houqp -- I think the instructions to run the tests locally are here: https://github.com/apache/arrow/blob/master/docs/source/format/Integration.rst
@carols10cents or @nevi-me may have some pointers as I think they have worked in this area too
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] mqy commented on pull request #9230: ARROW-11022: [Rust] Upgrade to Tokio 1.0
Posted by GitBox <gi...@apache.org>.
mqy commented on pull request #9230:
URL: https://github.com/apache/arrow/pull/9230#issuecomment-762214327
> I believe there are special rules in "semver" for version of the form `0.0.x` and `0.x.x` which are (slightly) different than the versions that start with something other than 0. I find this both somewhat confusing and clever
r
@almb thanks for the reply.
Firstly, I don't think it is pin version when we just add `^` to an existing version as of the spec: it says plain version without leading `^` is same as that with `^`. But maybe I'm wrong because I did not verify this.
Secondly, perhaps this can answer why rust crate version may be different to semver":
Quoting from https://doc.rust-lang.org/cargo/reference/specifying-dependencies.html#caret-requirements again:
```
This compatibility convention is different from SemVer in the way it treats versions before 1.0.0. While SemVer says there
is no compatibility before 1.0.0, Cargo considers 0.x.y to be compatible with 0.x.z, where y ≥ z and x > 0.
```
Best regards @alamb @Dandandan
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nevi-me commented on pull request #9230: ARROW-11022: [Rust] Upgrade to Tokio 1.0
Posted by GitBox <gi...@apache.org>.
nevi-me commented on pull request #9230:
URL: https://github.com/apache/arrow/pull/9230#issuecomment-767179521
I've started looking at this today/yday. The Rust flight binaries seem to be passed the same arguments as before, I've stopped where the server starts. I'll continue later tonight.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] Dandandan commented on pull request #9230: ARROW-11022: [Rust] Upgrade to Tokio 1.0
Posted by GitBox <gi...@apache.org>.
Dandandan commented on pull request #9230:
URL: https://github.com/apache/arrow/pull/9230#issuecomment-767372894
Something else also seems going on (related to binding the port), but I don't have time anymore today. Feel free to comment here or open a new PR resolving the issue @nevi-me @houqp .
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] houqp commented on pull request #9230: ARROW-11022: [Rust] Upgrade to Tokio 1.0
Posted by GitBox <gi...@apache.org>.
houqp commented on pull request #9230:
URL: https://github.com/apache/arrow/pull/9230#issuecomment-765663967
Is there an easy way to reproduce this integration test failure locally?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] houqp edited a comment on pull request #9230: ARROW-11022: [Rust] Upgrade to Tokio 1.0
Posted by GitBox <gi...@apache.org>.
houqp edited a comment on pull request #9230:
URL: https://github.com/apache/arrow/pull/9230#issuecomment-767301487
I see what's going on, the rust tester implementation expects test server to output binding port: https://github.com/apache/arrow/blob/master/dev/archery/archery/integration/tester_rust.py#L88-L96.
But this particular logging line was removed in this PR, so the the test runner passed the wrong port to the consumer client.
We need to add back that logging and also make a comment there to let future developer know this is just an informational print ;)
In https://github.com/apache/arrow/pull/9241, I used tokio-stream wrapper to workaround this issue. But perhaps there is a better to do get the binding port from sonic without creating our own TCP listener manually.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] alam commented on pull request #9230: ARROW-11022: [Rust] Upgrade to Tokio 1.0
Posted by GitBox <gi...@apache.org>.
alam commented on pull request #9230:
URL: https://github.com/apache/arrow/pull/9230#issuecomment-761788579
> @alam I got a bit confused about this, let me paste from https://doc.rust-lang.org/cargo/reference/specifying-dependencies.html#caret-requirements
>
> `The string "0.1.12" is a semver version requirement. Since this string does not have any operators in it, it is interpreted the same way as if we had specified "^0.1.12", which is called a caret requirement.`
Tagged the wrong person @mqy :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] alamb commented on pull request #9230: ARROW-11022: [Rust] Upgrade to Tokio 1.0
Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #9230:
URL: https://github.com/apache/arrow/pull/9230#issuecomment-768600253
I think this is looking good -- what do you think @nevi-me @andygrove and @jorgecarleitao ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] codecov-io edited a comment on pull request #9230: ARROW-11022: [Rust] Upgrade to Tokio 1.0
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9230:
URL: https://github.com/apache/arrow/pull/9230#issuecomment-761772650
# [Codecov](https://codecov.io/gh/apache/arrow/pull/9230?src=pr&el=h1) Report
> Merging [#9230](https://codecov.io/gh/apache/arrow/pull/9230?src=pr&el=desc) (8d3a6d0) into [master](https://codecov.io/gh/apache/arrow/commit/1393188e1aa1b3d59993ce7d4ade7f7ac8570959?el=desc) (1393188) will **increase** coverage by `0.01%`.
> The diff coverage is `40.00%`.
[](https://codecov.io/gh/apache/arrow/pull/9230?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9230 +/- ##
==========================================
+ Coverage 81.61% 81.62% +0.01%
==========================================
Files 215 215
Lines 51867 51855 -12
==========================================
Hits 42329 42329
+ Misses 9538 9526 -12
```
| [Impacted Files](https://codecov.io/gh/apache/arrow/pull/9230?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...integration-testing/src/flight\_server\_scenarios.rs](https://codecov.io/gh/apache/arrow/pull/9230/diff?src=pr&el=tree#diff-cnVzdC9pbnRlZ3JhdGlvbi10ZXN0aW5nL3NyYy9mbGlnaHRfc2VydmVyX3NjZW5hcmlvcy5ycw==) | `0.00% <ø> (ø)` | |
| [...ng/src/flight\_server\_scenarios/auth\_basic\_proto.rs](https://codecov.io/gh/apache/arrow/pull/9230/diff?src=pr&el=tree#diff-cnVzdC9pbnRlZ3JhdGlvbi10ZXN0aW5nL3NyYy9mbGlnaHRfc2VydmVyX3NjZW5hcmlvcy9hdXRoX2Jhc2ljX3Byb3RvLnJz) | `0.00% <0.00%> (ø)` | |
| [...ng/src/flight\_server\_scenarios/integration\_test.rs](https://codecov.io/gh/apache/arrow/pull/9230/diff?src=pr&el=tree#diff-cnVzdC9pbnRlZ3JhdGlvbi10ZXN0aW5nL3NyYy9mbGlnaHRfc2VydmVyX3NjZW5hcmlvcy9pbnRlZ3JhdGlvbl90ZXN0LnJz) | `0.00% <0.00%> (ø)` | |
| [...-testing/src/flight\_server\_scenarios/middleware.rs](https://codecov.io/gh/apache/arrow/pull/9230/diff?src=pr&el=tree#diff-cnVzdC9pbnRlZ3JhdGlvbi10ZXN0aW5nL3NyYy9mbGlnaHRfc2VydmVyX3NjZW5hcmlvcy9taWRkbGV3YXJlLnJz) | `0.00% <0.00%> (ø)` | |
| [...t/datafusion/src/physical\_plan/coalesce\_batches.rs](https://codecov.io/gh/apache/arrow/pull/9230/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9waHlzaWNhbF9wbGFuL2NvYWxlc2NlX2JhdGNoZXMucnM=) | `84.11% <100.00%> (ø)` | |
| [rust/datafusion/src/physical\_plan/repartition.rs](https://codecov.io/gh/apache/arrow/pull/9230/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9waHlzaWNhbF9wbGFuL3JlcGFydGl0aW9uLnJz) | `74.24% <100.00%> (ø)` | |
| [rust/parquet/src/encodings/encoding.rs](https://codecov.io/gh/apache/arrow/pull/9230/diff?src=pr&el=tree#diff-cnVzdC9wYXJxdWV0L3NyYy9lbmNvZGluZ3MvZW5jb2RpbmcucnM=) | `94.86% <0.00%> (-0.20%)` | :arrow_down: |
| [rust/arrow/src/array/transform/fixed\_binary.rs](https://codecov.io/gh/apache/arrow/pull/9230/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvYXJyYXkvdHJhbnNmb3JtL2ZpeGVkX2JpbmFyeS5ycw==) | `84.21% <0.00%> (+5.26%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow/pull/9230?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/arrow/pull/9230?src=pr&el=footer). Last update [66d6223...abe0b23](https://codecov.io/gh/apache/arrow/pull/9230?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] houqp commented on pull request #9230: ARROW-11022: [Rust] Upgrade to Tokio 1.0
Posted by GitBox <gi...@apache.org>.
houqp commented on pull request #9230:
URL: https://github.com/apache/arrow/pull/9230#issuecomment-762597983
+1 on moving this discussion into a follow up discussion since it's not strictly related to the tokio upgrade. Pining dependencies with `^` is a common practice in other languages like python and JS, but it doesn't seem like the case for Rust. I would prefer us sticking with whatever convention Rust community adopts to avoid edge-cases in the future.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] houqp commented on pull request #9230: ARROW-11022: [Rust] Upgrade to Tokio 1.0
Posted by GitBox <gi...@apache.org>.
houqp commented on pull request #9230:
URL: https://github.com/apache/arrow/pull/9230#issuecomment-767732713
```
let addr: SocketAddr = format!("0.0.0.0:{}", port).parse()?;
println!("Server listening on localhost:{}", addr.port());
```
Perhaps `let addr: SocketAddr ` is not actually binding to a port and `addr.port()` is returning `0`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] alamb commented on pull request #9230: ARROW-11022: [Rust] Upgrade to Tokio 1.0
Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #9230:
URL: https://github.com/apache/arrow/pull/9230#issuecomment-762851642
Maybe the `^` discussion is a good one for the mailing list
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] houqp edited a comment on pull request #9230: ARROW-11022: [Rust] Upgrade to Tokio 1.0
Posted by GitBox <gi...@apache.org>.
houqp edited a comment on pull request #9230:
URL: https://github.com/apache/arrow/pull/9230#issuecomment-767732713
```
let addr: SocketAddr = format!("0.0.0.0:{}", port).parse()?;
println!("Server listening on localhost:{}", addr.port());
```
Perhaps `let addr: SocketAddr ` is not actually binding to a socket and `addr.port()` is returning `0`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] mqy commented on pull request #9230: ARROW-11022: [Rust] Upgrade to Tokio 1.0
Posted by GitBox <gi...@apache.org>.
mqy commented on pull request #9230:
URL: https://github.com/apache/arrow/pull/9230#issuecomment-761791400
> Tagged the wrong person @mqy :)
Hello @alam and @alamb xD
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] mqy commented on pull request #9230: ARROW-11022: [Rust] Upgrade to Tokio 1.0
Posted by GitBox <gi...@apache.org>.
mqy commented on pull request #9230:
URL: https://github.com/apache/arrow/pull/9230#issuecomment-761800005
> I agree for clarity it makes sense to start using `^` everywhere instead of omitting it, as it does the same according to the
```
^1.2.3 := >=1.2.3, <2.0.0
^1.2 := >=1.2.0, <2.0.0
```
If we expect the minor version to be upgraded with `cargo update`, it's better not set the patch version at all, so this is the default versioning requirement in arrow/rust: **^x.y**. If a dependency version is set with only major (e.g. "^1") or additional patch version (e.g. "^1.2.3"), that should catch our eyes: is this the expected one? Perhaps some comments are required for these unusual versions as of the default "^x.y" form.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] Dandandan commented on pull request #9230: ARROW-11022: [Rust] Upgrade to Tokio 1.0
Posted by GitBox <gi...@apache.org>.
Dandandan commented on pull request #9230:
URL: https://github.com/apache/arrow/pull/9230#issuecomment-763003644
@maxburke I expect very soon as the master branch is open for changes again, and we and users will have some time to stabilize on tokio 1.0
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nevi-me commented on pull request #9230: ARROW-11022: [Rust] Upgrade to Tokio 1.0
Posted by GitBox <gi...@apache.org>.
nevi-me commented on pull request #9230:
URL: https://github.com/apache/arrow/pull/9230#issuecomment-766627433
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] alamb commented on pull request #9230: ARROW-11022: [Rust] Upgrade to Tokio 1.0
Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #9230:
URL: https://github.com/apache/arrow/pull/9230#issuecomment-762187306
@mqy and @Dandandan -- I believe there are special rules in "semver" for version of the form `0.0.x` and `0.x.x` which are (slightly) different than the versions that start with something other than 0. I find this both somewhat confusing and clever
https://github.com/steveklabnik/semver#requirements
I don't consider myself a Rust version expert, so I could be wrong, but I took a quick look at several other widely used library crates and none of them seem to pin versions using the caret `^` in their Cargo.toml files
https://github.com/tokio-rs/async-stream/blob/master/async-stream/Cargo.toml
https://github.com/tokio-rs/tokio/blob/master/tokio/Cargo.toml
https://github.com/rust-lang/cargo/blob/master/Cargo.toml
https://github.com/rust-random/rand/blob/master/Cargo.toml
https://github.com/dtolnay/quote/blob/master/Cargo.toml
My opinion is that we should pin and versions using `^` if we have a specific problem we are trying to solve, but not change the default to use `^` otherwise. But that is just my opinion
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] houqp edited a comment on pull request #9230: ARROW-11022: [Rust] Upgrade to Tokio 1.0
Posted by GitBox <gi...@apache.org>.
houqp edited a comment on pull request #9230:
URL: https://github.com/apache/arrow/pull/9230#issuecomment-767301487
I see what's going on, the rust tester implementation expects test server to output binding port: https://github.com/apache/arrow/blob/master/dev/archery/archery/integration/tester_rust.py#L88-L96.
But this particular logging line was removed in this PR, so the the test runner passed the wrong port to the consumer client.
We need to add back that logging and also make a comment there to let future developer know this is not just an informational print ;)
In https://github.com/apache/arrow/pull/9241, I used tokio-stream wrapper to workaround this issue. But perhaps there is a better to do get the binding port from sonic without creating our own TCP listener manually.
The archery rust tester should probably be updated to wait for subprocess output with a reasonable timeout as well.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] alamb commented on pull request #9230: ARROW-11022: [Rust] Upgrade to Tokio 1.0
Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #9230:
URL: https://github.com/apache/arrow/pull/9230#issuecomment-761777508
> Since rust crate version numbers without leading '^' sometimes leads to confusions, how about prepend the versions changed in this PR with '^' to make it more clear?
@mqy -- I think it is common in rust projects (especially library crates like Arrow) to allow some flexibility in their dependencies and thus not prefix with `^`.
Cargo claims to implement [semve](https://semver.org/) -- which I think means in theory crate publishers should take care and ensure that "non major version upgrades" (aka 1.2.1 --> 1.2.2, or 1.2.1 --> 1.3.0) don't contain breaking changes. If you use the `^` prefix we would prevent crates / projects that depend of Arrow from using anything other than the exact version specified.
As you saw, the parquet-format crate didn't follow the semver versioning convention thus breaking our CI :(
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] maxburke commented on pull request #9230: ARROW-11022: [Rust] Upgrade to Tokio 1.0
Posted by GitBox <gi...@apache.org>.
maxburke commented on pull request #9230:
URL: https://github.com/apache/arrow/pull/9230#issuecomment-762996964
Is there an ETA for when this will land?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] alamb commented on pull request #9230: ARROW-11022: [Rust] Upgrade to Tokio 1.0
Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #9230:
URL: https://github.com/apache/arrow/pull/9230#issuecomment-763559666
Looks to me like the integration test failure on https://github.com/apache/arrow/pull/9230/checks?check_run_id=1716562930 is due to changes in this PR. Namely it seems like there is a timeout when using a rust server -- I took a quick peek into the Cargo.lock file and I can't find any obvious issue with multiple versions of tokio
```
##########################################################
Flight: Java serving, Rust requesting
##########################################################
==========================================================
Testing file null_trivial
==========================================================
==========================================================
Testing file decimal
==========================================================
-- Skipping test because consumer Rust does not support
==========================================================
Testing file decimal256
==========================================================
-- Skipping test because consumer Rust does not support
==========================================================
Testing file primitive_large_offsets
==========================================================
==========================================================
Testing file interval
==========================================================
-- Skipping test because consumer Rust does not support
==========================================================
Testing file map
==========================================================
-- Skipping test because consumer Rust does not support
==========================================================
Testing file map_non_canonical
==========================================================
-- Skipping test because producer Java does not support
==========================================================
Testing file null
==========================================================
==========================================================
Testing file primitive_no_batches
==========================================================
==========================================================
Testing file nested_large_offsets
==========================================================
-- Skipping test because consumer Rust does not support
==========================================================
Testing file union
==========================================================
-- Skipping test because producer Java does not support
==========================================================
Testing file primitive_zerolength
==========================================================
==========================================================
Testing file primitive
==========================================================
==========================================================
Testing file custom_metadata
==========================================================
==========================================================
Testing file dictionary_unsigned
==========================================================
-- Skipping test because producer Java does not support
==========================================================
Testing file nested_dictionary
==========================================================
-- Skipping test because producer Java does not support
==========================================================
Testing file extension
==========================================================
-- Skipping test because consumer Rust does not support
==========================================================
Testing file recursive_nested
==========================================================
==========================================================
Testing file middleware
==========================================================
-- Skipping test because consumer Rust does not support
==========================================================
Testing file nested
==========================================================
==========================================================
Testing file datetime
==========================================================
==========================================================
Testing file duplicate_fieldnames
==========================================================
==========================================================
Testing file dictionary
==========================================================
==========================================================
Testing file auth:basic_proto
==========================================================
Error: The operation was canceled.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] houqp commented on pull request #9230: ARROW-11022: [Rust] Upgrade to Tokio 1.0
Posted by GitBox <gi...@apache.org>.
houqp commented on pull request #9230:
URL: https://github.com/apache/arrow/pull/9230#issuecomment-767294362
Following the steps shared by nevi, i was able to narrow down the reproducible case to simply running `cargo run --bin flight-test-integration-server -- --port=0` from within `integration-testing` crate folder.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] houqp edited a comment on pull request #9230: ARROW-11022: [Rust] Upgrade to Tokio 1.0
Posted by GitBox <gi...@apache.org>.
houqp edited a comment on pull request #9230:
URL: https://github.com/apache/arrow/pull/9230#issuecomment-767732713
```
let addr: SocketAddr = format!("0.0.0.0:{}", port).parse()?;
println!("Server listening on localhost:{}", addr.port());
```
Perhaps `let addr: SocketAddr ` is not actually binding to a socket and `addr.port()` is returning `0`?
EDIT:
I was able to confirm that it only does the parsing, `addr.port()` returns 0 instead. We need to bind to an actual socket.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #9230: ARROW-11022: [Rust] Upgrade to Tokio 1
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #9230:
URL: https://github.com/apache/arrow/pull/9230#issuecomment-761766612
https://issues.apache.org/jira/browse/ARROW-11022
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] codecov-io commented on pull request #9230: ARROW-11022: [Rust] Upgrade to Tokio 1.0
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #9230:
URL: https://github.com/apache/arrow/pull/9230#issuecomment-761772650
# [Codecov](https://codecov.io/gh/apache/arrow/pull/9230?src=pr&el=h1) Report
> Merging [#9230](https://codecov.io/gh/apache/arrow/pull/9230?src=pr&el=desc) (b60cef6) into [master](https://codecov.io/gh/apache/arrow/commit/1393188e1aa1b3d59993ce7d4ade7f7ac8570959?el=desc) (1393188) will **increase** coverage by `0.01%`.
> The diff coverage is `36.36%`.
[](https://codecov.io/gh/apache/arrow/pull/9230?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9230 +/- ##
==========================================
+ Coverage 81.61% 81.62% +0.01%
==========================================
Files 215 215
Lines 51867 51856 -11
==========================================
+ Hits 42329 42330 +1
+ Misses 9538 9526 -12
```
| [Impacted Files](https://codecov.io/gh/apache/arrow/pull/9230?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [rust/arrow-flight/src/arrow.flight.protocol.rs](https://codecov.io/gh/apache/arrow/pull/9230/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy1mbGlnaHQvc3JjL2Fycm93LmZsaWdodC5wcm90b2NvbC5ycw==) | `0.00% <0.00%> (ø)` | |
| [...integration-testing/src/flight\_server\_scenarios.rs](https://codecov.io/gh/apache/arrow/pull/9230/diff?src=pr&el=tree#diff-cnVzdC9pbnRlZ3JhdGlvbi10ZXN0aW5nL3NyYy9mbGlnaHRfc2VydmVyX3NjZW5hcmlvcy5ycw==) | `0.00% <ø> (ø)` | |
| [...ng/src/flight\_server\_scenarios/auth\_basic\_proto.rs](https://codecov.io/gh/apache/arrow/pull/9230/diff?src=pr&el=tree#diff-cnVzdC9pbnRlZ3JhdGlvbi10ZXN0aW5nL3NyYy9mbGlnaHRfc2VydmVyX3NjZW5hcmlvcy9hdXRoX2Jhc2ljX3Byb3RvLnJz) | `0.00% <0.00%> (ø)` | |
| [...ng/src/flight\_server\_scenarios/integration\_test.rs](https://codecov.io/gh/apache/arrow/pull/9230/diff?src=pr&el=tree#diff-cnVzdC9pbnRlZ3JhdGlvbi10ZXN0aW5nL3NyYy9mbGlnaHRfc2VydmVyX3NjZW5hcmlvcy9pbnRlZ3JhdGlvbl90ZXN0LnJz) | `0.00% <0.00%> (ø)` | |
| [...-testing/src/flight\_server\_scenarios/middleware.rs](https://codecov.io/gh/apache/arrow/pull/9230/diff?src=pr&el=tree#diff-cnVzdC9pbnRlZ3JhdGlvbi10ZXN0aW5nL3NyYy9mbGlnaHRfc2VydmVyX3NjZW5hcmlvcy9taWRkbGV3YXJlLnJz) | `0.00% <0.00%> (ø)` | |
| [...t/datafusion/src/physical\_plan/coalesce\_batches.rs](https://codecov.io/gh/apache/arrow/pull/9230/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9waHlzaWNhbF9wbGFuL2NvYWxlc2NlX2JhdGNoZXMucnM=) | `84.11% <100.00%> (ø)` | |
| [rust/datafusion/src/physical\_plan/repartition.rs](https://codecov.io/gh/apache/arrow/pull/9230/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9waHlzaWNhbF9wbGFuL3JlcGFydGl0aW9uLnJz) | `74.24% <100.00%> (ø)` | |
| [rust/arrow/src/array/transform/fixed\_binary.rs](https://codecov.io/gh/apache/arrow/pull/9230/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy9zcmMvYXJyYXkvdHJhbnNmb3JtL2ZpeGVkX2JpbmFyeS5ycw==) | `84.21% <0.00%> (+5.26%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow/pull/9230?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/arrow/pull/9230?src=pr&el=footer). Last update [66d6223...abe0b23](https://codecov.io/gh/apache/arrow/pull/9230?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] mqy edited a comment on pull request #9230: ARROW-11022: [Rust] Upgrade to Tokio 1.0
Posted by GitBox <gi...@apache.org>.
mqy edited a comment on pull request #9230:
URL: https://github.com/apache/arrow/pull/9230#issuecomment-762214327
> I believe there are special rules in "semver" for version of the form `0.0.x` and `0.x.x` which are (slightly) different than the versions that start with something other than 0. I find this both somewhat confusing and clever
r
@almb thanks for the reply.
Firstly, I don't think it is pin version when we just add `^` to an existing version as of the spec: it says plain version without leading `^` is same as that with `^`. But maybe I'm wrong because I did not verify this.
Secondly, perhaps this can answer why rust crate version may be different to "semver standard":
Quoting from https://doc.rust-lang.org/cargo/reference/specifying-dependencies.html#caret-requirements again:
```
This compatibility convention is different from SemVer in the way it treats versions before 1.0.0. While SemVer says there
is no compatibility before 1.0.0, Cargo considers 0.x.y to be compatible with 0.x.z, where y ≥ z and x > 0.
```
Best regards @alamb @Dandandan
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nevi-me edited a comment on pull request #9230: ARROW-11022: [Rust] Upgrade to Tokio 1.0
Posted by GitBox <gi...@apache.org>.
nevi-me edited a comment on pull request #9230:
URL: https://github.com/apache/arrow/pull/9230#issuecomment-766627433
> @houqp -- I think the instructions to run the tests locally are here: https://github.com/apache/arrow/blob/master/docs/source/format/Integration.rst
>
> @carols10cents or @nevi-me may have some pointers as I think they have worked in this area too
I'm also seeing the timeout locally:
@houqp I've not been able to run integration tests successfully with docker, so I use the local script below:
```bash
# prep work
export ARROW_HOME=~/arrow
export ARROW_VERSION=3.0.0-SNAPSHOT
export ARROW_JAVA_INTEGRATION_JAR=$ARROW_HOME/java/tools/target/arrow-tools-$ARROW_VERSION-jar-with-dependencies.jar
export RUST_BACKTRACE=1
# build CPP testing binary
cd ./cpp
# remove the build directory if needed
# rm build -r
mkdir -p build
cd build
# change or remove the -j24, it speeds up the builds for me locally. 24 is the number of CPU cores I have
cmake -DCMAKE_BUILD_TYPE=Debug -DARROW_BUILD_INTEGRATION=ON -DARROW_FLIGHT=ON -DARROW_BUILD_TESTS=ON -j24 ..
make -j24
cd ../../
# build Java testing binary
cd ./java
# clean if necessary
# mvn clean
# I disabled the java build, but added this for completeness. Java Flight tests fail locally for me
# mvn install -DskipTests
cd ../
# build Rust testing binary
cd ./rust && cargo build
cd ../
# run tests
archery integration --with-cpp=1 --with-rust=1 --with-java=0 --run-flight --debug > integration-testing.log
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org