You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by Shwetha GS <ss...@hortonworks.com> on 2015/04/28 13:16:12 UTC
Review Request 33624: OOZIE-1993 Rerun fails during join in certain
condition
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33624/
-----------------------------------------------------------
Review request for oozie.
Bugs: OOZIE-1993
https://issues.apache.org/jira/browse/OOZIE-1993
Repository: oozie-git
Description
-------
The issue was with picking up new execution path during re-runs. This will also address the issue in OOZIE-1879.
Changes:
1. SignalXCommand to pick up the new execution path
2. Removed actionEndTimes comparison
3. Aligned else ifs in LiteWorkflowInstance.signal(). No logic changes
Diffs
-----
core/src/main/conf/oozie-log4j.properties 2b20ff2
core/src/main/java/org/apache/oozie/WorkflowActionBean.java 6289158
core/src/main/java/org/apache/oozie/command/wf/ReRunXCommand.java 6138278
core/src/main/java/org/apache/oozie/command/wf/SignalXCommand.java bccac51
core/src/main/java/org/apache/oozie/executor/jpa/WorkflowActionQueryExecutor.java 0e99ae2
core/src/main/java/org/apache/oozie/service/LiteWorkflowStoreService.java d661d08
core/src/main/java/org/apache/oozie/workflow/WorkflowLib.java ba5b6b1
core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowInstance.java 919c95a
core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowLib.java 706cc2a
Diff: https://reviews.apache.org/r/33624/diff/
Testing
-------
end to end test for the example workflow in the jira - with failures at different nodes
Thanks,
Shwetha GS
Re: Review Request 33624: OOZIE-1993 Rerun fails during join in
certain condition
Posted by Robert Kanter <rk...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33624/#review82445
-----------------------------------------------------------
Ship it!
LGTM
- Robert Kanter
On April 30, 2015, 7:14 a.m., Shwetha GS wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33624/
> -----------------------------------------------------------
>
> (Updated April 30, 2015, 7:14 a.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-1993
> https://issues.apache.org/jira/browse/OOZIE-1993
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> The issue was with picking up new execution path during re-runs. This will also address the issue in OOZIE-1879.
> Changes:
> 1. SignalXCommand to pick up the new execution path
> 2. Removed actionEndTimes comparison
> 3. Aligned else ifs in LiteWorkflowInstance.signal(). No logic changes
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/oozie/WorkflowActionBean.java 6289158
> core/src/main/java/org/apache/oozie/command/wf/ReRunXCommand.java 6138278
> core/src/main/java/org/apache/oozie/command/wf/SignalXCommand.java bccac51
> core/src/main/java/org/apache/oozie/executor/jpa/WorkflowActionQueryExecutor.java 0e99ae2
> core/src/main/java/org/apache/oozie/service/LiteWorkflowStoreService.java d661d08
> core/src/main/java/org/apache/oozie/workflow/WorkflowLib.java ba5b6b1
> core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowInstance.java 919c95a
> core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowLib.java 706cc2a
>
> Diff: https://reviews.apache.org/r/33624/diff/
>
>
> Testing
> -------
>
> end to end test for the example workflow in the jira - with failures at different nodes
>
>
> Thanks,
>
> Shwetha GS
>
>
Re: Review Request 33624: OOZIE-1993 Rerun fails during join in
certain condition
Posted by Robert Kanter <rk...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33624/#review84387
-----------------------------------------------------------
Ship it!
Ship It!
- Robert Kanter
On May 18, 2015, 8:59 a.m., Shwetha GS wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33624/
> -----------------------------------------------------------
>
> (Updated May 18, 2015, 8:59 a.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-1993
> https://issues.apache.org/jira/browse/OOZIE-1993
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> The issue was with picking up new execution path during re-runs. This will also address the issue in OOZIE-1879.
> Changes:
> 1. SignalXCommand to pick up the new execution path
> 2. Removed actionEndTimes comparison
> 3. Aligned else ifs in LiteWorkflowInstance.signal(). No logic changes
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/oozie/WorkflowActionBean.java 6289158
> core/src/main/java/org/apache/oozie/command/wf/ReRunXCommand.java 6138278
> core/src/main/java/org/apache/oozie/command/wf/SignalXCommand.java bccac51
> core/src/main/java/org/apache/oozie/executor/jpa/WorkflowActionQueryExecutor.java 0e99ae2
> core/src/main/java/org/apache/oozie/service/LiteWorkflowStoreService.java d661d08
> core/src/main/java/org/apache/oozie/workflow/WorkflowLib.java ba5b6b1
> core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowInstance.java 919c95a
> core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowLib.java 706cc2a
> core/src/main/resources/oozie-log4j.properties 4b532ca
> core/src/test/java/org/apache/oozie/command/wf/TestReRunXCommand.java ce32e51
> core/src/test/resources/rerun-wf-fork.xml 8fa8f34
>
> Diff: https://reviews.apache.org/r/33624/diff/
>
>
> Testing
> -------
>
> end to end test for the example workflow in the jira - with failures at different nodes
>
>
> Thanks,
>
> Shwetha GS
>
>
Re: Review Request 33624: OOZIE-1993 Rerun fails during join in
certain condition
Posted by Shwetha GS <ss...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33624/
-----------------------------------------------------------
(Updated May 18, 2015, 8:59 a.m.)
Review request for oozie.
Changes
-------
Added test
Bugs: OOZIE-1993
https://issues.apache.org/jira/browse/OOZIE-1993
Repository: oozie-git
Description
-------
The issue was with picking up new execution path during re-runs. This will also address the issue in OOZIE-1879.
Changes:
1. SignalXCommand to pick up the new execution path
2. Removed actionEndTimes comparison
3. Aligned else ifs in LiteWorkflowInstance.signal(). No logic changes
Diffs (updated)
-----
core/src/main/java/org/apache/oozie/WorkflowActionBean.java 6289158
core/src/main/java/org/apache/oozie/command/wf/ReRunXCommand.java 6138278
core/src/main/java/org/apache/oozie/command/wf/SignalXCommand.java bccac51
core/src/main/java/org/apache/oozie/executor/jpa/WorkflowActionQueryExecutor.java 0e99ae2
core/src/main/java/org/apache/oozie/service/LiteWorkflowStoreService.java d661d08
core/src/main/java/org/apache/oozie/workflow/WorkflowLib.java ba5b6b1
core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowInstance.java 919c95a
core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowLib.java 706cc2a
core/src/main/resources/oozie-log4j.properties 4b532ca
core/src/test/java/org/apache/oozie/command/wf/TestReRunXCommand.java ce32e51
core/src/test/resources/rerun-wf-fork.xml 8fa8f34
Diff: https://reviews.apache.org/r/33624/diff/
Testing
-------
end to end test for the example workflow in the jira - with failures at different nodes
Thanks,
Shwetha GS
Re: Review Request 33624: OOZIE-1993 Rerun fails during join in
certain condition
Posted by Shwetha GS <ss...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33624/
-----------------------------------------------------------
(Updated April 30, 2015, 7:14 a.m.)
Review request for oozie.
Changes
-------
Removed log4j file changes
Bugs: OOZIE-1993
https://issues.apache.org/jira/browse/OOZIE-1993
Repository: oozie-git
Description
-------
The issue was with picking up new execution path during re-runs. This will also address the issue in OOZIE-1879.
Changes:
1. SignalXCommand to pick up the new execution path
2. Removed actionEndTimes comparison
3. Aligned else ifs in LiteWorkflowInstance.signal(). No logic changes
Diffs (updated)
-----
core/src/main/java/org/apache/oozie/WorkflowActionBean.java 6289158
core/src/main/java/org/apache/oozie/command/wf/ReRunXCommand.java 6138278
core/src/main/java/org/apache/oozie/command/wf/SignalXCommand.java bccac51
core/src/main/java/org/apache/oozie/executor/jpa/WorkflowActionQueryExecutor.java 0e99ae2
core/src/main/java/org/apache/oozie/service/LiteWorkflowStoreService.java d661d08
core/src/main/java/org/apache/oozie/workflow/WorkflowLib.java ba5b6b1
core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowInstance.java 919c95a
core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowLib.java 706cc2a
Diff: https://reviews.apache.org/r/33624/diff/
Testing
-------
end to end test for the example workflow in the jira - with failures at different nodes
Thanks,
Shwetha GS
Re: Review Request 33624: OOZIE-1993 Rerun fails during join in
certain condition
Posted by Robert Kanter <rk...@cloudera.com>.
> On April 28, 2015, 9:13 p.m., Robert Kanter wrote:
> > core/src/main/conf/oozie-log4j.properties, line 40
> > <https://reviews.apache.org/r/33624/diff/1/?file=943971#file943971line40>
> >
> > Why are we changing the log4j config here?
>
> Shwetha GS wrote:
> Not required for this patch. I had plans of doing this in another jira which I never did. Added this during testing, so came in the patch. If you have concerns about adding in this patch, I can revert
Ya, let's do this as it's own patch. I know it's a minor change, but logging changes can sometimes have a big impact on external tools, so it would be good to separate that from this important bug fix.
- Robert
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33624/#review81883
-----------------------------------------------------------
On April 28, 2015, 11:16 a.m., Shwetha GS wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33624/
> -----------------------------------------------------------
>
> (Updated April 28, 2015, 11:16 a.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-1993
> https://issues.apache.org/jira/browse/OOZIE-1993
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> The issue was with picking up new execution path during re-runs. This will also address the issue in OOZIE-1879.
> Changes:
> 1. SignalXCommand to pick up the new execution path
> 2. Removed actionEndTimes comparison
> 3. Aligned else ifs in LiteWorkflowInstance.signal(). No logic changes
>
>
> Diffs
> -----
>
> core/src/main/conf/oozie-log4j.properties 2b20ff2
> core/src/main/java/org/apache/oozie/WorkflowActionBean.java 6289158
> core/src/main/java/org/apache/oozie/command/wf/ReRunXCommand.java 6138278
> core/src/main/java/org/apache/oozie/command/wf/SignalXCommand.java bccac51
> core/src/main/java/org/apache/oozie/executor/jpa/WorkflowActionQueryExecutor.java 0e99ae2
> core/src/main/java/org/apache/oozie/service/LiteWorkflowStoreService.java d661d08
> core/src/main/java/org/apache/oozie/workflow/WorkflowLib.java ba5b6b1
> core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowInstance.java 919c95a
> core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowLib.java 706cc2a
>
> Diff: https://reviews.apache.org/r/33624/diff/
>
>
> Testing
> -------
>
> end to end test for the example workflow in the jira - with failures at different nodes
>
>
> Thanks,
>
> Shwetha GS
>
>
Re: Review Request 33624: OOZIE-1993 Rerun fails during join in
certain condition
Posted by Shwetha GS <ss...@hortonworks.com>.
> On April 28, 2015, 9:13 p.m., Robert Kanter wrote:
> >
Does the main code change look good?
> On April 28, 2015, 9:13 p.m., Robert Kanter wrote:
> > core/src/main/conf/oozie-log4j.properties, line 40
> > <https://reviews.apache.org/r/33624/diff/1/?file=943971#file943971line40>
> >
> > Why are we changing the log4j config here?
Not required for this patch. I had plans of doing this in another jira which I never did. Added this during testing, so came in the patch. If you have concerns about adding in this patch, I can revert
- Shwetha
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33624/#review81883
-----------------------------------------------------------
On April 28, 2015, 11:16 a.m., Shwetha GS wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33624/
> -----------------------------------------------------------
>
> (Updated April 28, 2015, 11:16 a.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-1993
> https://issues.apache.org/jira/browse/OOZIE-1993
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> The issue was with picking up new execution path during re-runs. This will also address the issue in OOZIE-1879.
> Changes:
> 1. SignalXCommand to pick up the new execution path
> 2. Removed actionEndTimes comparison
> 3. Aligned else ifs in LiteWorkflowInstance.signal(). No logic changes
>
>
> Diffs
> -----
>
> core/src/main/conf/oozie-log4j.properties 2b20ff2
> core/src/main/java/org/apache/oozie/WorkflowActionBean.java 6289158
> core/src/main/java/org/apache/oozie/command/wf/ReRunXCommand.java 6138278
> core/src/main/java/org/apache/oozie/command/wf/SignalXCommand.java bccac51
> core/src/main/java/org/apache/oozie/executor/jpa/WorkflowActionQueryExecutor.java 0e99ae2
> core/src/main/java/org/apache/oozie/service/LiteWorkflowStoreService.java d661d08
> core/src/main/java/org/apache/oozie/workflow/WorkflowLib.java ba5b6b1
> core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowInstance.java 919c95a
> core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowLib.java 706cc2a
>
> Diff: https://reviews.apache.org/r/33624/diff/
>
>
> Testing
> -------
>
> end to end test for the example workflow in the jira - with failures at different nodes
>
>
> Thanks,
>
> Shwetha GS
>
>
Re: Review Request 33624: OOZIE-1993 Rerun fails during join in
certain condition
Posted by Robert Kanter <rk...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33624/#review81883
-----------------------------------------------------------
core/src/main/conf/oozie-log4j.properties
<https://reviews.apache.org/r/33624/#comment132396>
Why are we changing the log4j config here?
- Robert Kanter
On April 28, 2015, 11:16 a.m., Shwetha GS wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33624/
> -----------------------------------------------------------
>
> (Updated April 28, 2015, 11:16 a.m.)
>
>
> Review request for oozie.
>
>
> Bugs: OOZIE-1993
> https://issues.apache.org/jira/browse/OOZIE-1993
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> The issue was with picking up new execution path during re-runs. This will also address the issue in OOZIE-1879.
> Changes:
> 1. SignalXCommand to pick up the new execution path
> 2. Removed actionEndTimes comparison
> 3. Aligned else ifs in LiteWorkflowInstance.signal(). No logic changes
>
>
> Diffs
> -----
>
> core/src/main/conf/oozie-log4j.properties 2b20ff2
> core/src/main/java/org/apache/oozie/WorkflowActionBean.java 6289158
> core/src/main/java/org/apache/oozie/command/wf/ReRunXCommand.java 6138278
> core/src/main/java/org/apache/oozie/command/wf/SignalXCommand.java bccac51
> core/src/main/java/org/apache/oozie/executor/jpa/WorkflowActionQueryExecutor.java 0e99ae2
> core/src/main/java/org/apache/oozie/service/LiteWorkflowStoreService.java d661d08
> core/src/main/java/org/apache/oozie/workflow/WorkflowLib.java ba5b6b1
> core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowInstance.java 919c95a
> core/src/main/java/org/apache/oozie/workflow/lite/LiteWorkflowLib.java 706cc2a
>
> Diff: https://reviews.apache.org/r/33624/diff/
>
>
> Testing
> -------
>
> end to end test for the example workflow in the jira - with failures at different nodes
>
>
> Thanks,
>
> Shwetha GS
>
>