[GitHub] [airflow] bugraoz93 commented on a diff in pull request #29099: Trigger Class migration to internal API

["bugraoz93 (via GitHub)" <gi...@apache.org>]

bugraoz93 commented on code in PR #29099:
URL: https://github.com/apache/airflow/pull/29099#discussion_r1111123325


##########
airflow/models/trigger.py:
##########
@@ -71,27 +72,30 @@ def __init__(self, classpath: str, kwargs: dict[str, Any], created_date: datetim
         self.kwargs = kwargs
         self.created_date = created_date or timezone.utcnow()
 
-    @classmethod
-    def from_object(cls, trigger: BaseTrigger):
+    @staticmethod

Review Comment:
   That's a good nit. I must have missed it. Thanks for that! 
   I reverted back to @classmethod. No need to take the risk :)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org