You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "kwin (via GitHub)" <gi...@apache.org> on 2026/02/16 11:13:10 UTC
[I] Xhtml5BaseSink may emit invalid attributes for Sink.inline() when passing multiple attributes [maven-doxia]
kwin opened a new issue, #1034:
URL: https://github.com/apache/maven-doxia/issues/1034
### Affected version
2.0.0
### Bug description
With the following Sink method call
```
SinkEventAttributeSet attributes = new SinkEventAttributeSet();
// set different attributes (semantic, style and decoration)
attributes.addAttributes(SinkEventAttributeSet.LINETHROUGH);
attributes.addAttributes(SinkEventAttributeSet.BOLD);
attributes.addAttributes(Semantics.SUPERSCRIPT);
sink.inline(attributes);
sink.text("text");
sink.inline_();
```
the `Xhtml5BaseSink` emits invalid HTML5:
```
<sup decoration="line-through" style="bold">text</sup>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Xhtml5BaseSink may emit invalid attributes for Sink.inline() when passing multiple attributes [maven-doxia]
Posted by "kwin (via GitHub)" <gi...@apache.org>.
kwin closed issue #1034: Xhtml5BaseSink may emit invalid attributes for Sink.inline() when passing multiple attributes
URL: https://github.com/apache/maven-doxia/issues/1034
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] Xhtml5BaseSink may emit invalid attributes for Sink.inline() when passing multiple attributes [maven-doxia]
Posted by "kwin (via GitHub)" <gi...@apache.org>.
kwin commented on issue #1034:
URL: https://github.com/apache/maven-doxia/issues/1034#issuecomment-3907890483
The culprit is https://github.com/apache/maven-doxia/blob/e5c77a114f745d6ee420ae42c64d2bed736c5e71/doxia-core/src/main/java/org/apache/maven/doxia/sink/impl/Xhtml5BaseSink.java#L1252 which just emits all non Semantic attributes as is. IMHO the non semantic ones from https://github.com/apache/maven-doxia/blob/e5c77a114f745d6ee420ae42c64d2bed736c5e71/doxia-core/src/main/java/org/apache/maven/doxia/sink/impl/SinkEventAttributeSet.java#L92-L106 should be converted to support semantic attributes first.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org