You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2025/05/22 20:09:22 UTC
[kudu-CR] [common] clean-up on types.{h,cc}
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/22940
Change subject: [common] clean-up on types.{h,cc}
......................................................................
[common] clean-up on types.{h,cc}
Anticipating changes in src/kudu/common/types.{h,cc} in the scope of
array data type project, this patch updates the code to be more style
guide-compliant. I also added 'constexpr' specifier to some of
the methods and fields, allowing for more compile-time optimisation.
This patch doesn't contain any functional modifications.
Change-Id: I68524a2a9cb5540e0c600a629dd29d1f46bd19dc
---
M src/kudu/common/types.cc
M src/kudu/common/types.h
2 files changed, 194 insertions(+), 179 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/40/22940/1
--
To view, visit http://gerrit.cloudera.org:8080/22940
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I68524a2a9cb5540e0c600a629dd29d1f46bd19dc
Gerrit-Change-Number: 22940
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
[kudu-CR] [common] clean-up on types.{h,cc}
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22940 )
Change subject: [common] clean-up on types.{h,cc}
......................................................................
Patch Set 2:
Build Started http://jenkins.kudu.apache.org/job/pre_commit/1392/
--
To view, visit http://gerrit.cloudera.org:8080/22940
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I68524a2a9cb5540e0c600a629dd29d1f46bd19dc
Gerrit-Change-Number: 22940
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 22 May 2025 20:25:56 +0000
Gerrit-HasComments: No
[kudu-CR] [common] clean-up on types.{h,cc}
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22940 )
Change subject: [common] clean-up on types.{h,cc}
......................................................................
Patch Set 1:
Build Started http://jenkins.kudu.apache.org/job/pre_commit/1391/
--
To view, visit http://gerrit.cloudera.org:8080/22940
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I68524a2a9cb5540e0c600a629dd29d1f46bd19dc
Gerrit-Change-Number: 22940
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 22 May 2025 20:09:31 +0000
Gerrit-HasComments: No
[kudu-CR] [common] clean-up on types.{h,cc}
Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/22940 )
Change subject: [common] clean-up on types.{h,cc}
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/22940
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I68524a2a9cb5540e0c600a629dd29d1f46bd19dc
Gerrit-Change-Number: 22940
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 28 May 2025 17:18:44 +0000
Gerrit-HasComments: No
[kudu-CR] [common] clean-up on types.{h,cc}
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22940 )
Change subject: [common] clean-up on types.{h,cc}
......................................................................
Patch Set 2:
Build Aborted
http://jenkins.kudu.apache.org/job/pre_commit/1392/ : ABORTED
--
To view, visit http://gerrit.cloudera.org:8080/22940
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I68524a2a9cb5540e0c600a629dd29d1f46bd19dc
Gerrit-Change-Number: 22940
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 22 May 2025 20:30:30 +0000
Gerrit-HasComments: No
[kudu-CR] [common] clean-up on types.{h,cc}
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/22940 )
Change subject: [common] clean-up on types.{h,cc}
......................................................................
Patch Set 3: Verified+1
unrelated test failures:
* DEBUG: mini-cluster crashed on exit in one of python tests due to KUDU-3635
* RELEASE: known flaky Java test org.apache.kudu.spark.kudu.DefaultSourceTest
--
To view, visit http://gerrit.cloudera.org:8080/22940
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I68524a2a9cb5540e0c600a629dd29d1f46bd19dc
Gerrit-Change-Number: 22940
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 22 May 2025 22:56:01 +0000
Gerrit-HasComments: No
[kudu-CR] [common] clean-up on types.{h,cc}
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.
Change subject: [common] clean-up on types.{h,cc}
......................................................................
Removed Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/22940
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I68524a2a9cb5540e0c600a629dd29d1f46bd19dc
Gerrit-Change-Number: 22940
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [common] clean-up on types.{h,cc}
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/22940 )
Change subject: [common] clean-up on types.{h,cc}
......................................................................
[common] clean-up on types.{h,cc}
Anticipating changes in src/kudu/common/types.{h,cc} in the scope of
array data type project, this patch updates the code to be more style
guide-compliant. I also added 'constexpr' specifier to some of
the methods and fields, allowing for more compile-time optimisation.
This patch doesn't contain any functional modifications.
Change-Id: I68524a2a9cb5540e0c600a629dd29d1f46bd19dc
Reviewed-on: http://gerrit.cloudera.org:8080/22940
Tested-by: Alexey Serbin <al...@apache.org>
Reviewed-by: Abhishek Chennaka <ac...@cloudera.com>
---
M src/kudu/common/types.cc
M src/kudu/common/types.h
2 files changed, 199 insertions(+), 188 deletions(-)
Approvals:
Alexey Serbin: Verified
Abhishek Chennaka: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/22940
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I68524a2a9cb5540e0c600a629dd29d1f46bd19dc
Gerrit-Change-Number: 22940
Gerrit-PatchSet: 4
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [common] clean-up on types.{h,cc}
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22940 )
Change subject: [common] clean-up on types.{h,cc}
......................................................................
Patch Set 3:
Build Started http://jenkins.kudu.apache.org/job/pre_commit/1393/
--
To view, visit http://gerrit.cloudera.org:8080/22940
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I68524a2a9cb5540e0c600a629dd29d1f46bd19dc
Gerrit-Change-Number: 22940
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 22 May 2025 20:30:36 +0000
Gerrit-HasComments: No
[kudu-CR] [common] clean-up on types.{h,cc}
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22940 )
Change subject: [common] clean-up on types.{h,cc}
......................................................................
Patch Set 3: Verified-1
Build Failed
http://jenkins.kudu.apache.org/job/pre_commit/1393/ : FAILURE
--
To view, visit http://gerrit.cloudera.org:8080/22940
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I68524a2a9cb5540e0c600a629dd29d1f46bd19dc
Gerrit-Change-Number: 22940
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 22 May 2025 21:20:52 +0000
Gerrit-HasComments: No
[kudu-CR] [common] clean-up on types.{h,cc}
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Abhishek Chennaka,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/22940
to look at the new patch set (#2).
Change subject: [common] clean-up on types.{h,cc}
......................................................................
[common] clean-up on types.{h,cc}
Anticipating changes in src/kudu/common/types.{h,cc} in the scope of
array data type project, this patch updates the code to be more style
guide-compliant. I also added 'constexpr' specifier to some of
the methods and fields, allowing for more compile-time optimisation.
This patch doesn't contain any functional modifications.
Change-Id: I68524a2a9cb5540e0c600a629dd29d1f46bd19dc
---
M src/kudu/common/types.cc
M src/kudu/common/types.h
2 files changed, 196 insertions(+), 185 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/40/22940/2
--
To view, visit http://gerrit.cloudera.org:8080/22940
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I68524a2a9cb5540e0c600a629dd29d1f46bd19dc
Gerrit-Change-Number: 22940
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] [common] clean-up on types.{h,cc}
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/22940 )
Change subject: [common] clean-up on types.{h,cc}
......................................................................
Patch Set 1:
Build Aborted
http://jenkins.kudu.apache.org/job/pre_commit/1391/ : ABORTED
--
To view, visit http://gerrit.cloudera.org:8080/22940
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I68524a2a9cb5540e0c600a629dd29d1f46bd19dc
Gerrit-Change-Number: 22940
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 22 May 2025 20:25:51 +0000
Gerrit-HasComments: No
[kudu-CR] [common] clean-up on types.{h,cc}
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Abhishek Chennaka,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/22940
to look at the new patch set (#3).
Change subject: [common] clean-up on types.{h,cc}
......................................................................
[common] clean-up on types.{h,cc}
Anticipating changes in src/kudu/common/types.{h,cc} in the scope of
array data type project, this patch updates the code to be more style
guide-compliant. I also added 'constexpr' specifier to some of
the methods and fields, allowing for more compile-time optimisation.
This patch doesn't contain any functional modifications.
Change-Id: I68524a2a9cb5540e0c600a629dd29d1f46bd19dc
---
M src/kudu/common/types.cc
M src/kudu/common/types.h
2 files changed, 199 insertions(+), 188 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/40/22940/3
--
To view, visit http://gerrit.cloudera.org:8080/22940
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I68524a2a9cb5540e0c600a629dd29d1f46bd19dc
Gerrit-Change-Number: 22940
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)