You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/10/11 08:50:10 UTC

[GitHub] [arrow] nevi-me opened a new pull request #8433: ARROW-10271: [Rust] Update dependencies

nevi-me opened a new pull request #8433:
URL: https://github.com/apache/arrow/pull/8433


   Tested by running tests, benchmarks and examples.
   Did this with `simd` on and off
   
   The main one here is `packed_simd` > `packed_simd_2`,
   as the former is broken on recent nightlies


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] nevi-me commented on pull request #8433: ARROW-10271: [Rust] Update dependencies

Posted by GitBox <gi...@apache.org>.
nevi-me commented on pull request #8433:
URL: https://github.com/apache/arrow/pull/8433#issuecomment-706733807


   Thanks Andy, it'll affect anyone who uses 2.0 with SIMD and a recent nightly. I don't yet know when pckdsmd broke, so it could be any nightly in the last month maybe.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] andygrove closed pull request #8433: ARROW-10271: [Rust] Update dependencies

Posted by GitBox <gi...@apache.org>.
andygrove closed pull request #8433:
URL: https://github.com/apache/arrow/pull/8433


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] github-actions[bot] commented on pull request #8433: ARROW-10271: [Rust] Update dependencies

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8433:
URL: https://github.com/apache/arrow/pull/8433#issuecomment-706673926


   https://issues.apache.org/jira/browse/ARROW-10271


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] andygrove commented on pull request #8433: ARROW-10271: [Rust] Update dependencies

Posted by GitBox <gi...@apache.org>.
andygrove commented on pull request #8433:
URL: https://github.com/apache/arrow/pull/8433#issuecomment-706741350


   Got it. If there is a 2.0.1 release then we could consider applying this patch there.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] nevi-me commented on pull request #8433: ARROW-10271: [Rust] Update dependencies

Posted by GitBox <gi...@apache.org>.
nevi-me commented on pull request #8433:
URL: https://github.com/apache/arrow/pull/8433#issuecomment-706672564


   I've marked this as a blocker for 2.0. I also tested with `nightly-2020-10-10`, and tests ran fine.
   
   @andygrove, out of curiousity, is there any reason why datafusion doesn't enable simd by default? Looks like there's no easy way of enabling it, so users could be losing out on the benefits on compute.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [arrow] andygrove commented on pull request #8433: ARROW-10271: [Rust] Update dependencies

Posted by GitBox <gi...@apache.org>.
andygrove commented on pull request #8433:
URL: https://github.com/apache/arrow/pull/8433#issuecomment-706731344


   @nevi-me @jorgecarleitao I think we're too late to get this into 2.0.0 since the release candidate has already been cut and the voting process has started. I just ran the tests on the release candidate and it looks fine. If I'm understanding correctly, the issue resolved here is only relevant if we move away from the current nightly Rust? 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org