You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/10/26 04:27:00 UTC

[jira] [Commented] (HADOOP-15876) Use keySet().removeAll() to remove multiple keys from Map in AzureBlobFileSystemStore

    [ https://issues.apache.org/jira/browse/HADOOP-15876?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16664640#comment-16664640 ] 

ASF GitHub Bot commented on HADOOP-15876:
-----------------------------------------

GitHub user dedunumax opened a pull request:

    https://github.com/apache/hadoop/pull/434

    HADOOP-15876: Refactoring AzureBlobFileSystemStore.java

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dedunumax/hadoop HADOOP-15876

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/hadoop/pull/434.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #434
    
----
commit 498e981ec9ce4ab292f3b0118b7af46ab279d749
Author: Dedunu Dhananjaya <de...@...>
Date:   2018-10-26T04:25:57Z

    HADOOP-15876: Refactoring AzureBlobFileSystemStore.java

----


> Use keySet().removeAll() to remove multiple keys from Map in AzureBlobFileSystemStore
> -------------------------------------------------------------------------------------
>
>                 Key: HADOOP-15876
>                 URL: https://issues.apache.org/jira/browse/HADOOP-15876
>             Project: Hadoop Common
>          Issue Type: Sub-task
>            Reporter: Ted Yu
>            Priority: Minor
>
> Looking at hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/AzureBlobFileSystemStore.java , {{removeDefaultAcl}} in particular:
> {code}
>     for (Map.Entry<String, String> defaultAclEntry : defaultAclEntries.entrySet()) {
>       aclEntries.remove(defaultAclEntry.getKey());
>     }
> {code}
> The above operation can be written this way:
> {code}
>     aclEntries.keySet().removeAll(defaultAclEntries.keySet());
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org