Re: [PR] [KYUUBI #6686] Ignore Spark pod container state if pod is terminated [kyuubi]

["pan3793 (via GitHub)" <gi...@apache.org>]

pan3793 commented on code in PR #6690:
URL: https://github.com/apache/kyuubi/pull/6690#discussion_r1756151959


##########
kyuubi-server/src/main/scala/org/apache/kyuubi/engine/KubernetesApplicationOperation.scala:
##########
@@ -445,20 +445,32 @@ object KubernetesApplicationOperation extends Logging {
           .find(cs => appStateContainer.equalsIgnoreCase(cs.getName))
       case KubernetesApplicationStateSource.POD => None
     }
-    val applicationState = containerStatusToBuildAppState
+
+    val podAppState = podStateToApplicationState(pod.getStatus.getPhase)
+    val containerAppState = containerStatusToBuildAppState

Review Comment:
   changes look good to me, can we leave some comments here with an example you listed in the PR description? also, please update the conf docs of `kyuubi.kubernetes.application.state.source`, to match the updated check logic 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org