You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ode.apache.org by "Alexey Ousov (JIRA)" <ji...@apache.org> on 2008/01/16 07:49:34 UTC
[jira] Created: (ODE-229) SimpleSheduler should close ResultSet
SimpleSheduler should close ResultSet
-------------------------------------
Key: ODE-229
URL: https://issues.apache.org/jira/browse/ODE-229
Project: ODE
Issue Type: Bug
Affects Versions: 1.1, 1.1.1, 1.2
Environment: Windows XP Pro, JDK 1.5.0.07, Oracle 10g XE, Apache Tomcat 5.5.25
Reporter: Alexey Ousov
Priority: Minor
ResultSet is not closed in function "List<String> org.apache.ode.scheduler.simple.JdbcDelegateFixed.getNodeIds()". It should be implicitly closed to avoid Database connection pool leaks.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ODE-229) SimpleSheduler should close ResultSet
Posted by "Matthieu Riou (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ODE-229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12559567#action_12559567 ]
Matthieu Riou commented on ODE-229:
-----------------------------------
Did you see any connection leak?
Normally the result set is closed with the connection anyway and as we're running a transaction the connection from the pool is physically closed only at transaction commit. So I doubt we have a leak here (and the simple scheduler has been tested substantially).
> SimpleSheduler should close ResultSet
> -------------------------------------
>
> Key: ODE-229
> URL: https://issues.apache.org/jira/browse/ODE-229
> Project: ODE
> Issue Type: Bug
> Affects Versions: 1.1, 1.1.1, 1.2
> Environment: Windows XP Pro, JDK 1.5.0.07, Oracle 10g XE, Apache Tomcat 5.5.25
> Reporter: Alexey Ousov
> Priority: Minor
>
> ResultSet is not closed in function "List<String> org.apache.ode.scheduler.simple.JdbcDelegateFixed.getNodeIds()". It should be implicitly closed to avoid Database connection pool leaks.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (ODE-229) SimpleSheduler should close ResultSet
Posted by "Matthieu Riou (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ODE-229?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Matthieu Riou resolved ODE-229.
-------------------------------
Resolution: Invalid
Fix Version/s: 1.2
Assignee: Matthieu Riou
Yes, I can empathize, making everything work properly is a challenge for each database even though it's supposed to be "transparent" :) That specific thing shouldn't be a problem though but if you have specific difficulties feel free to ask for help on user@ode.apache.org.
And btw once you get it to work on Oracle, a little 'How To' would be much welcome!
> SimpleSheduler should close ResultSet
> -------------------------------------
>
> Key: ODE-229
> URL: https://issues.apache.org/jira/browse/ODE-229
> Project: ODE
> Issue Type: Bug
> Affects Versions: 1.1, 1.1.1, 1.2
> Environment: Windows XP Pro, JDK 1.5.0.07, Oracle 10g XE, Apache Tomcat 5.5.25
> Reporter: Alexey Ousov
> Assignee: Matthieu Riou
> Priority: Minor
> Fix For: 1.2
>
>
> ResultSet is not closed in function "List<String> org.apache.ode.scheduler.simple.JdbcDelegateFixed.getNodeIds()". It should be implicitly closed to avoid Database connection pool leaks.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ODE-229) SimpleSheduler should close ResultSet
Posted by "Alexey Ousov (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ODE-229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12559827#action_12559827 ]
Alexey Ousov commented on ODE-229:
----------------------------------
I'm not a database expert :) I just tried to achieve stable work of ODE with Oracle, and it is very-very tricky. I found an article which says that result sets of pooled connections must be explicitly closed, and I thought it is rule.
> SimpleSheduler should close ResultSet
> -------------------------------------
>
> Key: ODE-229
> URL: https://issues.apache.org/jira/browse/ODE-229
> Project: ODE
> Issue Type: Bug
> Affects Versions: 1.1, 1.1.1, 1.2
> Environment: Windows XP Pro, JDK 1.5.0.07, Oracle 10g XE, Apache Tomcat 5.5.25
> Reporter: Alexey Ousov
> Priority: Minor
>
> ResultSet is not closed in function "List<String> org.apache.ode.scheduler.simple.JdbcDelegateFixed.getNodeIds()". It should be implicitly closed to avoid Database connection pool leaks.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.