You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@falcon.apache.org by Ruslan Ostafiychuk <ro...@hortonworks.com> on 2014/10/03 13:12:04 UTC

Re: Review Request 26110: Add ACL validation and enforcement tests

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26110/#review55331
-----------------------------------------------------------



falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/Entities/ClusterMerlin.java
<https://reviews.apache.org/r/26110/#comment95696>

    Three setACL() methods looks similar. I think ACL creation with three parameters can be extracted to *Util.setACL(Entity, String, String, String)



falcon-regression/merlin/src/test/java/org/apache/falcon/regression/security/EntityOp.java
<https://reviews.apache.org/r/26110/#comment95697>

    Exceptions are not logged.


- Ruslan Ostafiychuk


On Sept. 30, 2014, 6 p.m., Raghav Gautam wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26110/
> -----------------------------------------------------------
> 
> (Updated Sept. 30, 2014, 6 p.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: falcon-746
>     https://issues.apache.org/jira/browse/falcon-746
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> Add ACL validation and enforcement tests.
> 
> 
> Diffs
> -----
> 
>   falcon-regression/README.md 659657c 
>   falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/Entities/ClusterMerlin.java 33b67f7 
>   falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/Entities/FeedMerlin.java 025fc15 
>   falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/Entities/ProcessMerlin.java a10dfc1 
>   falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/bundle/Bundle.java eac3cb4 
>   falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/enumsAndConstants/MerlinConstants.java 3a56530 
>   falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/interfaces/IEntityManagerHelper.java ec8726c 
>   falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/AssertUtil.java d8ac903 
>   falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/CleanupUtil.java bf99291 
>   falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/MathUtil.java 1bbe8d9 
>   falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/Util.java 8fdf65a 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/security/AclValidationTest.java PRE-CREATION 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/security/ClusterAclTest.java PRE-CREATION 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/security/EntityOp.java PRE-CREATION 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/security/FeedAclTest.java PRE-CREATION 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/security/ProcessAclTest.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/26110/diff/
> 
> 
> Testing
> -------
> 
> Adding new tests.
> 
> 
> Thanks,
> 
> Raghav Gautam
> 
>

Re: Review Request 26110: Add ACL validation and enforcement tests

Posted by Raghav Gautam <ra...@apache.org>.


> On Oct. 3, 2014, 4:12 a.m., Ruslan Ostafiychuk wrote:
> > falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/Entities/ClusterMerlin.java, line 90
> > <https://reviews.apache.org/r/26110/diff/3/?file=709595#file709595line90>
> >
> >     Three setACL() methods looks similar. I think ACL creation with three parameters can be extracted to *Util.setACL(Entity, String, String, String)

There are three different ACL classes that are involved here:
org.apache.falcon.entity.v0.cluster.ACL
org.apache.falcon.entity.v0.feed.ACL
org.apache.falcon.entity.v0.process.ACL

Because of this we can't create a single method to set ACL.


> On Oct. 3, 2014, 4:12 a.m., Ruslan Ostafiychuk wrote:
> > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/security/EntityOp.java, line 49
> > <https://reviews.apache.org/r/26110/diff/3/?file=709607#file709607line49>
> >
> >     Exceptions are not logged.

Which one ? I think I have logged all the exceptions.


- Raghav


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26110/#review55331
-----------------------------------------------------------


On Oct. 3, 2014, 12:44 p.m., Raghav Gautam wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26110/
> -----------------------------------------------------------
> 
> (Updated Oct. 3, 2014, 12:44 p.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: falcon-746
>     https://issues.apache.org/jira/browse/falcon-746
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> Add ACL validation and enforcement tests.
> 
> 
> Diffs
> -----
> 
>   falcon-regression/README.md 659657c 
>   falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/Entities/ClusterMerlin.java 33b67f7 
>   falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/Entities/FeedMerlin.java 025fc15 
>   falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/Entities/ProcessMerlin.java a10dfc1 
>   falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/bundle/Bundle.java eac3cb4 
>   falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/enumsAndConstants/MerlinConstants.java 3a56530 
>   falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/interfaces/IEntityManagerHelper.java 66a1b7f 
>   falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/supportClasses/ExecResult.java PRE-CREATION 
>   falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/AssertUtil.java d8ac903 
>   falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/CleanupUtil.java bf99291 
>   falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/MathUtil.java 1bbe8d9 
>   falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/Util.java 30eaf61 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/security/AclValidationTest.java PRE-CREATION 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/security/ClusterAclTest.java PRE-CREATION 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/security/EntityOp.java PRE-CREATION 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/security/FeedAclTest.java PRE-CREATION 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/security/ProcessAclTest.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/26110/diff/
> 
> 
> Testing
> -------
> 
> Adding new tests.
> 
> 
> Thanks,
> 
> Raghav Gautam
> 
>

Re: Review Request 26110: Add ACL validation and enforcement tests

Posted by Ruslan Ostafiychuk <ro...@hortonworks.com>.


> On Oct. 3, 2014, 11:12 a.m., Ruslan Ostafiychuk wrote:
> > falcon-regression/merlin/src/test/java/org/apache/falcon/regression/security/EntityOp.java, line 49
> > <https://reviews.apache.org/r/26110/diff/3/?file=709607#file709607line49>
> >
> >     Exceptions are not logged.
> 
> Raghav Gautam wrote:
>     Which one ? I think I have logged all the exceptions.

"Caught exception: e" is logged every time. Object of exception is ignored.


- Ruslan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26110/#review55331
-----------------------------------------------------------


On Oct. 3, 2014, 7:44 p.m., Raghav Gautam wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26110/
> -----------------------------------------------------------
> 
> (Updated Oct. 3, 2014, 7:44 p.m.)
> 
> 
> Review request for Falcon.
> 
> 
> Bugs: falcon-746
>     https://issues.apache.org/jira/browse/falcon-746
> 
> 
> Repository: falcon-git
> 
> 
> Description
> -------
> 
> Add ACL validation and enforcement tests.
> 
> 
> Diffs
> -----
> 
>   falcon-regression/README.md 659657c 
>   falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/Entities/ClusterMerlin.java 33b67f7 
>   falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/Entities/FeedMerlin.java 025fc15 
>   falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/Entities/ProcessMerlin.java a10dfc1 
>   falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/bundle/Bundle.java eac3cb4 
>   falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/enumsAndConstants/MerlinConstants.java 3a56530 
>   falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/interfaces/IEntityManagerHelper.java 66a1b7f 
>   falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/supportClasses/ExecResult.java PRE-CREATION 
>   falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/AssertUtil.java d8ac903 
>   falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/CleanupUtil.java bf99291 
>   falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/MathUtil.java 1bbe8d9 
>   falcon-regression/merlin-core/src/main/java/org/apache/falcon/regression/core/util/Util.java 30eaf61 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/security/AclValidationTest.java PRE-CREATION 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/security/ClusterAclTest.java PRE-CREATION 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/security/EntityOp.java PRE-CREATION 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/security/FeedAclTest.java PRE-CREATION 
>   falcon-regression/merlin/src/test/java/org/apache/falcon/regression/security/ProcessAclTest.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/26110/diff/
> 
> 
> Testing
> -------
> 
> Adding new tests.
> 
> 
> Thanks,
> 
> Raghav Gautam
> 
>