You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/10/11 05:42:26 UTC

[GitHub] [airflow] milton0825 commented on a change in pull request #6302: [AIRFLOW-5636] Allow adding or overriding existing Operator Links for…

milton0825 commented on a change in pull request #6302: [AIRFLOW-5636] Allow adding or overriding existing Operator Links for…
URL: https://github.com/apache/airflow/pull/6302#discussion_r333833003
 
 

 ##########
 File path: airflow/models/baseoperator.py
 ##########
 @@ -566,7 +566,20 @@ def priority_weight_total(self):
     @cached_property
     def operator_extra_link_dict(self):
         """Returns dictionary of all extra links for the operator"""
-        return {link.name: link for link in self.operator_extra_links}
+        from airflow.plugins_manager import operator_extra_links
+
+        op_extra_links_from_plugin = {}
+        for ope in operator_extra_links:
+            if ope.operator_name == self.__class__.__name__:
 
 Review comment:
   Shall we also include the module name here? It is possible that the user create an operator with the same name but registered in a different package through plugin?
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services