You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tika.apache.org by "dk2k (via GitHub)" <gi...@apache.org> on 2024/08/03 19:10:59 UTC
[PR] TIKA-4290 Attempt to fix error "instance of Class compared with String" [tika]
dk2k opened a new pull request, #1872:
URL: https://github.com/apache/tika/pull/1872
TIKA-4290 Attempt to fix error "instance of Class compared with String"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tika.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] TIKA-4290 Attempt to fix error "instance of Class compared with String" [tika]
Posted by "THausherr (via GitHub)" <gi...@apache.org>.
THausherr closed pull request #1872: TIKA-4290 Attempt to fix error "instance of Class compared with String"
URL: https://github.com/apache/tika/pull/1872
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tika.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] TIKA-4290 Attempt to fix error "instance of Class compared with String" [tika]
Posted by "tballison (via GitHub)" <gi...@apache.org>.
tballison commented on PR #1872:
URL: https://github.com/apache/tika/pull/1872#issuecomment-2269315467
There's redundancy in the serialization/deserialization of ParseContext, where the key name is the super class. I wanted to reuse TikaJsonSerializer#serializeObject which needs to encode the instantiation class and the superclass because normally the superclass is not defined. Let me try to clean this up.
This is the redundancy that is part of ParseContext:
```
"parseContext": {
"org.apache.tika.metadata.filter.MetadataFilter": {
"_class": "org.apache.tika.metadata.filter.CompositeMetadataFilter",
"_super_class": "org.apache.tika.metadata.filter.MetadataFilter",
"filters": [
{
"_class": "org.apache.tika.metadatafilters.SomeFilter",
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tika.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] TIKA-4290 Attempt to fix error "instance of Class compared with String" [tika]
Posted by "THausherr (via GitHub)" <gi...@apache.org>.
THausherr commented on PR #1872:
URL: https://github.com/apache/tika/pull/1872#issuecomment-2267359000
I made a comment at the bottom of TIKA-4252 because even with the correction, that line of code doesn't make sense to me, the alternative isn't needed, the result is always the same.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tika.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] TIKA-4290 Attempt to fix error "instance of Class compared with String" [tika]
Posted by "THausherr (via GitHub)" <gi...@apache.org>.
THausherr commented on PR #1872:
URL: https://github.com/apache/tika/pull/1872#issuecomment-2269364285
Tim will fix it in https://issues.apache.org/jira/browse/TIKA-4294 , so I guess I should close this PR. Thanks for finding this!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@tika.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org