You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jmeter.apache.org by "vlsi (via GitHub)" <gi...@apache.org> on 2023/05/11 07:11:32 UTC
[GitHub] [jmeter] vlsi opened a new pull request, #5909: feat: Use Caffeine for caching compiled scripts in JSR223 samplers instead of commons-collections4 LRUMap
vlsi opened a new pull request, #5909:
URL: https://github.com/apache/jmeter/pull/5909
## Motivation and Context
Caffeine is a much more robust caching solution, so it makes sense to use it instead of the older `LRUMap`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jmeter.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [jmeter] vlsi commented on pull request #5909: feat: Use Caffeine for caching compiled scripts in JSR223 samplers instead of commons-collections4 LRUMap
Posted by "vlsi (via GitHub)" <gi...@apache.org>.
vlsi commented on PR #5909:
URL: https://github.com/apache/jmeter/pull/5909#issuecomment-1667343636
`get` creates the value if needed: https://www.javadoc.io/doc/com.github.ben-manes.caffeine/caffeine/2.0.3/com/github/benmanes/caffeine/cache/Cache.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jmeter.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [jmeter] owenpahl commented on pull request #5909: feat: Use Caffeine for caching compiled scripts in JSR223 samplers instead of commons-collections4 LRUMap
Posted by "owenpahl (via GitHub)" <gi...@apache.org>.
owenpahl commented on PR #5909:
URL: https://github.com/apache/jmeter/pull/5909#issuecomment-1667106235
@vlsi, I know this change is old and is already in master for a while now.
But I was looking through it as I was curious about the change to Caffeine, and I can't see anywhere in the source where compiled scripts are added to the new cache. There only appears to be two references to the cache, one to see if a script is present (https://github.com/apache/jmeter/blob/5380e59d62efbd91128e46990f14ca8a6f648c6d/src/core/src/main/java/org/apache/jmeter/util/JSR223TestElement.java#L249) and emptying the cache at the end of a test (https://github.com/apache/jmeter/blob/5380e59d62efbd91128e46990f14ca8a6f648c6d/src/core/src/main/java/org/apache/jmeter/util/JSR223TestElement.java#L357)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jmeter.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [jmeter] vlsi merged pull request #5909: feat: Use Caffeine for caching compiled scripts in JSR223 samplers instead of commons-collections4 LRUMap
Posted by "vlsi (via GitHub)" <gi...@apache.org>.
vlsi merged PR #5909:
URL: https://github.com/apache/jmeter/pull/5909
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@jmeter.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org