You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rave.apache.org by Daniel Gornstein <dg...@mitre.org> on 2012/10/03 16:26:21 UTC
Review Request: Rave 806 - Friendly error message page when jsDebugMode is
off
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7408/
-----------------------------------------------------------
Review request for rave.
Description
-------
If jsDebugMode is on show the stack trace error as rave currently works.
If jsDebugMode is off show a friendly error message page
Diffs
-----
trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/error.jsp 1393408
Diff: https://reviews.apache.org/r/7408/diff/
Testing
-------
Thanks,
Daniel Gornstein
Re: Review Request: Rave 806 - Friendly error message page when jsDebugMode
is off
Posted by Anthony Carlucci <ac...@mitre.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7408/#review12274
-----------------------------------------------------------
Please include a JUnit test class for the new ShowStackTraceTag class, otherwise this patch looks good.
- Anthony Carlucci
On Oct. 5, 2012, 2:40 p.m., Daniel Gornstein wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7408/
> -----------------------------------------------------------
>
> (Updated Oct. 5, 2012, 2:40 p.m.)
>
>
> Review request for rave.
>
>
> Description
> -------
>
> If jsDebugMode is on show the stack trace error as rave currently works.
>
> If jsDebugMode is off show a friendly error message page
>
>
> Diffs
> -----
>
> trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/web/util/PortalPreferenceKeys.java 1394457
> trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/model/PortalPreferenceForm.java 1394457
> trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/tag/ShowStackTraceTag.java PRE-CREATION
> trunk/rave-components/rave-web/src/main/resources/META-INF/rave.tld 1394457
> trunk/rave-portal-resources/src/main/resources/messages.properties 1394457
> trunk/rave-portal-resources/src/main/webapp/WEB-INF/db/initial_data.sql 1394457
> trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/admin/preferencedetail.jsp 1394457
> trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/error.jsp 1394457
>
> Diff: https://reviews.apache.org/r/7408/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Daniel Gornstein
>
>
Re: Review Request: Rave 806 - Friendly error message page when jsDebugMode
is off
Posted by Anthony Carlucci <ac...@mitre.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7408/#review12286
-----------------------------------------------------------
Ship it!
I will apply Dan's updated patch in Jira containing the unit test class
- Anthony Carlucci
On Oct. 5, 2012, 2:40 p.m., Daniel Gornstein wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/7408/
> -----------------------------------------------------------
>
> (Updated Oct. 5, 2012, 2:40 p.m.)
>
>
> Review request for rave.
>
>
> Description
> -------
>
> If jsDebugMode is on show the stack trace error as rave currently works.
>
> If jsDebugMode is off show a friendly error message page
>
>
> Diffs
> -----
>
> trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/web/util/PortalPreferenceKeys.java 1394457
> trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/model/PortalPreferenceForm.java 1394457
> trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/tag/ShowStackTraceTag.java PRE-CREATION
> trunk/rave-components/rave-web/src/main/resources/META-INF/rave.tld 1394457
> trunk/rave-portal-resources/src/main/resources/messages.properties 1394457
> trunk/rave-portal-resources/src/main/webapp/WEB-INF/db/initial_data.sql 1394457
> trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/admin/preferencedetail.jsp 1394457
> trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/error.jsp 1394457
>
> Diff: https://reviews.apache.org/r/7408/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Daniel Gornstein
>
>
Re: Review Request: Rave 806 - Friendly error message page when jsDebugMode
is off
Posted by Daniel Gornstein <dg...@mitre.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/7408/
-----------------------------------------------------------
(Updated Oct. 5, 2012, 2:40 p.m.)
Review request for rave.
Changes
-------
A new patch which allows setting a preference to show or hide the technical details (stack trace) on the error page.
Description
-------
If jsDebugMode is on show the stack trace error as rave currently works.
If jsDebugMode is off show a friendly error message page
Diffs (updated)
-----
trunk/rave-components/rave-core/src/main/java/org/apache/rave/portal/web/util/PortalPreferenceKeys.java 1394457
trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/model/PortalPreferenceForm.java 1394457
trunk/rave-components/rave-web/src/main/java/org/apache/rave/portal/web/tag/ShowStackTraceTag.java PRE-CREATION
trunk/rave-components/rave-web/src/main/resources/META-INF/rave.tld 1394457
trunk/rave-portal-resources/src/main/resources/messages.properties 1394457
trunk/rave-portal-resources/src/main/webapp/WEB-INF/db/initial_data.sql 1394457
trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/admin/preferencedetail.jsp 1394457
trunk/rave-portal-resources/src/main/webapp/WEB-INF/jsp/views/error.jsp 1394457
Diff: https://reviews.apache.org/r/7408/diff/
Testing
-------
Thanks,
Daniel Gornstein