[GitHub] [bookkeeper] massakam commented on a diff in pull request #3214: Issue 3070: Fix bug where checkAllLedgers gets stuck when read throttling is enabled

[GitBox <gi...@apache.org>]

massakam commented on code in PR #3214:
URL: https://github.com/apache/bookkeeper/pull/3214#discussion_r906647070


##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/conf/ServerConfiguration.java:
##########
@@ -213,7 +213,7 @@ public class ServerConfiguration extends AbstractConfiguration<ServerConfigurati
         "auditorMaxNumberOfConcurrentOpenLedgerOperations";
     protected static final String AUDITOR_ACQUIRE_CONCURRENT_OPEN_LEDGER_OPERATIONS_TIMEOUT_MSEC =
         "auditorAcquireConcurrentOpenLedgerOperationsTimeOutMSec";
-    protected static final String IN_FLIGHT_READ_ENTRY_NUM_IN_LEDGER_CHECKER = "inFlightReadEntryNumInLedgerChecker";
+    protected static final String READ_ENTRY_RATE_IN_LEDGER_CHECKER = "readEntryRateInLedgerChecker";

Review Comment:
   @hangc0276 I don't think the value of `inFlightReadEntryNumInLedgerChecker` should be set to `readEntryRateInLedgerChecker`, as the two settings have slightly different meanings. Therefore, I decided to restore the old setting. If both `readEntryRateInLedgerChecker` and `inFlightReadEntryNumInLedgerChecker` are set, `readEntryRateInLedgerChecker` takes precedence and `inFlightReadEntryNumInLedgerChecker` is ignored.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org