You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Kevin Sweeney <ke...@apache.org> on 2015/07/28 05:01:16 UTC

Review Request 36874: Fix typo in the scheduler deployment documentation

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36874/
-----------------------------------------------------------

Review request for Aurora and Maxim Khutornenko.


Repository: aurora


Description
-------

Fix typo in scheduler deployment documentation

The command should be run on schedulers, not masters.


Diffs
-----

  docs/deploying-aurora-scheduler.md 11155b9495b6e3ab59038b34e5e4deab59f7172d 

Diff: https://reviews.apache.org/r/36874/diff/


Testing
-------


Thanks,

Kevin Sweeney


Re: Review Request 36874: Fix typo in the scheduler deployment documentation

Posted by John Sirois <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36874/#review107129
-----------------------------------------------------------

Ship it!


Ping - This should be patched in by a committer FWICT.

- John Sirois


On July 27, 2015, 9:01 p.m., Kevin Sweeney wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36874/
> -----------------------------------------------------------
> 
> (Updated July 27, 2015, 9:01 p.m.)
> 
> 
> Review request for Aurora and Maxim Khutornenko.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Fix typo in scheduler deployment documentation
> 
> The command should be run on schedulers, not masters.
> 
> 
> Diffs
> -----
> 
>   docs/deploying-aurora-scheduler.md 11155b9495b6e3ab59038b34e5e4deab59f7172d 
> 
> Diff: https://reviews.apache.org/r/36874/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kevin Sweeney
> 
>


Re: Review Request 36874: Fix typo in the scheduler deployment documentation

Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36874/#review93227
-----------------------------------------------------------

Ship it!


Master (d9c911a) is green with this patch.
  ./build-support/jenkins/build.sh

I will refresh this build result if you post a review containing "@ReviewBot retry"

- Aurora ReviewBot


On July 28, 2015, 3:01 a.m., Kevin Sweeney wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36874/
> -----------------------------------------------------------
> 
> (Updated July 28, 2015, 3:01 a.m.)
> 
> 
> Review request for Aurora and Maxim Khutornenko.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Fix typo in scheduler deployment documentation
> 
> The command should be run on schedulers, not masters.
> 
> 
> Diffs
> -----
> 
>   docs/deploying-aurora-scheduler.md 11155b9495b6e3ab59038b34e5e4deab59f7172d 
> 
> Diff: https://reviews.apache.org/r/36874/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kevin Sweeney
> 
>


Re: Review Request 36874: Fix typo in the scheduler deployment documentation

Posted by Jake Farrell <jf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36874/#review100842
-----------------------------------------------------------

Ship it!


Ship It!

- Jake Farrell


On July 28, 2015, 3:01 a.m., Kevin Sweeney wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36874/
> -----------------------------------------------------------
> 
> (Updated July 28, 2015, 3:01 a.m.)
> 
> 
> Review request for Aurora and Maxim Khutornenko.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Fix typo in scheduler deployment documentation
> 
> The command should be run on schedulers, not masters.
> 
> 
> Diffs
> -----
> 
>   docs/deploying-aurora-scheduler.md 11155b9495b6e3ab59038b34e5e4deab59f7172d 
> 
> Diff: https://reviews.apache.org/r/36874/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kevin Sweeney
> 
>


Re: Review Request 36874: Fix typo in the scheduler deployment documentation

Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36874/#review107130
-----------------------------------------------------------

Ship it!


This is now on master:
```
$ git log -1 origin/master
commit 7b43b99 (HEAD -> master, origin/master, origin/HEAD)
Author: Kevin Sweeney <ke...@apache.org>
Date:   Wed Nov 18 20:36:49 2015 -0800

    Fix typo in the scheduler deployment documentation.

    Reviewed at https://reviews.apache.org/r/36874/
```

- Bill Farner


On July 27, 2015, 8:01 p.m., Kevin Sweeney wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36874/
> -----------------------------------------------------------
> 
> (Updated July 27, 2015, 8:01 p.m.)
> 
> 
> Review request for Aurora and Maxim Khutornenko.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Fix typo in scheduler deployment documentation
> 
> The command should be run on schedulers, not masters.
> 
> 
> Diffs
> -----
> 
>   docs/deploying-aurora-scheduler.md 11155b9495b6e3ab59038b34e5e4deab59f7172d 
> 
> Diff: https://reviews.apache.org/r/36874/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kevin Sweeney
> 
>


Re: Review Request 36874: Fix typo in the scheduler deployment documentation

Posted by Maxim Khutornenko <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36874/#review93944
-----------------------------------------------------------

Ship it!


Ship It!

- Maxim Khutornenko


On July 28, 2015, 3:01 a.m., Kevin Sweeney wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36874/
> -----------------------------------------------------------
> 
> (Updated July 28, 2015, 3:01 a.m.)
> 
> 
> Review request for Aurora and Maxim Khutornenko.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Fix typo in scheduler deployment documentation
> 
> The command should be run on schedulers, not masters.
> 
> 
> Diffs
> -----
> 
>   docs/deploying-aurora-scheduler.md 11155b9495b6e3ab59038b34e5e4deab59f7172d 
> 
> Diff: https://reviews.apache.org/r/36874/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kevin Sweeney
> 
>


Re: Review Request 36874: Fix typo in the scheduler deployment documentation

Posted by Kevin Sweeney <ke...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36874/#review93943
-----------------------------------------------------------


ping

- Kevin Sweeney


On July 27, 2015, 8:01 p.m., Kevin Sweeney wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/36874/
> -----------------------------------------------------------
> 
> (Updated July 27, 2015, 8:01 p.m.)
> 
> 
> Review request for Aurora and Maxim Khutornenko.
> 
> 
> Repository: aurora
> 
> 
> Description
> -------
> 
> Fix typo in scheduler deployment documentation
> 
> The command should be run on schedulers, not masters.
> 
> 
> Diffs
> -----
> 
>   docs/deploying-aurora-scheduler.md 11155b9495b6e3ab59038b34e5e4deab59f7172d 
> 
> Diff: https://reviews.apache.org/r/36874/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Kevin Sweeney
> 
>