You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@twill.apache.org by chtyim <gi...@git.apache.org> on 2015/09/24 12:24:59 UTC
[GitHub] incubator-twill pull request: (TWILL-141) Fix namespacing of ZKCli...
GitHub user chtyim opened a pull request:
https://github.com/apache/incubator-twill/pull/64
(TWILL-141) Fix namespacing of ZKClient
- Not to fail with exception when creating “/“ through the
namespaced ZKClient
- Return the correct path in OperationFuture.getRequestPath() for
futures returned from namespaced ZKClient
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/chtyim/incubator-twill feature/TWILL-141
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-twill/pull/64.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #64
----
commit 1c4196851fd945539d7d7ebe437c58bd9c43e717
Author: Terence Yim <ch...@apache.org>
Date: 2015-09-24T10:22:24Z
(TWILL-141) Fix namespacing of ZKClient
- Not to fail with exception when creating “/“ through the
namespaced ZKClient
- Return the correct path in OperationFuture.getRequestPath() for
futures returned from namespaced ZKClient
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-twill pull request: (TWILL-141) Fix namespacing of ZKCli...
Posted by hsaputra <gi...@git.apache.org>.
Github user hsaputra commented on the pull request:
https://github.com/apache/incubator-twill/pull/64#issuecomment-143336078
Merging ...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-twill pull request: (TWILL-141) Fix namespacing of ZKCli...
Posted by henry-cask <gi...@git.apache.org>.
Github user henry-cask commented on the pull request:
https://github.com/apache/incubator-twill/pull/64#issuecomment-143299948
+1
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-twill pull request: (TWILL-141) Fix namespacing of ZKCli...
Posted by henry-cask <gi...@git.apache.org>.
Github user henry-cask commented on the pull request:
https://github.com/apache/incubator-twill/pull/64#issuecomment-143302542
Will merge this sometime today if no more comment.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-twill pull request: (TWILL-141) Fix namespacing of ZKCli...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-twill/pull/64
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---