You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@guacamole.apache.org by "jmuehlner (via GitHub)" <gi...@apache.org> on 2023/04/13 19:03:52 UTC
[GitHub] [guacamole-client] jmuehlner opened a new pull request, #833: GUACMAOLE-926: Fix loading bug and fuzzier group matching
jmuehlner opened a new pull request, #833:
URL: https://github.com/apache/guacamole-client/pull/833
This change does two things:
* Fix a bug where the loading spinner would be applied and never go away on a failed import file parse.
* Allow a bit more leeway for users in how they declare their group declarations:
- They can (as before) specify the full path like "ROOT/parent/child"
- They can use just a leading slash instead of the root group like "/parent/child"
- They can leave off the leading slash, like "parent/child"
- They can optionally include a trailing slash like "parent/child/"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [guacamole-client] necouchman merged pull request #833: GUACAMOLE-926: Fix loading bug and fuzzier group matching
Posted by "necouchman (via GitHub)" <gi...@apache.org>.
necouchman merged PR #833:
URL: https://github.com/apache/guacamole-client/pull/833
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [guacamole-client] jmuehlner commented on a diff in pull request #833: GUACMAOLE-926: Fix loading bug and fuzzier group matching
Posted by "jmuehlner (via GitHub)" <gi...@apache.org>.
jmuehlner commented on code in PR #833:
URL: https://github.com/apache/guacamole-client/pull/833#discussion_r1165923874
##########
guacamole/src/main/frontend/src/app/import/services/connectionParseService.js:
##########
@@ -167,7 +196,7 @@ angular.module('import').factory('connectionParseService',
// Set the parent identifier now that it's known
return {
- ...connection,
+ ..._.omit(connection, 'group'),
Review Comment:
This isn't strictly necessary - when passed to the `Connection` constructor later, this will automatically get removed, and will actually incur a small performance penalty from copying the connection object.
If people don't think the added cleanliness of removing the `group` field at this point is worth it, I'd be ok with removing this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [guacamole-client] necouchman commented on a diff in pull request #833: GUACMAOLE-926: Fix loading bug and fuzzier group matching
Posted by "necouchman (via GitHub)" <gi...@apache.org>.
necouchman commented on code in PR #833:
URL: https://github.com/apache/guacamole-client/pull/833#discussion_r1165939858
##########
guacamole/src/main/frontend/src/app/import/services/connectionParseService.js:
##########
@@ -167,7 +196,7 @@ angular.module('import').factory('connectionParseService',
// Set the parent identifier now that it's known
return {
- ...connection,
+ ..._.omit(connection, 'group'),
Review Comment:
If the performance penalty is negligible and doesn't change depending on the number of connections you import, then I'm fine leaving it. If the performance penalty scales as you increase the number of connections, then it seems like removing this is probably a good idea, particularly if it is going to get taken off elsewhere.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [guacamole-client] jmuehlner commented on a diff in pull request #833: GUACAMOLE-926: Fix loading bug and fuzzier group matching
Posted by "jmuehlner (via GitHub)" <gi...@apache.org>.
jmuehlner commented on code in PR #833:
URL: https://github.com/apache/guacamole-client/pull/833#discussion_r1165943281
##########
guacamole/src/main/frontend/src/app/import/services/connectionParseService.js:
##########
@@ -167,7 +196,7 @@ angular.module('import').factory('connectionParseService',
// Set the parent identifier now that it's known
return {
- ...connection,
+ ..._.omit(connection, 'group'),
Review Comment:
The performance hit will scale linearly with the number of connections since this is run once per connection. I'll remove it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org