You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2019/10/24 04:56:52 UTC
[GitHub] [helix] pkuwm opened a new pull request #531: Make log clearer
after finishing calculateAssignment.
pkuwm opened a new pull request #531: Make log clearer after finishing calculateAssignment.
URL: https://github.com/apache/helix/pull/531
### Issues
- [x] My PR addresses the following Helix issues and references them in the PR title:
Fix #530 .
### Description
- [x] Here are some details about my PR, including screenshots of any UI changes:
Fix #530
Make the log clearer.
### Tests
- [x] The following tests are written for this issue:
No new test.
- [x] The following is the result of the "mvn test" command on the appropriate module:
Minor log change. run mvn build instead.
### Commits
- [x] My commits all reference appropriate Apache Helix GitHub issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message":
Subject is separated from body by a blank line
Subject is limited to 50 characters (not including Jira issue reference)
Subject does not end with a period
Subject uses the imperative mood ("add", not "adding")
Body wraps at 72 characters
Body explains "what" and "why", not "how"
Documentation
In case of new functionality, my PR adds documentation in the following wiki page:
(Link the GitHub wiki you added)
### Code Quality
- [x] My diff has been formatted using helix-style-intellij.xml
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org