[GitHub] [dubbo-samples] kylixs commented on a change in pull request #219: update to new test framework

[GitBox <gi...@apache.org>]

kylixs commented on a change in pull request #219:
URL: https://github.com/apache/dubbo-samples/pull/219#discussion_r551432128



##########
File path: dubbo-samples-configcenter/dubbo-samples-configcenter-apollo/case-configuration.yml
##########
@@ -14,7 +14,7 @@
 # See the License for the specific language governing permissions and
 # limitations under the License.
 
-timeout: 120
+timeout: 180

Review comment:
       timeout 不用设置这么大吧？避免失败时长时间等待

##########
File path: dubbo-samples-configcenter/dubbo-samples-configcenter-apollo/case-configuration.yml
##########
@@ -38,20 +39,19 @@ services:
       - zookeeper.port=2181
       - dubbo.address=dubbo-samples-configcenter-apollo
       - dubbo.port=20880
+      - apollo.address=apollo-quick-start
+      - apollo.port=8080
     waitPortsBeforeRun:
       - dubbo-samples-configcenter-apollo:2181
       - dubbo-samples-configcenter-apollo:20880
-    checkTimeout: 100
+    checkTimeout: 240

Review comment:
       test的timeout比全局的timeout大，不起作用




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org