Re: [PR] Fixing partitioning function for byte array [pinot]

["Jackie-Jiang (via GitHub)" <gi...@apache.org>]

Jackie-Jiang commented on code in PR #12102:
URL: https://github.com/apache/pinot/pull/12102#discussion_r1419443916


##########
pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/partition/PartitionFunction.java:
##########
@@ -32,6 +33,18 @@
  */
 public interface PartitionFunction extends Serializable {
 
+  /**
+   * Translates value to the correct instance type before invoking partitioning function
+   * @param value
+   * @return
+   */
+  default int getValueToPartition(Object value) {

Review Comment:
   Don't add this new method. `PartitionFunction` is not pluggable, so let's fix all implementations instead



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org