You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/01/25 21:17:36 UTC
[GitHub] dongjoon-hyun commented on a change in pull request #23653:
[SPARK-26711][SQL] Lazily convert string values to BigDecimal during JSON
schema inference
dongjoon-hyun commented on a change in pull request #23653: [SPARK-26711][SQL] Lazily convert string values to BigDecimal during JSON schema inference
URL: https://github.com/apache/spark/pull/23653#discussion_r251138887
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JsonInferSchema.scala
##########
@@ -122,7 +122,7 @@ private[sql] class JsonInferSchema(options: JSONOptions) extends Serializable {
case VALUE_STRING =>
val field = parser.getText
- val decimalTry = allCatch opt {
+ lazy val decimalTry = allCatch opt {
Review comment:
+1, looks correct.
cc @HyukjinKwon , @MaxGekk , @cloud-fan
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org