[GitHub] [ignite] sk0x50 commented on a change in pull request #7613: IGNITE-12821 Add check size into validate_indexes

[GitBox <gi...@apache.org>]

sk0x50 commented on a change in pull request #7613: IGNITE-12821 Add check size into validate_indexes
URL: https://github.com/apache/ignite/pull/7613#discussion_r407255037
 
 

 ##########
 File path: modules/core/src/main/java/org/apache/ignite/internal/processors/query/GridQueryProcessor.java
 ##########
 @@ -2906,13 +2908,11 @@ public void remove(GridCacheContext cctx, CacheDataRow row)
      * @return Descriptors.
      */
     public Collection<GridQueryTypeDescriptor> types(@Nullable String cacheName) {
-        Collection<GridQueryTypeDescriptor> cacheTypes = new ArrayList<>();
+        Collection<GridQueryTypeDescriptor> cacheTypes = newSetFromMap(new IdentityHashMap<>());
 
 Review comment:
   What is the reason for using *IdentityHashMap*? Should this method return duplicates? It looks like the answer is no.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services