You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Andrei Sekretenko <as...@mesosphere.io> on 2020/08/17 20:20:18 UTC
Review Request 72785: Introduced a weak_ptr-based cache abstraction.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72785/
-----------------------------------------------------------
Review request for mesos and Benjamin Mahler.
Bugs: MESOS-10173
https://issues.apache.org/jira/browse/MESOS-10173
Repository: mesos
Description
-------
This patch adds a key-value cache that hands out shared pointers to
cached items, but itself does not own the items (hence, the items get
deleted as soon as they are no longer referenced by anything else).
Diffs
-----
3rdparty/stout/include/stout/weak_cache.hpp PRE-CREATION
3rdparty/stout/tests/CMakeLists.txt e3291c72d1875f5b196dd5ea2ba20e7d53881b87
3rdparty/stout/tests/weak_cache_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/72785/diff/1/
Testing
-------
Thanks,
Andrei Sekretenko
Re: Review Request 72785: Introduced a weak_ptr-based cache
abstraction.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72785/#review221694
-----------------------------------------------------------
Bad patch!
Reviews applied: [72785, 72784, 72783, 72782, 72776, 72775, 72745, 72744, 72743, 72774, 72742, 72741, 72739, 72738, 72771]
Failed command: cd .. && /usr/bin/python3 support/apply-reviews.py -n -r 72745
Error:
2020-08-24 21:01:31 URL:https://reviews.apache.org/r/72745/diff/raw/ [5982/5982] -> "72745.patch" [1]
*** Please tell me who you are.
Run
git config --global user.email "you@example.com"
git config --global user.name "Your Name"
to set your account's default identity.
Omit --global to set the identity only in this repository.
fatal: empty ident name (for <je...@asf941.gq1.ygridcore.net>) not allowed
Full log: https://ci-builds.apache.org/job/Mesos/job/Mesos-Reviewbot-Linux/88/console
- Mesos Reviewbot
On Aug. 17, 2020, 8:20 p.m., Andrei Sekretenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72785/
> -----------------------------------------------------------
>
> (Updated Aug. 17, 2020, 8:20 p.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Bugs: MESOS-10173
> https://issues.apache.org/jira/browse/MESOS-10173
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch adds a key-value cache that hands out shared pointers to
> cached items, but does not own the items (hence, the items get
> deleted as soon as they are no longer referenced by anything else).
>
>
> Diffs
> -----
>
> 3rdparty/stout/include/Makefile.am ad3f2105d9e159995be1979007d6ddbe5ec9e133
> 3rdparty/stout/include/stout/weak_cache.hpp PRE-CREATION
> 3rdparty/stout/tests/CMakeLists.txt e3291c72d1875f5b196dd5ea2ba20e7d53881b87
> 3rdparty/stout/tests/weak_cache_tests.cpp PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/72785/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andrei Sekretenko
>
>
Re: Review Request 72785: Introduced a weak_ptr-based cache
abstraction.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72785/#review221706
-----------------------------------------------------------
Bad patch!
Reviews applied: [72785]
Failed command: cd .. && /usr/bin/python3 support/apply-reviews.py -n -r 72785
Error:
2020-08-25 14:11:32 URL:https://reviews.apache.org/r/72785/diff/raw/ [7759/7759] -> "72785.patch" [1]
*** Please tell me who you are.
Run
git config --global user.email "you@example.com"
git config --global user.name "Your Name"
to set your account's default identity.
Omit --global to set the identity only in this repository.
fatal: empty ident name (for <je...@asf931.gq1.ygridcore.net>) not allowed
Full log: https://ci-builds.apache.org/job/Mesos/job/Mesos-Reviewbot-Linux/102/console
- Mesos Reviewbot
On Aug. 17, 2020, 8:20 p.m., Andrei Sekretenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72785/
> -----------------------------------------------------------
>
> (Updated Aug. 17, 2020, 8:20 p.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Bugs: MESOS-10173
> https://issues.apache.org/jira/browse/MESOS-10173
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch adds a key-value cache that hands out shared pointers to
> cached items, but does not own the items (hence, the items get
> deleted as soon as they are no longer referenced by anything else).
>
>
> Diffs
> -----
>
> 3rdparty/stout/include/Makefile.am ad3f2105d9e159995be1979007d6ddbe5ec9e133
> 3rdparty/stout/include/stout/weak_cache.hpp PRE-CREATION
> 3rdparty/stout/tests/CMakeLists.txt e3291c72d1875f5b196dd5ea2ba20e7d53881b87
> 3rdparty/stout/tests/weak_cache_tests.cpp PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/72785/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Andrei Sekretenko
>
>