You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by John Sichi <js...@fb.com> on 2011/02/24 00:21:56 UTC

Review Request: HIVE-1994: Support new annotation @UDFType(stateful = true)

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/442/
-----------------------------------------------------------

Review request for hive.


Summary
-------

Review request from JVS.


This addresses bug HIVE-1994.
    https://issues.apache.org/jira/browse/HIVE-1994


Diffs
-----

  http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/TypeCheckCtx.java 1073978 
  http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/TypeCheckProcFactory.java 1073978 
  http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFType.java 1073978 
  http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/queries/clientpositive/udf_case.q 1073978 
  http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/results/clientpositive/udf_case.q.out 1073978 
  http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/ErrorMsg.java 1073978 
  http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 1073978 
  http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/ExprNodeGenericFuncEvaluator.java 1073978 
  http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java 1073978 
  http://svn.apache.org/repos/asf/hive/trunk/contrib/src/test/results/clientnegative/invalid_row_sequence.q.out PRE-CREATION 
  http://svn.apache.org/repos/asf/hive/trunk/contrib/src/test/results/clientpositive/udf_row_sequence.q.out 1073978 
  http://svn.apache.org/repos/asf/hive/trunk/contrib/src/java/org/apache/hadoop/hive/contrib/udf/UDFRowSequence.java 1073978 
  http://svn.apache.org/repos/asf/hive/trunk/contrib/src/test/queries/clientnegative/case_with_row_sequence.q PRE-CREATION 
  http://svn.apache.org/repos/asf/hive/trunk/contrib/src/test/queries/clientnegative/invalid_row_sequence.q PRE-CREATION 
  http://svn.apache.org/repos/asf/hive/trunk/contrib/src/test/queries/clientpositive/udf_row_sequence.q 1073978 
  http://svn.apache.org/repos/asf/hive/trunk/contrib/src/test/results/clientnegative/case_with_row_sequence.q.out PRE-CREATION 

Diff: https://reviews.apache.org/r/442/diff


Testing
-------


Thanks,

John

Re: Review Request: HIVE-1994: Support new annotation @UDFType(stateful = true)

Posted by Ted Yu <te...@yahoo.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/442/#review258
-----------------------------------------------------------



http://svn.apache.org/repos/asf/hive/trunk/contrib/src/test/queries/clientpositive/udf_row_sequence.q
<https://reviews.apache.org/r/442/#comment503>

    Can you explain the query below in more detail ?
    When key != 105, short circuiting would happen normally.


- Ted


On 2011-02-23 15:21:56, John Sichi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/442/
> -----------------------------------------------------------
> 
> (Updated 2011-02-23 15:21:56)
> 
> 
> Review request for hive.
> 
> 
> Summary
> -------
> 
> Review request from JVS.
> 
> 
> This addresses bug HIVE-1994.
>     https://issues.apache.org/jira/browse/HIVE-1994
> 
> 
> Diffs
> -----
> 
>   http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/TypeCheckCtx.java 1073978 
>   http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/TypeCheckProcFactory.java 1073978 
>   http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/udf/UDFType.java 1073978 
>   http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/queries/clientpositive/udf_case.q 1073978 
>   http://svn.apache.org/repos/asf/hive/trunk/ql/src/test/results/clientpositive/udf_case.q.out 1073978 
>   http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/ErrorMsg.java 1073978 
>   http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 1073978 
>   http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/ExprNodeGenericFuncEvaluator.java 1073978 
>   http://svn.apache.org/repos/asf/hive/trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java 1073978 
>   http://svn.apache.org/repos/asf/hive/trunk/contrib/src/test/results/clientnegative/invalid_row_sequence.q.out PRE-CREATION 
>   http://svn.apache.org/repos/asf/hive/trunk/contrib/src/test/results/clientpositive/udf_row_sequence.q.out 1073978 
>   http://svn.apache.org/repos/asf/hive/trunk/contrib/src/java/org/apache/hadoop/hive/contrib/udf/UDFRowSequence.java 1073978 
>   http://svn.apache.org/repos/asf/hive/trunk/contrib/src/test/queries/clientnegative/case_with_row_sequence.q PRE-CREATION 
>   http://svn.apache.org/repos/asf/hive/trunk/contrib/src/test/queries/clientnegative/invalid_row_sequence.q PRE-CREATION 
>   http://svn.apache.org/repos/asf/hive/trunk/contrib/src/test/queries/clientpositive/udf_row_sequence.q 1073978 
>   http://svn.apache.org/repos/asf/hive/trunk/contrib/src/test/results/clientnegative/case_with_row_sequence.q.out PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/442/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> John
> 
>