You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "iamhucong (via GitHub)" <gi...@apache.org> on 2023/08/07 09:33:14 UTC
[GitHub] [shardingsphere] iamhucong opened a new pull request, #27966: GitHubTestParameterLoadStrategy support GitHub token.
iamhucong opened a new pull request, #27966:
URL: https://github.com/apache/shardingsphere/pull/27966
---
Before committing this PR, I'm sure that I have checked the following options:
- [ ] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
- [ ] I have self-reviewed the commit code.
- [ ] I have (or in comment I request) added corresponding labels for the pull request.
- [ ] I have passed maven check locally : `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
- [ ] I have made corresponding changes to the documentation.
- [ ] I have added corresponding unit tests for my changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] strongduanmu merged pull request #27966: GitHubTestParameterLoadStrategy support GitHub token.
Posted by "strongduanmu (via GitHub)" <gi...@apache.org>.
strongduanmu merged PR #27966:
URL: https://github.com/apache/shardingsphere/pull/27966
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] strongduanmu commented on a diff in pull request #27966: GitHubTestParameterLoadStrategy support GitHub token.
Posted by "strongduanmu (via GitHub)" <gi...@apache.org>.
strongduanmu commented on code in PR #27966:
URL: https://github.com/apache/shardingsphere/pull/27966#discussion_r1286520586
##########
test/util/src/main/java/org/apache/shardingsphere/test/loader/strategy/impl/GitHubTestParameterLoadStrategy.java:
##########
@@ -75,10 +81,14 @@ private URI getGitHubApiUri(final URI sqlCaseURI) {
}
private String loadContent(final URI casesURI) {
- try (
- InputStreamReader in = new InputStreamReader(casesURI.toURL().openStream());
- BufferedReader reader = new BufferedReader(in)) {
- return reader.lines().collect(Collectors.joining(System.lineSeparator()));
+ try {
+ final URLConnection urlConnection = casesURI.toURL().openConnection();
Review Comment:
Please remove final modifier here.
##########
test/util/src/main/resources/env/test-util-env.properties:
##########
@@ -0,0 +1,17 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+test.util.github.token=
Review Comment:
Why add github token?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] binbin6363 commented on pull request #27966: GitHubTestParameterLoadStrategy support GitHub token.
Posted by "binbin6363 (via GitHub)" <gi...@apache.org>.
binbin6363 commented on PR #27966:
URL: https://github.com/apache/shardingsphere/pull/27966#issuecomment-1668802450
您好,您的邮件我已收到,尽快给您回复。祝您生活愉快!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org