You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2022/11/22 16:35:07 UTC

[GitHub] [pinot] gortiz opened a new pull request, #9842: [draft] Add chronicle bytes alternative to LArray.

gortiz opened a new pull request, #9842:
URL: https://github.com/apache/pinot/pull/9842

   This PR explores the possibility of using [Chronicle Bytes](https://github.com/OpenHFT/Chronicle-Bytes) as an implementation of PinotDataBuffer instead of LArray. The main reason to do that is to be able to run with newer JVM versions where LArray is not supported.
   
   See #9162 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


[GitHub] [pinot] gortiz commented on pull request #9842: [draft] Add chronicle bytes alternative to LArray.

Posted by GitBox <gi...@apache.org>.
gortiz commented on PR #9842:
URL: https://github.com/apache/pinot/pull/9842#issuecomment-1323953675

   This first commit is a draft. Tests need to be extended to cover the new implementation and I would also add at least one benchmark to verify that there is no performance degradation. It would also be great to add some verification that with this change Pinot will be able to run with Java 17.
   
   Also, writing the code I've seen some places where the buffers are being use and there may be better implementations, but I would also need to benchmark the alternative to be sure (and this can be done in another PR)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


[GitHub] [pinot] gortiz closed pull request #9842: [draft] Add chronicle bytes alternative to LArray.

Posted by "gortiz (via GitHub)" <gi...@apache.org>.
gortiz closed pull request #9842: [draft] Add chronicle bytes alternative to LArray.
URL: https://github.com/apache/pinot/pull/9842


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org