[GitHub] [dolphinscheduler] krystalics commented on a change in pull request #8263: bugfix:[Bug] [remote-rpc] the asynchronous call method cannot use oth…

[GitBox <gi...@apache.org>]

krystalics commented on a change in pull request #8263:
URL: https://github.com/apache/dolphinscheduler/pull/8263#discussion_r795116196



##########
File path: dolphinscheduler-remote/src/main/java/org/apache/dolphinscheduler/rpc/remote/NettyClient.java
##########
@@ -211,7 +211,8 @@ public RpcResponse sendMsg(Host host, RpcProtocol<RpcRequest> protocol, Boolean
         if (Boolean.TRUE.equals(async)) {
             result = new RpcResponse();
             result.setStatus((byte) 0);
-            result.setResult(true);
+            //firstly return a null value when meet the async call
+            result.setResult(null);

Review comment:
       in my opinion , the return type of meothd in async call cannot used directly,it must use the callback mechanism to get the real response.
   so the `result==true` can't be judge in the very fisrt time to use.
   It's very awesome you can reply in this Spring Festival , thx




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org