You are viewing a plain text version of this content. The canonical link for it is here.
Posted to oak-issues@jackrabbit.apache.org by "angela (JIRA)" <ji...@apache.org> on 2016/04/18 10:03:25 UTC

[jira] [Resolved] (OAK-4048) [regression] SyncHandler.listIdentities() returns all users, not only external ones

     [ https://issues.apache.org/jira/browse/OAK-4048?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

angela resolved OAK-4048.
-------------------------
    Resolution: Not A Problem

I discussed this with [~tripod], when we scanned all open issues for oak-auth-external module and he didn't consider this a regression.

Also there might be other reasons why the {{SyncIdentity}} might return a null {{ExternalIdentityRef}}. So checking for null is anyway required and in fact mandated by the API contract.

> [regression] SyncHandler.listIdentities() returns all users, not only external ones
> -----------------------------------------------------------------------------------
>
>                 Key: OAK-4048
>                 URL: https://issues.apache.org/jira/browse/OAK-4048
>             Project: Jackrabbit Oak
>          Issue Type: Bug
>          Components: auth-external
>            Reporter: Alexander Klimetschek
>         Attachments: OAK-4048.patch
>
>
> OAK-3508 accidentally introduced a regression in https://github.com/apache/jackrabbit-oak/commit/cc78f6fdd122d1c9f200b43fc2b9536518ea996b#diff-490ff25c104d019ee25f92b2b8bdbabd
> If {{getIdentityRef(auth)}} returns null, {{createSyncedIdentity}} needs to return null.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)