You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/03/26 11:15:44 UTC
[GitHub] [airflow] ashb opened a new issue #15028: Don't remove "full tests required" label when PR is created with it
ashb opened a new issue #15028:
URL: https://github.com/apache/airflow/issues/15028
Right now we have some process/part of the CI pipeline that is removing the "full tests required" label from newly created PRs. https://github.com/apache/airflow/pull/15022#event-4510424213
This only applies to committers/PMC who can choose to apply this label to a PR (non committers can't control labels) but in this case we shouldn't remove the label.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on issue #15028: Don't remove "full tests required" label when PR is created with it
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #15028:
URL: https://github.com/apache/airflow/issues/15028#issuecomment-808451865
It gets removed when the Image is not in "removed" state
The current process is that label is not really supposed to be "manually" set - it is set automatically when we determine that the PR "likely" needs full tests and after it gets approved by a committer. If it gets "deapproved" it looses the label. We might want to change it that once the label is set (whether automated or manual) it can only get removed manually. That might be actually a nice improvement of the current workflow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] eladkal commented on issue #15028: Don't remove "full tests required" label when PR is created with it
Posted by GitBox <gi...@apache.org>.
eladkal commented on issue #15028:
URL: https://github.com/apache/airflow/issues/15028#issuecomment-942174489
@potiuk this is solved, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on issue #15028: Don't remove "full tests required" label when PR is created with it
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #15028:
URL: https://github.com/apache/airflow/issues/15028#issuecomment-808461387
PR created in @TobKed 's action: https://github.com/TobKed/label-when-approved-action/pull/6
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on issue #15028: Don't remove "full tests required" label when PR is created with it
Posted by GitBox <gi...@apache.org>.
ashb commented on issue #15028:
URL: https://github.com/apache/airflow/issues/15028#issuecomment-808452997
I've been setting it manually as an optimization (for instance when I know a change will need full tests.) to avoid a second test run. I _thought_ this used to work, but I'm not 100% sure.
In this case it didn't get unapproved, it was just never approved :).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on issue #15028: Don't remove "full tests required" label when PR is created with it
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #15028:
URL: https://github.com/apache/airflow/issues/15028#issuecomment-808453894
Yeah. to be precise the label is automatically removed now when the PR has no "Approved" status (non-approved also falls in this category :) ). It think @TobKed that would require slight change in the action of yours ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk closed issue #15028: Don't remove "full tests required" label when PR is created with it
Posted by GitBox <gi...@apache.org>.
potiuk closed issue #15028:
URL: https://github.com/apache/airflow/issues/15028
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk closed issue #15028: Don't remove "full tests required" label when PR is created with it
Posted by GitBox <gi...@apache.org>.
potiuk closed issue #15028:
URL: https://github.com/apache/airflow/issues/15028
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org