[GitHub] [hbase-filesystem] wchevreuil commented on a change in pull request #14: HBASE-24961 [HBOSS] HBaseObjectStoreSemantics.close should call super.close to make sure its own instance always get removed from FileSystem.CACHE

[GitBox <gi...@apache.org>]

wchevreuil commented on a change in pull request #14:
URL: https://github.com/apache/hbase-filesystem/pull/14#discussion_r478988871



##########
File path: hbase-oss/src/main/java/org/apache/hadoop/hbase/oss/sync/ZKTreeLockManager.java
##########
@@ -180,9 +196,12 @@ protected boolean writeLockAbove(Path p) throws IOException {
     LOG.debug("Checking for write lock above {}", p);
     while (!p.isRoot()) {
       p = p.getParent();
-      if (isLocked(get(p).writeLock())) {
-        LOG.debug("Parent write lock currently held: {}", p);
-        return true;
+      //We need to protect this block against potential concurrent calls to close()
+      synchronized (this) {

Review comment:
       Makes sense, let me do it.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org