You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/11/08 16:25:51 UTC
[GitHub] [arrow-rs] mattbonnell opened a new pull request, #3048: fix: pin ahash to 0.8.0
mattbonnell opened a new pull request, #3048:
URL: https://github.com/apache/arrow-rs/pull/3048
0.8.1 has a bug https://github.com/tkaitchuck/aHash/issues/143
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold commented on pull request #3048: fix: pin ahash to 0.8.0
Posted by GitBox <gi...@apache.org>.
tustvold commented on PR #3048:
URL: https://github.com/apache/arrow-rs/pull/3048#issuecomment-1308143734
Yes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold commented on pull request #3048: fix: pin ahash to 0.8.0
Posted by GitBox <gi...@apache.org>.
tustvold commented on PR #3048:
URL: https://github.com/apache/arrow-rs/pull/3048#issuecomment-1308172643
My understanding is it is just ignored outside of nightly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold closed pull request #3048: fix: pin ahash to 0.8.0
Posted by GitBox <gi...@apache.org>.
tustvold closed pull request #3048: fix: pin ahash to 0.8.0
URL: https://github.com/apache/arrow-rs/pull/3048
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold commented on pull request #3048: fix: pin ahash to 0.8.0
Posted by GitBox <gi...@apache.org>.
tustvold commented on PR #3048:
URL: https://github.com/apache/arrow-rs/pull/3048#issuecomment-1314303348
Closing this, as workarounds exist, and the change to ahash has been reverted - https://github.com/tkaitchuck/aHash/pull/145
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] mattbonnell commented on pull request #3048: fix: pin ahash to 0.8.0
Posted by GitBox <gi...@apache.org>.
mattbonnell commented on PR #3048:
URL: https://github.com/apache/arrow-rs/pull/3048#issuecomment-1308857004
> My understanding is it is just ignored outside of nightly
You mentioned this would affect folks using custom build tooling. I’m using Bazel, do you think that’s related?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold commented on a diff in pull request #3048: fix: pin ahash to 0.8.0
Posted by GitBox <gi...@apache.org>.
tustvold commented on code in PR #3048:
URL: https://github.com/apache/arrow-rs/pull/3048#discussion_r1018332641
##########
arrow/Cargo.toml:
##########
@@ -38,10 +38,10 @@ path = "src/lib.rs"
bench = false
[target.'cfg(target_arch = "wasm32")'.dependencies]
-ahash = { version = "0.8", default-features = false, features = ["compile-time-rng"] }
+ahash = { version = "0.8.0", default-features = false, features = ["compile-time-rng"] }
Review Comment:
```suggestion
ahash = { version = "=0.8.0", default-features = false, features = ["compile-time-rng"] }
```
FYI you will need an exact version pin, cargo applies semver compatibility by default
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold commented on pull request #3048: fix: pin ahash to 0.8.0
Posted by GitBox <gi...@apache.org>.
tustvold commented on PR #3048:
URL: https://github.com/apache/arrow-rs/pull/3048#issuecomment-1307731672
I believe this pin be just added by impacted downstreams, i.e. those that are using custom build tooling. I'm not sure we need to pin this here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold commented on pull request #3048: fix: pin ahash to 0.8.0
Posted by GitBox <gi...@apache.org>.
tustvold commented on PR #3048:
URL: https://github.com/apache/arrow-rs/pull/3048#issuecomment-1309242360
Yes, we had issues with hakari parsing the ahash crate, that @carols10cents tracked down to https://github.com/EmbarkStudios/cfg-expr/pull/52#issue-1436484665
My understanding is that some parsers don't correctly understand unstable cargo build attributes, and this causes custom build tooling to fail.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] mattbonnell commented on pull request #3048: fix: pin ahash to 0.8.0
Posted by GitBox <gi...@apache.org>.
mattbonnell commented on PR #3048:
URL: https://github.com/apache/arrow-rs/pull/3048#issuecomment-1308098342
> I believe this pin be just added by impacted downstreams, i.e. those that are using custom build tooling. I'm not sure we need to pin this here?
Can you pin a sub-dependency?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] mattbonnell commented on pull request #3048: fix: pin ahash to 0.8.0
Posted by GitBox <gi...@apache.org>.
mattbonnell commented on PR #3048:
URL: https://github.com/apache/arrow-rs/pull/3048#issuecomment-1308156802
> Yes
I had tried but it didn’t seem to be working. Will try again.
Even so, ahash-8.0.1 uses cfg-target-abi, which is only available in nightly Rust. Doesn’t this then mean that installing arrow will fail for anyone not running a nightly, as it is for me?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org