You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucenenet.apache.org by GitBox <gi...@apache.org> on 2020/10/01 20:45:01 UTC
[GitHub] [lucenenet] shadowcaptain opened a new pull request #361: Update PerfRunData.cs
shadowcaptain opened a new pull request #361:
URL: https://github.com/apache/lucenenet/pull/361
Make CreateDirectory method virtual so that derived classes can provide their own Directory implementation, allowing for benchmarking of custom Directory providers (e.q LiteDB)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [lucenenet] NightOwl888 merged pull request #361: Update PerfRunData.cs
Posted by GitBox <gi...@apache.org>.
NightOwl888 merged pull request #361:
URL: https://github.com/apache/lucenenet/pull/361
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [lucenenet] eladmarg commented on pull request #361: Update PerfRunData.cs
Posted by GitBox <gi...@apache.org>.
eladmarg commented on pull request #361:
URL: https://github.com/apache/lucenenet/pull/361#issuecomment-702567422
Fine by me.
approved.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [lucenenet] NightOwl888 commented on pull request #361: Update PerfRunData.cs
Posted by GitBox <gi...@apache.org>.
NightOwl888 commented on pull request #361:
URL: https://github.com/apache/lucenenet/pull/361#issuecomment-703179724
@shadowcaptain
Thanks for the PR. For future reference, please indicate where and why we have diverged from Lucene 4.8.0's API by leaving a comment prefixed with `// LUCENENET specific -`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org