You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "grundprinzip (via GitHub)" <gi...@apache.org> on 2024/04/15 21:17:46 UTC
[PR] [SPARK-47862][PYTHON][CONNECT]Fix generation of proto files [spark]
grundprinzip opened a new pull request, #46068:
URL: https://github.com/apache/spark/pull/46068
### What changes were proposed in this pull request?
When Spark Connect generates the protobuf files, we move them to the correct folder and adjust the package imports. However, we did not properly adjust the module name of the serialized descriptor. This in turn breaks serialization of the descriptors using Cloudpickle.
### Why are the changes needed?
Compatibility
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
Manual
### Was this patch authored or co-authored using generative AI tooling?
No
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-47862][PYTHON][CONNECT]Fix generation of proto files [spark]
Posted by "grundprinzip (via GitHub)" <gi...@apache.org>.
grundprinzip commented on code in PR #46068:
URL: https://github.com/apache/spark/pull/46068#discussion_r1566664745
##########
dev/connect-gen-protos.sh:
##########
@@ -97,4 +100,4 @@ for f in `find gen/proto/python -name "*.py*"`; do
done
# Clean up everything.
-rm -Rf gen
+# rm -Rf gen
Review Comment:
```suggestion
rm -Rf gen
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-47862][PYTHON][CONNECT]Fix generation of proto files [spark]
Posted by "grundprinzip (via GitHub)" <gi...@apache.org>.
grundprinzip commented on code in PR #46068:
URL: https://github.com/apache/spark/pull/46068#discussion_r1566668212
##########
dev/connect-gen-protos.sh:
##########
@@ -97,4 +100,4 @@ for f in `find gen/proto/python -name "*.py*"`; do
done
# Clean up everything.
-rm -Rf gen
+# rm -Rf gen
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-47862][PYTHON][CONNECT]Fix generation of proto files [spark]
Posted by "grundprinzip (via GitHub)" <gi...@apache.org>.
grundprinzip commented on code in PR #46068:
URL: https://github.com/apache/spark/pull/46068#discussion_r1566660150
##########
dev/connect-gen-protos.sh:
##########
@@ -97,4 +100,4 @@ for f in `find gen/proto/python -name "*.py*"`; do
done
# Clean up everything.
-rm -Rf gen
+# rm -Rf gen
Review Comment:
yes, my bad.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-47862][PYTHON][CONNECT]Fix generation of proto files [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #46068:
URL: https://github.com/apache/spark/pull/46068#issuecomment-2058191383
Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-47862][PYTHON][CONNECT]Fix generation of proto files [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon closed pull request #46068: [SPARK-47862][PYTHON][CONNECT]Fix generation of proto files
URL: https://github.com/apache/spark/pull/46068
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-47862][PYTHON][CONNECT]Fix generation of proto files [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on code in PR #46068:
URL: https://github.com/apache/spark/pull/46068#discussion_r1566577876
##########
dev/connect-gen-protos.sh:
##########
@@ -97,4 +100,4 @@ for f in `find gen/proto/python -name "*.py*"`; do
done
# Clean up everything.
-rm -Rf gen
+# rm -Rf gen
Review Comment:
should we remove this back?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org