[GitHub] [tvm] vinx13 commented on a change in pull request #9168: Adding annotations for tir.allocate

[GitBox <gi...@apache.org>]

vinx13 commented on a change in pull request #9168:
URL: https://github.com/apache/tvm/pull/9168#discussion_r721830600



##########
File path: include/tvm/tir/stmt.h
##########
@@ -817,9 +827,7 @@ class ForNode : public StmtNode {
    * \brief Additional annotations about the loop.
    *
    *  These annotations can be used as auxiliary hint
-   *  to future transformations. An annotation should
-   *  not change the control flow semantics of the loop
-   *  and can be ignored in most passes.
+   *  to future transformations.

Review comment:
       this change is unrelated?

##########
File path: include/tvm/tir/stmt.h
##########
@@ -521,20 +521,28 @@ class AllocateNode : public StmtNode {
   PrimExpr condition;
   /*! \brief The body to be executed. */
   Stmt body;
+  /*!
+   * \brief Additional annotations about the loop.

Review comment:
       ```suggestion
      * \brief Additional annotations about the allocation.
   ```
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org