You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@shindig.apache.org by "Matthew Marum (Created) (JIRA)" <ji...@apache.org> on 2011/12/13 16:53:31 UTC
[jira] [Created] (SHINDIG-1675) Add support for Embedded Experience
Gadgets in the CommonContainer test environment
Add support for Embedded Experience Gadgets in the CommonContainer test environment
-----------------------------------------------------------------------------------
Key: SHINDIG-1675
URL: https://issues.apache.org/jira/browse/SHINDIG-1675
Project: Shindig
Issue Type: New Feature
Components: Javascript
Affects Versions: 3.0.0
Reporter: Matthew Marum
Priority: Minor
Fix For: 3.0.0
As we start to build (and promote the use of) embedded experience gadgets, we need to provide easier ways for Gadget developers to quickly prototype these gadgets. I'd like to add an Embedded Experience Gadgets section to the Common Container test environment (http://localhost:8080/samplecontainer/examples/commoncontainer/) so you can quickly set a Gadget URL and the context to be passed on render.
This has makes EE gadgets much easier to quickly test.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (SHINDIG-1675) Add support for Embedded Experience
Gadgets in the CommonContainer test environment
Posted by "Matthew Marum (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1675?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Matthew Marum updated SHINDIG-1675:
-----------------------------------
Description:
As we start to build (and promote the use of) embedded experience gadgets, we need to provide easier ways for Gadget developers to quickly prototype these gadgets. I'd like to add an Embedded Experience Gadgets section to the Common Container test environment (http://localhost:8080/samplecontainer/examples/commoncontainer/) so you can quickly set a Gadget URL and the context to be passed on render.
This makes quickly testing EE gadgets much easier.
was:
As we start to build (and promote the use of) embedded experience gadgets, we need to provide easier ways for Gadget developers to quickly prototype these gadgets. I'd like to add an Embedded Experience Gadgets section to the Common Container test environment (http://localhost:8080/samplecontainer/examples/commoncontainer/) so you can quickly set a Gadget URL and the context to be passed on render.
This has makes quickly testing EE gadgets much easier.
> Add support for Embedded Experience Gadgets in the CommonContainer test environment
> -----------------------------------------------------------------------------------
>
> Key: SHINDIG-1675
> URL: https://issues.apache.org/jira/browse/SHINDIG-1675
> Project: Shindig
> Issue Type: New Feature
> Components: Javascript
> Affects Versions: 3.0.0
> Reporter: Matthew Marum
> Priority: Minor
> Fix For: 3.0.0
>
> Attachments: addEEtoCommonContainer.patch
>
>
> As we start to build (and promote the use of) embedded experience gadgets, we need to provide easier ways for Gadget developers to quickly prototype these gadgets. I'd like to add an Embedded Experience Gadgets section to the Common Container test environment (http://localhost:8080/samplecontainer/examples/commoncontainer/) so you can quickly set a Gadget URL and the context to be passed on render.
> This makes quickly testing EE gadgets much easier.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (SHINDIG-1675) Add support for Embedded Experience
Gadgets in the CommonContainer test environment
Posted by "Matthew Marum (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1675?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Matthew Marum updated SHINDIG-1675:
-----------------------------------
Attachment: (was: eegadget.patch)
> Add support for Embedded Experience Gadgets in the CommonContainer test environment
> -----------------------------------------------------------------------------------
>
> Key: SHINDIG-1675
> URL: https://issues.apache.org/jira/browse/SHINDIG-1675
> Project: Shindig
> Issue Type: New Feature
> Components: Javascript
> Affects Versions: 3.0.0
> Reporter: Matthew Marum
> Priority: Minor
> Fix For: 3.0.0
>
> Attachments: eegadget.patch
>
>
> As we start to build (and promote the use of) embedded experience gadgets, we need to provide easier ways for Gadget developers to quickly prototype these gadgets. I'd like to add an Embedded Experience Gadgets section to the Common Container test environment (http://localhost:8080/samplecontainer/examples/commoncontainer/) so you can quickly set a Gadget URL and the context to be passed on render.
> This makes quickly testing EE gadgets much easier.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SHINDIG-1675) Add support for Embedded
Experience Gadgets in the CommonContainer test environment
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13168469#comment-13168469 ]
jiraposter@reviews.apache.org commented on SHINDIG-1675:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3165/
-----------------------------------------------------------
Review request for shindig.
Summary
-------
As we start to build (and promote the use of) embedded experience gadgets, we need to provide easier ways for Gadget developers to quickly prototype these gadgets. I'd like to add an Embedded Experience Gadgets section to the Common Container test environment (http://localhost:8080/samplecontainer/examples/commoncontainer/) so you can quickly set a Gadget URL and the context to be passed on render.
This has makes quickly testing EE gadgets much easier.
This addresses bug SHINDIG-1675.
https://issues.apache.org/jira/browse/SHINDIG-1675
Diffs
-----
/trunk/content/samplecontainer/examples/commoncontainer/assembler.js 1213743
/trunk/content/samplecontainer/examples/commoncontainer/cconviews.js 1213743
/trunk/content/samplecontainer/examples/commoncontainer/index.html 1213743
/trunk/content/samplecontainer/examples/commoncontainer/viewController.js 1213743
Diff: https://reviews.apache.org/r/3165/diff
Testing
-------
Tested locally with some EE gadgets I've been building. Andy Smith has used it too. There are no automated tests for the sample containers.
Thanks,
Matt
> Add support for Embedded Experience Gadgets in the CommonContainer test environment
> -----------------------------------------------------------------------------------
>
> Key: SHINDIG-1675
> URL: https://issues.apache.org/jira/browse/SHINDIG-1675
> Project: Shindig
> Issue Type: New Feature
> Components: Javascript
> Affects Versions: 3.0.0
> Reporter: Matthew Marum
> Priority: Minor
> Fix For: 3.0.0
>
> Attachments: addEEtoCommonContainer.patch
>
>
> As we start to build (and promote the use of) embedded experience gadgets, we need to provide easier ways for Gadget developers to quickly prototype these gadgets. I'd like to add an Embedded Experience Gadgets section to the Common Container test environment (http://localhost:8080/samplecontainer/examples/commoncontainer/) so you can quickly set a Gadget URL and the context to be passed on render.
> This has makes quickly testing EE gadgets much easier.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (SHINDIG-1675) Add support for Embedded Experience
Gadgets in the CommonContainer test environment
Posted by "Matthew Marum (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1675?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Matthew Marum updated SHINDIG-1675:
-----------------------------------
Attachment: eegadget.patch
> Add support for Embedded Experience Gadgets in the CommonContainer test environment
> -----------------------------------------------------------------------------------
>
> Key: SHINDIG-1675
> URL: https://issues.apache.org/jira/browse/SHINDIG-1675
> Project: Shindig
> Issue Type: New Feature
> Components: Javascript
> Affects Versions: 3.0.0
> Reporter: Matthew Marum
> Priority: Minor
> Fix For: 3.0.0
>
> Attachments: eegadget.patch
>
>
> As we start to build (and promote the use of) embedded experience gadgets, we need to provide easier ways for Gadget developers to quickly prototype these gadgets. I'd like to add an Embedded Experience Gadgets section to the Common Container test environment (http://localhost:8080/samplecontainer/examples/commoncontainer/) so you can quickly set a Gadget URL and the context to be passed on render.
> This makes quickly testing EE gadgets much easier.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (SHINDIG-1675) Add support for Embedded Experience
Gadgets in the CommonContainer test environment
Posted by "Matthew Marum (Closed) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1675?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Matthew Marum closed SHINDIG-1675.
----------------------------------
> Add support for Embedded Experience Gadgets in the CommonContainer test environment
> -----------------------------------------------------------------------------------
>
> Key: SHINDIG-1675
> URL: https://issues.apache.org/jira/browse/SHINDIG-1675
> Project: Shindig
> Issue Type: New Feature
> Components: Javascript
> Affects Versions: 3.0.0
> Reporter: Matthew Marum
> Priority: Minor
> Fix For: 3.0.0
>
> Attachments: eegadget.patch
>
>
> As we start to build (and promote the use of) embedded experience gadgets, we need to provide easier ways for Gadget developers to quickly prototype these gadgets. I'd like to add an Embedded Experience Gadgets section to the Common Container test environment (http://localhost:8080/samplecontainer/examples/commoncontainer/) so you can quickly set a Gadget URL and the context to be passed on render.
> This makes quickly testing EE gadgets much easier.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SHINDIG-1675) Add support for Embedded
Experience Gadgets in the CommonContainer test environment
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13182522#comment-13182522 ]
jiraposter@reviews.apache.org commented on SHINDIG-1675:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3165/#review4265
-----------------------------------------------------------
Ship it!
Removed extra white space and committed. Thanks Matt!
Committed revision 1229170.
- Ryan
On 2012-01-08 23:08:29, Matt Marum wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/3165/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2012-01-08 23:08:29)
bq.
bq.
bq. Review request for shindig.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. As we start to build (and promote the use of) embedded experience gadgets, we need to provide easier ways for Gadget developers to quickly prototype these gadgets. I'd like to add an Embedded Experience Gadgets section to the Common Container test environment (http://localhost:8080/samplecontainer/examples/commoncontainer/) so you can quickly set a Gadget URL and the context to be passed on render.
bq.
bq. This has makes quickly testing EE gadgets much easier.
bq.
bq.
bq. This addresses bug SHINDIG-1675.
bq. https://issues.apache.org/jira/browse/SHINDIG-1675
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. /trunk/content/samplecontainer/examples/commoncontainer/assembler.js 1228330
bq. /trunk/content/samplecontainer/examples/commoncontainer/cconviews.js 1228330
bq. /trunk/content/samplecontainer/examples/commoncontainer/index.html 1228330
bq. /trunk/content/samplecontainer/examples/commoncontainer/viewController.js 1228330
bq.
bq. Diff: https://reviews.apache.org/r/3165/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Tested locally with some EE gadgets I've been building. Andy Smith has used it too. There are no automated tests for the sample containers.
bq.
bq.
bq. Thanks,
bq.
bq. Matt
bq.
bq.
> Add support for Embedded Experience Gadgets in the CommonContainer test environment
> -----------------------------------------------------------------------------------
>
> Key: SHINDIG-1675
> URL: https://issues.apache.org/jira/browse/SHINDIG-1675
> Project: Shindig
> Issue Type: New Feature
> Components: Javascript
> Affects Versions: 3.0.0
> Reporter: Matthew Marum
> Priority: Minor
> Fix For: 3.0.0
>
> Attachments: eegadget.patch
>
>
> As we start to build (and promote the use of) embedded experience gadgets, we need to provide easier ways for Gadget developers to quickly prototype these gadgets. I'd like to add an Embedded Experience Gadgets section to the Common Container test environment (http://localhost:8080/samplecontainer/examples/commoncontainer/) so you can quickly set a Gadget URL and the context to be passed on render.
> This makes quickly testing EE gadgets much easier.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SHINDIG-1675) Add support for Embedded
Experience Gadgets in the CommonContainer test environment
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13182322#comment-13182322 ]
jiraposter@reviews.apache.org commented on SHINDIG-1675:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3165/
-----------------------------------------------------------
(Updated 2012-01-08 23:08:29.278791)
Review request for shindig.
Changes
-------
Fixed HTML layout.
Summary
-------
As we start to build (and promote the use of) embedded experience gadgets, we need to provide easier ways for Gadget developers to quickly prototype these gadgets. I'd like to add an Embedded Experience Gadgets section to the Common Container test environment (http://localhost:8080/samplecontainer/examples/commoncontainer/) so you can quickly set a Gadget URL and the context to be passed on render.
This has makes quickly testing EE gadgets much easier.
This addresses bug SHINDIG-1675.
https://issues.apache.org/jira/browse/SHINDIG-1675
Diffs (updated)
-----
/trunk/content/samplecontainer/examples/commoncontainer/assembler.js 1228330
/trunk/content/samplecontainer/examples/commoncontainer/cconviews.js 1228330
/trunk/content/samplecontainer/examples/commoncontainer/index.html 1228330
/trunk/content/samplecontainer/examples/commoncontainer/viewController.js 1228330
Diff: https://reviews.apache.org/r/3165/diff
Testing
-------
Tested locally with some EE gadgets I've been building. Andy Smith has used it too. There are no automated tests for the sample containers.
Thanks,
Matt
> Add support for Embedded Experience Gadgets in the CommonContainer test environment
> -----------------------------------------------------------------------------------
>
> Key: SHINDIG-1675
> URL: https://issues.apache.org/jira/browse/SHINDIG-1675
> Project: Shindig
> Issue Type: New Feature
> Components: Javascript
> Affects Versions: 3.0.0
> Reporter: Matthew Marum
> Priority: Minor
> Fix For: 3.0.0
>
> Attachments: eegadget.patch
>
>
> As we start to build (and promote the use of) embedded experience gadgets, we need to provide easier ways for Gadget developers to quickly prototype these gadgets. I'd like to add an Embedded Experience Gadgets section to the Common Container test environment (http://localhost:8080/samplecontainer/examples/commoncontainer/) so you can quickly set a Gadget URL and the context to be passed on render.
> This makes quickly testing EE gadgets much easier.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (SHINDIG-1675) Add support for Embedded Experience
Gadgets in the CommonContainer test environment
Posted by "Matthew Marum (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1675?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Matthew Marum updated SHINDIG-1675:
-----------------------------------
Attachment: addEEtoCommonContainer.patch
> Add support for Embedded Experience Gadgets in the CommonContainer test environment
> -----------------------------------------------------------------------------------
>
> Key: SHINDIG-1675
> URL: https://issues.apache.org/jira/browse/SHINDIG-1675
> Project: Shindig
> Issue Type: New Feature
> Components: Javascript
> Affects Versions: 3.0.0
> Reporter: Matthew Marum
> Priority: Minor
> Fix For: 3.0.0
>
> Attachments: addEEtoCommonContainer.patch
>
>
> As we start to build (and promote the use of) embedded experience gadgets, we need to provide easier ways for Gadget developers to quickly prototype these gadgets. I'd like to add an Embedded Experience Gadgets section to the Common Container test environment (http://localhost:8080/samplecontainer/examples/commoncontainer/) so you can quickly set a Gadget URL and the context to be passed on render.
> This has makes EE gadgets much easier to quickly test.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SHINDIG-1675) Add support for Embedded
Experience Gadgets in the CommonContainer test environment
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13173203#comment-13173203 ]
jiraposter@reviews.apache.org commented on SHINDIG-1675:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3165/#review4011
-----------------------------------------------------------
Matt there is some good cleanup here, thanks! I am just wondering whether it makes sense to have this functionality added to the embedded experience sample container that is already part of Shindig? What do you think....
/trunk/content/samplecontainer/examples/commoncontainer/viewController.js
<https://reviews.apache.org/r/3165/#comment9083>
Looks like there is some spacing problems here
/trunk/content/samplecontainer/examples/commoncontainer/viewController.js
<https://reviews.apache.org/r/3165/#comment9084>
I believe jQuery provides a function that we can use instead of eval
/trunk/content/samplecontainer/examples/commoncontainer/viewController.js
<https://reviews.apache.org/r/3165/#comment9085>
It might be worth also specifying height and width for URL Rendar Params
- Ryan
On 2011-12-13 16:04:45, Matt Marum wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/3165/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-12-13 16:04:45)
bq.
bq.
bq. Review request for shindig.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. As we start to build (and promote the use of) embedded experience gadgets, we need to provide easier ways for Gadget developers to quickly prototype these gadgets. I'd like to add an Embedded Experience Gadgets section to the Common Container test environment (http://localhost:8080/samplecontainer/examples/commoncontainer/) so you can quickly set a Gadget URL and the context to be passed on render.
bq.
bq. This has makes quickly testing EE gadgets much easier.
bq.
bq.
bq. This addresses bug SHINDIG-1675.
bq. https://issues.apache.org/jira/browse/SHINDIG-1675
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. /trunk/content/samplecontainer/examples/commoncontainer/assembler.js 1213743
bq. /trunk/content/samplecontainer/examples/commoncontainer/cconviews.js 1213743
bq. /trunk/content/samplecontainer/examples/commoncontainer/index.html 1213743
bq. /trunk/content/samplecontainer/examples/commoncontainer/viewController.js 1213743
bq.
bq. Diff: https://reviews.apache.org/r/3165/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Tested locally with some EE gadgets I've been building. Andy Smith has used it too. There are no automated tests for the sample containers.
bq.
bq.
bq. Thanks,
bq.
bq. Matt
bq.
bq.
> Add support for Embedded Experience Gadgets in the CommonContainer test environment
> -----------------------------------------------------------------------------------
>
> Key: SHINDIG-1675
> URL: https://issues.apache.org/jira/browse/SHINDIG-1675
> Project: Shindig
> Issue Type: New Feature
> Components: Javascript
> Affects Versions: 3.0.0
> Reporter: Matthew Marum
> Priority: Minor
> Fix For: 3.0.0
>
> Attachments: addEEtoCommonContainer.patch
>
>
> As we start to build (and promote the use of) embedded experience gadgets, we need to provide easier ways for Gadget developers to quickly prototype these gadgets. I'd like to add an Embedded Experience Gadgets section to the Common Container test environment (http://localhost:8080/samplecontainer/examples/commoncontainer/) so you can quickly set a Gadget URL and the context to be passed on render.
> This makes quickly testing EE gadgets much easier.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (SHINDIG-1675) Add support for Embedded Experience
Gadgets in the CommonContainer test environment
Posted by "Matthew Marum (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1675?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Matthew Marum updated SHINDIG-1675:
-----------------------------------
Description:
As we start to build (and promote the use of) embedded experience gadgets, we need to provide easier ways for Gadget developers to quickly prototype these gadgets. I'd like to add an Embedded Experience Gadgets section to the Common Container test environment (http://localhost:8080/samplecontainer/examples/commoncontainer/) so you can quickly set a Gadget URL and the context to be passed on render.
This has makes quickly testing EE gadgets much easier.
was:
As we start to build (and promote the use of) embedded experience gadgets, we need to provide easier ways for Gadget developers to quickly prototype these gadgets. I'd like to add an Embedded Experience Gadgets section to the Common Container test environment (http://localhost:8080/samplecontainer/examples/commoncontainer/) so you can quickly set a Gadget URL and the context to be passed on render.
This has makes EE gadgets much easier to quickly test.
> Add support for Embedded Experience Gadgets in the CommonContainer test environment
> -----------------------------------------------------------------------------------
>
> Key: SHINDIG-1675
> URL: https://issues.apache.org/jira/browse/SHINDIG-1675
> Project: Shindig
> Issue Type: New Feature
> Components: Javascript
> Affects Versions: 3.0.0
> Reporter: Matthew Marum
> Priority: Minor
> Fix For: 3.0.0
>
> Attachments: addEEtoCommonContainer.patch
>
>
> As we start to build (and promote the use of) embedded experience gadgets, we need to provide easier ways for Gadget developers to quickly prototype these gadgets. I'd like to add an Embedded Experience Gadgets section to the Common Container test environment (http://localhost:8080/samplecontainer/examples/commoncontainer/) so you can quickly set a Gadget URL and the context to be passed on render.
> This has makes quickly testing EE gadgets much easier.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (SHINDIG-1675) Add support for Embedded Experience
Gadgets in the CommonContainer test environment
Posted by "Matthew Marum (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1675?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Matthew Marum updated SHINDIG-1675:
-----------------------------------
Attachment: (was: addEEtoCommonContainer.patch)
> Add support for Embedded Experience Gadgets in the CommonContainer test environment
> -----------------------------------------------------------------------------------
>
> Key: SHINDIG-1675
> URL: https://issues.apache.org/jira/browse/SHINDIG-1675
> Project: Shindig
> Issue Type: New Feature
> Components: Javascript
> Affects Versions: 3.0.0
> Reporter: Matthew Marum
> Priority: Minor
> Fix For: 3.0.0
>
>
> As we start to build (and promote the use of) embedded experience gadgets, we need to provide easier ways for Gadget developers to quickly prototype these gadgets. I'd like to add an Embedded Experience Gadgets section to the Common Container test environment (http://localhost:8080/samplecontainer/examples/commoncontainer/) so you can quickly set a Gadget URL and the context to be passed on render.
> This makes quickly testing EE gadgets much easier.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SHINDIG-1675) Add support for Embedded
Experience Gadgets in the CommonContainer test environment
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13174174#comment-13174174 ]
jiraposter@reviews.apache.org commented on SHINDIG-1675:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3165/#review4040
-----------------------------------------------------------
/trunk/content/samplecontainer/examples/commoncontainer/viewController.js
<https://reviews.apache.org/r/3165/#comment9145>
Will do.
- Matt
On 2011-12-21 16:05:37, Matt Marum wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/3165/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-12-21 16:05:37)
bq.
bq.
bq. Review request for shindig.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. As we start to build (and promote the use of) embedded experience gadgets, we need to provide easier ways for Gadget developers to quickly prototype these gadgets. I'd like to add an Embedded Experience Gadgets section to the Common Container test environment (http://localhost:8080/samplecontainer/examples/commoncontainer/) so you can quickly set a Gadget URL and the context to be passed on render.
bq.
bq. This has makes quickly testing EE gadgets much easier.
bq.
bq.
bq. This addresses bug SHINDIG-1675.
bq. https://issues.apache.org/jira/browse/SHINDIG-1675
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. /trunk/content/samplecontainer/examples/commoncontainer/assembler.js 1220905
bq. /trunk/content/samplecontainer/examples/commoncontainer/cconviews.js 1220905
bq. /trunk/content/samplecontainer/examples/commoncontainer/index.html 1220905
bq. /trunk/content/samplecontainer/examples/commoncontainer/viewController.js 1220905
bq.
bq. Diff: https://reviews.apache.org/r/3165/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Tested locally with some EE gadgets I've been building. Andy Smith has used it too. There are no automated tests for the sample containers.
bq.
bq.
bq. Thanks,
bq.
bq. Matt
bq.
bq.
> Add support for Embedded Experience Gadgets in the CommonContainer test environment
> -----------------------------------------------------------------------------------
>
> Key: SHINDIG-1675
> URL: https://issues.apache.org/jira/browse/SHINDIG-1675
> Project: Shindig
> Issue Type: New Feature
> Components: Javascript
> Affects Versions: 3.0.0
> Reporter: Matthew Marum
> Priority: Minor
> Fix For: 3.0.0
>
> Attachments: addEEtoCommonContainer.patch
>
>
> As we start to build (and promote the use of) embedded experience gadgets, we need to provide easier ways for Gadget developers to quickly prototype these gadgets. I'd like to add an Embedded Experience Gadgets section to the Common Container test environment (http://localhost:8080/samplecontainer/examples/commoncontainer/) so you can quickly set a Gadget URL and the context to be passed on render.
> This makes quickly testing EE gadgets much easier.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SHINDIG-1675) Add support for Embedded
Experience Gadgets in the CommonContainer test environment
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13174172#comment-13174172 ]
jiraposter@reviews.apache.org commented on SHINDIG-1675:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3165/
-----------------------------------------------------------
(Updated 2011-12-21 16:05:37.642013)
Review request for shindig.
Changes
-------
Added support for setting embedded experience gadget height/width in test page.
Summary
-------
As we start to build (and promote the use of) embedded experience gadgets, we need to provide easier ways for Gadget developers to quickly prototype these gadgets. I'd like to add an Embedded Experience Gadgets section to the Common Container test environment (http://localhost:8080/samplecontainer/examples/commoncontainer/) so you can quickly set a Gadget URL and the context to be passed on render.
This has makes quickly testing EE gadgets much easier.
This addresses bug SHINDIG-1675.
https://issues.apache.org/jira/browse/SHINDIG-1675
Diffs (updated)
-----
/trunk/content/samplecontainer/examples/commoncontainer/assembler.js 1220905
/trunk/content/samplecontainer/examples/commoncontainer/cconviews.js 1220905
/trunk/content/samplecontainer/examples/commoncontainer/index.html 1220905
/trunk/content/samplecontainer/examples/commoncontainer/viewController.js 1220905
Diff: https://reviews.apache.org/r/3165/diff
Testing
-------
Tested locally with some EE gadgets I've been building. Andy Smith has used it too. There are no automated tests for the sample containers.
Thanks,
Matt
> Add support for Embedded Experience Gadgets in the CommonContainer test environment
> -----------------------------------------------------------------------------------
>
> Key: SHINDIG-1675
> URL: https://issues.apache.org/jira/browse/SHINDIG-1675
> Project: Shindig
> Issue Type: New Feature
> Components: Javascript
> Affects Versions: 3.0.0
> Reporter: Matthew Marum
> Priority: Minor
> Fix For: 3.0.0
>
> Attachments: addEEtoCommonContainer.patch
>
>
> As we start to build (and promote the use of) embedded experience gadgets, we need to provide easier ways for Gadget developers to quickly prototype these gadgets. I'd like to add an Embedded Experience Gadgets section to the Common Container test environment (http://localhost:8080/samplecontainer/examples/commoncontainer/) so you can quickly set a Gadget URL and the context to be passed on render.
> This makes quickly testing EE gadgets much easier.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (SHINDIG-1675) Add support for Embedded Experience
Gadgets in the CommonContainer test environment
Posted by "Matthew Marum (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1675?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Matthew Marum updated SHINDIG-1675:
-----------------------------------
Attachment: addEEtoCommonContainer.patch
> Add support for Embedded Experience Gadgets in the CommonContainer test environment
> -----------------------------------------------------------------------------------
>
> Key: SHINDIG-1675
> URL: https://issues.apache.org/jira/browse/SHINDIG-1675
> Project: Shindig
> Issue Type: New Feature
> Components: Javascript
> Affects Versions: 3.0.0
> Reporter: Matthew Marum
> Priority: Minor
> Fix For: 3.0.0
>
> Attachments: addEEtoCommonContainer.patch
>
>
> As we start to build (and promote the use of) embedded experience gadgets, we need to provide easier ways for Gadget developers to quickly prototype these gadgets. I'd like to add an Embedded Experience Gadgets section to the Common Container test environment (http://localhost:8080/samplecontainer/examples/commoncontainer/) so you can quickly set a Gadget URL and the context to be passed on render.
> This has makes quickly testing EE gadgets much easier.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SHINDIG-1675) Add support for Embedded
Experience Gadgets in the CommonContainer test environment
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13174181#comment-13174181 ]
jiraposter@reviews.apache.org commented on SHINDIG-1675:
--------------------------------------------------------
bq. On 2011-12-20 14:00:30, Ryan Baxter wrote:
bq. > /trunk/content/samplecontainer/examples/commoncontainer/viewController.js, line 207
bq. > <https://reviews.apache.org/r/3165/diff/2/?file=64332#file64332line207>
bq. >
bq. > I believe jQuery provides a function that we can use instead of eval
bq.
bq. Matt Marum wrote:
bq. The jQuery eval function that I found was..
bq.
bq. http://api.jquery.com/jQuery.globalEval/
bq.
bq. From the doc..
bq. "This method behaves differently from using a normal JavaScript eval() in that it's executed within the global context (which is important for loading external scripts dynamically)."
bq.
bq. In this case, I'm not sure if it is necessary or even desirable to allow the user input to run within the global context but I'm still a mostly novice JavaScript programmer so I can be easily convinced otherwise. Unless it does some input sanitizing or something.
Now that I am thinking about this you should be able to use gadgets.json.parse
- Ryan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3165/#review4011
-----------------------------------------------------------
On 2011-12-21 16:05:37, Matt Marum wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/3165/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-12-21 16:05:37)
bq.
bq.
bq. Review request for shindig.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. As we start to build (and promote the use of) embedded experience gadgets, we need to provide easier ways for Gadget developers to quickly prototype these gadgets. I'd like to add an Embedded Experience Gadgets section to the Common Container test environment (http://localhost:8080/samplecontainer/examples/commoncontainer/) so you can quickly set a Gadget URL and the context to be passed on render.
bq.
bq. This has makes quickly testing EE gadgets much easier.
bq.
bq.
bq. This addresses bug SHINDIG-1675.
bq. https://issues.apache.org/jira/browse/SHINDIG-1675
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. /trunk/content/samplecontainer/examples/commoncontainer/assembler.js 1220905
bq. /trunk/content/samplecontainer/examples/commoncontainer/cconviews.js 1220905
bq. /trunk/content/samplecontainer/examples/commoncontainer/index.html 1220905
bq. /trunk/content/samplecontainer/examples/commoncontainer/viewController.js 1220905
bq.
bq. Diff: https://reviews.apache.org/r/3165/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Tested locally with some EE gadgets I've been building. Andy Smith has used it too. There are no automated tests for the sample containers.
bq.
bq.
bq. Thanks,
bq.
bq. Matt
bq.
bq.
> Add support for Embedded Experience Gadgets in the CommonContainer test environment
> -----------------------------------------------------------------------------------
>
> Key: SHINDIG-1675
> URL: https://issues.apache.org/jira/browse/SHINDIG-1675
> Project: Shindig
> Issue Type: New Feature
> Components: Javascript
> Affects Versions: 3.0.0
> Reporter: Matthew Marum
> Priority: Minor
> Fix For: 3.0.0
>
> Attachments: eegadget.patch
>
>
> As we start to build (and promote the use of) embedded experience gadgets, we need to provide easier ways for Gadget developers to quickly prototype these gadgets. I'd like to add an Embedded Experience Gadgets section to the Common Container test environment (http://localhost:8080/samplecontainer/examples/commoncontainer/) so you can quickly set a Gadget URL and the context to be passed on render.
> This makes quickly testing EE gadgets much easier.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SHINDIG-1675) Add support for Embedded
Experience Gadgets in the CommonContainer test environment
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13182064#comment-13182064 ]
jiraposter@reviews.apache.org commented on SHINDIG-1675:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3165/#review4240
-----------------------------------------------------------
/trunk/content/samplecontainer/examples/commoncontainer/index.html
<https://reviews.apache.org/r/3165/#comment9592>
You probably want to wrap these label - input element combinations in divs or but breaks inbetween them. If the screen is wide enough the labels end up not being on the same line as the input fields.
- Ryan
On 2011-12-21 17:24:41, Matt Marum wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/3165/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-12-21 17:24:41)
bq.
bq.
bq. Review request for shindig.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. As we start to build (and promote the use of) embedded experience gadgets, we need to provide easier ways for Gadget developers to quickly prototype these gadgets. I'd like to add an Embedded Experience Gadgets section to the Common Container test environment (http://localhost:8080/samplecontainer/examples/commoncontainer/) so you can quickly set a Gadget URL and the context to be passed on render.
bq.
bq. This has makes quickly testing EE gadgets much easier.
bq.
bq.
bq. This addresses bug SHINDIG-1675.
bq. https://issues.apache.org/jira/browse/SHINDIG-1675
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. /trunk/content/samplecontainer/examples/commoncontainer/viewController.js 1220905
bq. /trunk/content/samplecontainer/examples/commoncontainer/assembler.js 1220905
bq. /trunk/content/samplecontainer/examples/commoncontainer/cconviews.js 1220905
bq. /trunk/content/samplecontainer/examples/commoncontainer/index.html 1220905
bq.
bq. Diff: https://reviews.apache.org/r/3165/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Tested locally with some EE gadgets I've been building. Andy Smith has used it too. There are no automated tests for the sample containers.
bq.
bq.
bq. Thanks,
bq.
bq. Matt
bq.
bq.
> Add support for Embedded Experience Gadgets in the CommonContainer test environment
> -----------------------------------------------------------------------------------
>
> Key: SHINDIG-1675
> URL: https://issues.apache.org/jira/browse/SHINDIG-1675
> Project: Shindig
> Issue Type: New Feature
> Components: Javascript
> Affects Versions: 3.0.0
> Reporter: Matthew Marum
> Priority: Minor
> Fix For: 3.0.0
>
> Attachments: eegadget.patch
>
>
> As we start to build (and promote the use of) embedded experience gadgets, we need to provide easier ways for Gadget developers to quickly prototype these gadgets. I'd like to add an Embedded Experience Gadgets section to the Common Container test environment (http://localhost:8080/samplecontainer/examples/commoncontainer/) so you can quickly set a Gadget URL and the context to be passed on render.
> This makes quickly testing EE gadgets much easier.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (SHINDIG-1675) Add support for Embedded Experience
Gadgets in the CommonContainer test environment
Posted by "Matthew Marum (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1675?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Matthew Marum updated SHINDIG-1675:
-----------------------------------
Attachment: eegadget.patch
updated patch
> Add support for Embedded Experience Gadgets in the CommonContainer test environment
> -----------------------------------------------------------------------------------
>
> Key: SHINDIG-1675
> URL: https://issues.apache.org/jira/browse/SHINDIG-1675
> Project: Shindig
> Issue Type: New Feature
> Components: Javascript
> Affects Versions: 3.0.0
> Reporter: Matthew Marum
> Priority: Minor
> Fix For: 3.0.0
>
> Attachments: eegadget.patch
>
>
> As we start to build (and promote the use of) embedded experience gadgets, we need to provide easier ways for Gadget developers to quickly prototype these gadgets. I'd like to add an Embedded Experience Gadgets section to the Common Container test environment (http://localhost:8080/samplecontainer/examples/commoncontainer/) so you can quickly set a Gadget URL and the context to be passed on render.
> This makes quickly testing EE gadgets much easier.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (SHINDIG-1675) Add support for Embedded Experience
Gadgets in the CommonContainer test environment
Posted by "Matthew Marum (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1675?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Matthew Marum updated SHINDIG-1675:
-----------------------------------
Attachment: (was: addEEtoCommonContainer.patch)
> Add support for Embedded Experience Gadgets in the CommonContainer test environment
> -----------------------------------------------------------------------------------
>
> Key: SHINDIG-1675
> URL: https://issues.apache.org/jira/browse/SHINDIG-1675
> Project: Shindig
> Issue Type: New Feature
> Components: Javascript
> Affects Versions: 3.0.0
> Reporter: Matthew Marum
> Priority: Minor
> Fix For: 3.0.0
>
> Attachments: addEEtoCommonContainer.patch
>
>
> As we start to build (and promote the use of) embedded experience gadgets, we need to provide easier ways for Gadget developers to quickly prototype these gadgets. I'd like to add an Embedded Experience Gadgets section to the Common Container test environment (http://localhost:8080/samplecontainer/examples/commoncontainer/) so you can quickly set a Gadget URL and the context to be passed on render.
> This has makes quickly testing EE gadgets much easier.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SHINDIG-1675) Add support for Embedded
Experience Gadgets in the CommonContainer test environment
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13174239#comment-13174239 ]
jiraposter@reviews.apache.org commented on SHINDIG-1675:
--------------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3165/
-----------------------------------------------------------
(Updated 2011-12-21 17:24:41.770174)
Review request for shindig.
Changes
-------
Using gadgets.json.parse now.
Summary
-------
As we start to build (and promote the use of) embedded experience gadgets, we need to provide easier ways for Gadget developers to quickly prototype these gadgets. I'd like to add an Embedded Experience Gadgets section to the Common Container test environment (http://localhost:8080/samplecontainer/examples/commoncontainer/) so you can quickly set a Gadget URL and the context to be passed on render.
This has makes quickly testing EE gadgets much easier.
This addresses bug SHINDIG-1675.
https://issues.apache.org/jira/browse/SHINDIG-1675
Diffs (updated)
-----
/trunk/content/samplecontainer/examples/commoncontainer/viewController.js 1220905
/trunk/content/samplecontainer/examples/commoncontainer/assembler.js 1220905
/trunk/content/samplecontainer/examples/commoncontainer/cconviews.js 1220905
/trunk/content/samplecontainer/examples/commoncontainer/index.html 1220905
Diff: https://reviews.apache.org/r/3165/diff
Testing
-------
Tested locally with some EE gadgets I've been building. Andy Smith has used it too. There are no automated tests for the sample containers.
Thanks,
Matt
> Add support for Embedded Experience Gadgets in the CommonContainer test environment
> -----------------------------------------------------------------------------------
>
> Key: SHINDIG-1675
> URL: https://issues.apache.org/jira/browse/SHINDIG-1675
> Project: Shindig
> Issue Type: New Feature
> Components: Javascript
> Affects Versions: 3.0.0
> Reporter: Matthew Marum
> Priority: Minor
> Fix For: 3.0.0
>
> Attachments: eegadget.patch
>
>
> As we start to build (and promote the use of) embedded experience gadgets, we need to provide easier ways for Gadget developers to quickly prototype these gadgets. I'd like to add an Embedded Experience Gadgets section to the Common Container test environment (http://localhost:8080/samplecontainer/examples/commoncontainer/) so you can quickly set a Gadget URL and the context to be passed on render.
> This makes quickly testing EE gadgets much easier.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (SHINDIG-1675) Add support for Embedded
Experience Gadgets in the CommonContainer test environment
Posted by "jiraposter@reviews.apache.org (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-1675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13174173#comment-13174173 ]
jiraposter@reviews.apache.org commented on SHINDIG-1675:
--------------------------------------------------------
bq. On 2011-12-20 14:00:30, Ryan Baxter wrote:
bq. > /trunk/content/samplecontainer/examples/commoncontainer/viewController.js, line 207
bq. > <https://reviews.apache.org/r/3165/diff/2/?file=64332#file64332line207>
bq. >
bq. > I believe jQuery provides a function that we can use instead of eval
The jQuery eval function that I found was..
http://api.jquery.com/jQuery.globalEval/
bq. From the doc..
"This method behaves differently from using a normal JavaScript eval() in that it's executed within the global context (which is important for loading external scripts dynamically)."
In this case, I'm not sure if it is necessary or even desirable to allow the user input to run within the global context but I'm still a mostly novice JavaScript programmer so I can be easily convinced otherwise. Unless it does some input sanitizing or something.
- Matt
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/3165/#review4011
-----------------------------------------------------------
On 2011-12-21 16:05:37, Matt Marum wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/3165/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-12-21 16:05:37)
bq.
bq.
bq. Review request for shindig.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. As we start to build (and promote the use of) embedded experience gadgets, we need to provide easier ways for Gadget developers to quickly prototype these gadgets. I'd like to add an Embedded Experience Gadgets section to the Common Container test environment (http://localhost:8080/samplecontainer/examples/commoncontainer/) so you can quickly set a Gadget URL and the context to be passed on render.
bq.
bq. This has makes quickly testing EE gadgets much easier.
bq.
bq.
bq. This addresses bug SHINDIG-1675.
bq. https://issues.apache.org/jira/browse/SHINDIG-1675
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. /trunk/content/samplecontainer/examples/commoncontainer/assembler.js 1220905
bq. /trunk/content/samplecontainer/examples/commoncontainer/cconviews.js 1220905
bq. /trunk/content/samplecontainer/examples/commoncontainer/index.html 1220905
bq. /trunk/content/samplecontainer/examples/commoncontainer/viewController.js 1220905
bq.
bq. Diff: https://reviews.apache.org/r/3165/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Tested locally with some EE gadgets I've been building. Andy Smith has used it too. There are no automated tests for the sample containers.
bq.
bq.
bq. Thanks,
bq.
bq. Matt
bq.
bq.
> Add support for Embedded Experience Gadgets in the CommonContainer test environment
> -----------------------------------------------------------------------------------
>
> Key: SHINDIG-1675
> URL: https://issues.apache.org/jira/browse/SHINDIG-1675
> Project: Shindig
> Issue Type: New Feature
> Components: Javascript
> Affects Versions: 3.0.0
> Reporter: Matthew Marum
> Priority: Minor
> Fix For: 3.0.0
>
> Attachments: addEEtoCommonContainer.patch
>
>
> As we start to build (and promote the use of) embedded experience gadgets, we need to provide easier ways for Gadget developers to quickly prototype these gadgets. I'd like to add an Embedded Experience Gadgets section to the Common Container test environment (http://localhost:8080/samplecontainer/examples/commoncontainer/) so you can quickly set a Gadget URL and the context to be passed on render.
> This makes quickly testing EE gadgets much easier.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira