[GitHub] [dubbo-go] justxuewei commented on a diff in pull request #2274: refactor: remove providers and add prefix when use polaris

["justxuewei (via GitHub)" <gi...@apache.org>]

justxuewei commented on code in PR #2274:
URL: https://github.com/apache/dubbo-go/pull/2274#discussion_r1161190662


##########
registry/polaris/registry.go:
##########
@@ -115,11 +118,11 @@ func (pr *polarisRegistry) Register(url *common.URL) error {
 }
 
 // UnRegister returns nil if unregister successfully. If not, returns an error.
-func (pr *polarisRegistry) UnRegister(conf *common.URL) error {
-	request := createDeregisterParam(conf, getServiceName(conf))
+func (pr *polarisRegistry) UnRegister(url *common.URL) error {
+	request := createDeregisterParam(url, url.Interface())
 	request.Namespace = pr.namespace
 	if err := pr.provider.Deregister(request); err != nil {
-		return perrors.WithMessagef(err, "register(conf:%+v)", conf)
+		return perrors.WithMessagef(err, "fail to deregister(conf:%+v)", url)

Review Comment:
   ```suggestion
   		return perrors.WithMessagef(err, "failed to deregister service from the Polaris registry, url = %v", url)
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org