[GitHub] arina-ielchiieva commented on a change in pull request #1543: DRILL-6668: In Web UI, highlight options that are not default values

[GitBox <gi...@apache.org>]

arina-ielchiieva commented on a change in pull request #1543:  DRILL-6668: In Web UI, highlight options that are not default values 
URL: https://github.com/apache/drill/pull/1543#discussion_r233953319
 
 

 ##########
 File path: exec/java-exec/src/main/resources/rest/options.ftl
 ##########
 @@ -21,6 +21,26 @@
 <#macro page_head>
     <script type="text/javascript" language="javascript"  src="/static/js/jquery.dataTables-1.10.16.min.js"> </script>
     <script type="text/javascript" language="javascript" src="/static/js/dataTables.colVis-1.1.0.min.js"></script>
+    <script>
+        //Alter System Values
+        function alterSysOption(optionName, optionValue, optionKind) {
+            $.post("/option/"+optionName, {kind: optionKind, name: optionName, value: optionValue}, function () {
+                location.reload(true);
+            });
+        }
+
+        //Read Values and apply
+        function alterSysOptionUsingId(optionRawName) {
 
 Review comment:
   Looks like before we just had POST method on the Update button and did not have to do replacements. I would prefer if e stick to previous approach or define one without parsing and replacements.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services